Re: [PATCH 5/5] scsi: Remove scmd->tag

2014-10-02 Thread Finn Thain
On Thu, 2 Oct 2014, Hannes Reinecke wrote: > struct scsi_cmnd has a 'tag' field, which was supposed to be > used to support SCSI-II tagged command queueing. > In the end tagged command queueing support moved into the > block layer, with the tag number available in the request. > So the 'tag' fiel

Re: [PATCH 5/5] scsi: Remove scmd->tag

2014-10-02 Thread Hannes Reinecke
On 10/02/2014 01:22 PM, Christoph Hellwig wrote: >> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c >> index a0c8c5d..cb68089 100644 >> --- a/drivers/scsi/NCR5380.c >> +++ b/drivers/scsi/NCR5380.c >> @@ -1527,7 +1527,6 @@ part2: >> tmp[0] = IDENTIFY(((instance->irq == SCSI_IRQ_NON

Re: [PATCH 5/5] scsi: Remove scmd->tag

2014-10-02 Thread Christoph Hellwig
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c > index a0c8c5d..cb68089 100644 > --- a/drivers/scsi/NCR5380.c > +++ b/drivers/scsi/NCR5380.c > @@ -1527,7 +1527,6 @@ part2: > tmp[0] = IDENTIFY(((instance->irq == SCSI_IRQ_NONE) ? 0 : 1), > cmd->device->lun); > > len = 1

[PATCH 5/5] scsi: Remove scmd->tag

2014-10-02 Thread Hannes Reinecke
struct scsi_cmnd has a 'tag' field, which was supposed to be used to support SCSI-II tagged command queueing. In the end tagged command queueing support moved into the block layer, with the tag number available in the request. So the 'tag' field lost its original meaning and can be removed. Signed