Re: [PATCH 7/7] block: allocate block_pc data separate from struct request

On Wed, May 06, 2015 at 02:46:18PM +0300, Boaz Harrosh wrote: - memset(rq-__cmd, 0, sizeof(rq-__cmd)); + + rq-block_pc = kzalloc(sizeof(*rq-block_pc) + cmd_len, gfp); I wish you would not embed a dynamic allocation here for any driver regardless. This extra allocation does hurt a

[PATCH 7/7] block: allocate block_pc data separate from struct request

Don't bloat struct request with BLOCK_PC specific fields. WIP, breaks dm BLOCK_PC passthrough and the old IDE driver for now. --- block/blk-core.c| 23 ++--- block/blk-exec.c| 17 --- block/blk-mq.c | 4