RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-11 Thread Anil Gurumurthy
ernel.org>; linux-scsi <linux-scsi@vger.kernel.org> Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() >>>>> "Denys" == Denys Vlasenko <dvlas...@redhat.com> writes: Denys> __bfa_trc32() is very similar, so it is uninlined too. However

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-11 Thread Martin K. Petersen
> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc() compiles to 115 bytes of machine code. With this Denys> .config: http://busybox.net/~vda/kernel_config there are 1494 Denys> calls of __bfa_trc(). Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-10 Thread Martin K. Petersen
> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc32() is very similar, so it is uninlined too. However, Denys> it appears to be unused, therefore this patch ifdefs it out. Why don't we just drop it? -- Martin K. Petersen Oracle Linux Engineering -- To

[PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-04 Thread Denys Vlasenko
__bfa_trc() compiles to 115 bytes of machine code. With this .config: http://busybox.net/~vda/kernel_config there are 1494 calls of __bfa_trc(). __bfa_trc32() is very similar, so it is uninlined too. However, it appears to be unused, therefore this patch ifdefs it out. Change in code size is