On Thu, 2018-03-08 at 21:42 +0800, Ming Lei wrote:
> On Wed, Mar 07, 2018 at 09:11:37AM -0500, Laurence Oberman wrote:
> > On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote:
> > > Ming,
> > >
> > > > Given both Don and Laurence have verified that patch 1 and
> > > > patch 2
> > > > does
On Thu, 2018-03-08 at 09:41 +0100, Hannes Reinecke wrote:
> IE the _entire_ request set is allocated as _one_ array, making it quite
> hard to handle from the lower-level CPU caches.
> Also the 'node' indicator doesn't really help us here, as the requests
> have to be access by all CPUs in the
On Wed, Mar 07, 2018 at 09:11:37AM -0500, Laurence Oberman wrote:
> On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote:
> > Ming,
> >
> > > Given both Don and Laurence have verified that patch 1 and patch 2
> > > does fix IO hang, could you consider to merge the two first?
> >
> > Oh,
On Thu, Mar 08, 2018 at 09:41:16AM +0100, Hannes Reinecke wrote:
> On 03/08/2018 09:15 AM, Ming Lei wrote:
> > On Thu, Mar 08, 2018 at 08:50:35AM +0100, Christoph Hellwig wrote:
> >>> +static void hpsa_setup_reply_map(struct ctlr_info *h)
> >>> +{
> >>> + const struct cpumask *mask;
> >>> +
On 03/08/2018 09:15 AM, Ming Lei wrote:
> On Thu, Mar 08, 2018 at 08:50:35AM +0100, Christoph Hellwig wrote:
>>> +static void hpsa_setup_reply_map(struct ctlr_info *h)
>>> +{
>>> + const struct cpumask *mask;
>>> + unsigned int queue, cpu;
>>> +
>>> + for (queue = 0; queue < h->msix_vectors;
On Thu, Mar 08, 2018 at 08:50:35AM +0100, Christoph Hellwig wrote:
> > +static void hpsa_setup_reply_map(struct ctlr_info *h)
> > +{
> > + const struct cpumask *mask;
> > + unsigned int queue, cpu;
> > +
> > + for (queue = 0; queue < h->msix_vectors; queue++) {
> > + mask =
> +static void hpsa_setup_reply_map(struct ctlr_info *h)
> +{
> + const struct cpumask *mask;
> + unsigned int queue, cpu;
> +
> + for (queue = 0; queue < h->msix_vectors; queue++) {
> + mask = pci_irq_get_affinity(h->pdev, queue);
> + if (!mask)
> +
On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote:
> Ming,
>
> > Given both Don and Laurence have verified that patch 1 and patch 2
> > does fix IO hang, could you consider to merge the two first?
>
> Oh, and I would still need a formal Acked-by: from Don and Tested-by:
> from
Ming,
> Please consider 2/8 too since it is still a fix.
I still need the driver maintainer to ack the change.
--
Martin K. Petersen Oracle Linux Engineering
On Tue, Mar 06, 2018 at 02:24:25PM -0500, Martin K. Petersen wrote:
>
> Ming,
>
> > Given both Don and Laurence have verified that patch 1 and patch 2
> > does fix IO hang, could you consider to merge the two first?
>
> Oh, and I would still need a formal Acked-by: from Don and Tested-by:
>
Ming,
> Given both Don and Laurence have verified that patch 1 and patch 2
> does fix IO hang, could you consider to merge the two first?
Oh, and I would still need a formal Acked-by: from Don and Tested-by:
from Laurence.
Also, for 4.16/scsi-fixes I would prefer verification to be done with
Hi Ming,
> Given both Don and Laurence have verified that patch 1 and patch 2
> does fix IO hang, could you consider to merge the two first?
I'm not going to merge the MR patch until Kashyap acks it.
--
Martin K. Petersen Oracle Linux Engineering
s Axboe; linux-bl...@vger.kernel.org; Christoph Hellwig; Mike
> > Snitzer;
> > linux-scsi@vger.kernel.org; Hannes Reinecke; Arun Easi; Omar Sandoval;
> > Martin K . Petersen; James Bottomley; Christoph Hellwig; Kashyap Desai;
> > Peter
> > Rivera; Meelis Roos
> &
rtin K .
> Petersen <martin.peter...@oracle.com>; James Bottomley
> <james.bottom...@hansenpartnership.com>; Christoph Hellwig <h...@lst.de>;
> Peter Rivera <peter.riv...@broadcom.com>; Meelis Roos <mr...@linux.ee>
> Subject: RE: [PATCH V3 1/8] s
ecke; Arun Easi; Omar Sandoval;
> Martin K . Petersen; James Bottomley; Christoph Hellwig; Kashyap Desai;
> Peter
> Rivera; Meelis Roos
> Subject: Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue
>
> On Fri, 2018-03-02 at 15:03 +, Don Brace wrote:
> > > -Or
t; > Bottomley <james.bottom...@hansenpartnership.com>; Christoph
> > > Hellwig
> > > <h...@lst.de>; Kashyap Desai <kashyap.de...@broadcom.com>; Peter
> > > Rivera
> > > <peter.riv...@broadcom.com>; Meelis Roos <mr...@linux.ee>
>
t; > > > > <arun.e...@cavium.com>; Omar Sandoval <osan...@fb.com>;
> > > > > > > Martin K
> > > > > > > .
> > > > > > > Petersen <martin.peter...@oracle.com>; James Bottomley
> > > > &
gt;; James
> Bottomley <james.bottom...@hansenpartnership.com>; Christoph Hellwig
> <h...@lst.de>; Kashyap Desai <kashyap.de...@broadcom.com>; Peter Rivera
> <peter.riv...@broadcom.com>; Meelis Roos <mr...@linux.ee>
> Subject: Re: [PATCH V3 1/8] scsi: hpsa:
p.com>; Christoph Hellwig > > > > ch@l
> > > > > st
> > > > > .de>;
> > > > > Don Brace <don.br...@microsemi.com>; Kashyap Desai
> > > > > <kashyap.de...@broadcom.com>; Peter Rivera <peter.rivera@broa
> >
omley
> > > > <james.bottom...@hansenpartnership.com>; Christoph Hellwig <hch@l
> > > > st
> > > > .de>;
> > > > Don Brace <don.br...@microsemi.com>; Kashyap Desai
> > > > <kashyap.de...@broadcom.com>; Peter Rivera &
broadcom.com>;
> > Laurence Oberman <lober...@redhat.com>; Ming Lei
> > <ming@redhat.com>; Meelis Roos <mr...@linux.ee>
> > Subject: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue
> >
> > EXTERNAL EMAIL
> >
> >
gt;;
> > > Don Brace <don.br...@microsemi.com>; Kashyap Desai
> > > <kashyap.de...@broadcom.com>; Peter Rivera <peter.rivera@broadcom
> > > .c
> > > om>;
> > > Laurence Oberman <lober...@redhat.com>; Ming Lei
> > > <ming.
martin.peter...@oracle.com>; James Bottomley
> > <james.bottom...@hansenpartnership.com>; Christoph Hellwig <hch@lst
> > .de>;
> > Don Brace <don.br...@microsemi.com>; Kashyap Desai
> > <kashyap.de...@broadcom.com>; Peter Rivera <peter.rivera@broadcom
Hellwig <h...@lst.de>;
> Don Brace <don.br...@microsemi.com>; Kashyap Desai
> <kashyap.de...@broadcom.com>; Peter Rivera <peter.riv...@broadcom.com>;
> Laurence Oberman <lober...@redhat.com>; Ming Lei
> <ming@redhat.com>; Meelis Roos <mr...@linux.ee>
>From 84676c1f21 (genirq/affinity: assign vectors to all possible CPUs),
one msix vector can be created without any online CPU mapped, then one
command's completion may not be notified.
This patch setups mapping between cpu and reply queue according to irq
affinity info retrived by
25 matches
Mail list logo
