Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

This patch should cause no behavioral change. Even the (removal of) the redundant bit mask should be a nop. So it seems like a bit of an overkill to split them. On 22 July 2016 at 02:45, Sergei Shtylyov wrote: > Hello. > > On 07/21/2016 09:41 PM, tom.t...@gmail.com wrote: > >> From: Tom Yan >> >

Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

Hello. On 07/21/2016 09:41 PM, tom.t...@gmail.com wrote: From: Tom Yan 1. Removed a repeated bit masking in ata_mselect_control() 2. Moved `wce`/`d_sense` assignment below the page validity checks 3. Added/Removed empty lines where appropriate Signed-off-by: Tom Yan Perhaps Tejun is OK

[PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

From: Tom Yan 1. Removed a repeated bit masking in ata_mselect_control() 2. Moved `wce`/`d_sense` assignment below the page validity checks 3. Added/Removed empty lines where appropriate Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 2bdb5da..eb