Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

2016-08-09 Thread Tejun Heo
On Sat, Jul 23, 2016 at 02:34:08AM +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > ata_mselect_*() would initialize a char array for storing a copy of > the current mode page. However, char could be signed char. In that > case, bytes larger than 127 would be converted to negative number. >

[PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread tom . ty89
From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff from def_control_mpage[] would become -1. This prevented ata_m