Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-04-01 Thread Tejun Heo
Greetings, James. On Fri, Apr 01, 2005 at 12:09:48PM -0600, James Bottomley wrote: > On Fri, 2005-04-01 at 14:01 +0900, Tejun Heo wrote: > > > Well, REQ_SPECIAL is the signal to the mid-layer that we've allocated > > > the resources necessary to process the command, so in practice it will > > > b

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-04-01 Thread James Bottomley
On Fri, 2005-04-01 at 14:01 +0900, Tejun Heo wrote: > > Well, REQ_SPECIAL is the signal to the mid-layer that we've allocated > > the resources necessary to process the command, so in practice it will > > be turned on for every requeue request (because we set it when the > > command is prepared), >

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-03-31 Thread Tejun Heo
Hello, James. On Thu, Mar 31, 2005 at 11:53:20AM -0600, James Bottomley wrote: > On Thu, 2005-03-31 at 18:07 +0900, Tejun Heo wrote: > > 01_scsi_no_REQ_SPECIAL_on_requeue.patch > > > > blk_insert_request() has 'reinsert' argument, which, when set, > > turns on REQ_SPECIAL and REQ_SOFTBAR

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-03-31 Thread Tejun Heo
On Thu, Mar 31, 2005 at 11:12:11AM +0100, Christoph Hellwig wrote: > On Thu, Mar 31, 2005 at 06:07:55PM +0900, Tejun Heo wrote: > > 01_scsi_no_REQ_SPECIAL_on_requeue.patch > > > > blk_insert_request() has 'reinsert' argument, which, when set, > > turns on REQ_SPECIAL and REQ_SOFTBARRIER an

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-03-31 Thread James Bottomley
On Thu, 2005-03-31 at 18:07 +0900, Tejun Heo wrote: > 01_scsi_no_REQ_SPECIAL_on_requeue.patch > > blk_insert_request() has 'reinsert' argument, which, when set, > turns on REQ_SPECIAL and REQ_SOFTBARRIER and requeues the > request. SCSI midlayer was the only user of this feature

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-03-31 Thread Christoph Hellwig
On Thu, Mar 31, 2005 at 06:07:55PM +0900, Tejun Heo wrote: > 01_scsi_no_REQ_SPECIAL_on_requeue.patch > > blk_insert_request() has 'reinsert' argument, which, when set, > turns on REQ_SPECIAL and REQ_SOFTBARRIER and requeues the > request. SCSI midlayer was the only user of this

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-03-31 Thread Tejun Heo
01_scsi_no_REQ_SPECIAL_on_requeue.patch blk_insert_request() has 'reinsert' argument, which, when set, turns on REQ_SPECIAL and REQ_SOFTBARRIER and requeues the request. SCSI midlayer was the only user of this feature and all requeued requests become special reques