Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd-eh_timeout

2005-04-18 Thread James Bottomley
On Mon, 2005-04-11 at 03:45 +0900, Tejun Heo wrote: scmd-eh_timeout is used to resolve the race between command completion and timeout. However, during error handling, scsi_send_eh_cmnd uses scmd-eh_timeout. This creates a race condition between eh and normal

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd-eh_timeout

2005-04-18 Thread Tejun Heo
Hello, James. On Mon, Apr 18, 2005 at 10:33:21AM -0500, James Bottomley wrote: On Mon, 2005-04-11 at 03:45 +0900, Tejun Heo wrote: scmd-eh_timeout is used to resolve the race between command completion and timeout. However, during error handling, scsi_send_eh_cmnd uses

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd-eh_timeout

2005-04-18 Thread James Bottomley
On Tue, 2005-04-19 at 07:31 +0900, Tejun Heo wrote: The original code also uses timer pending status as a signal that command completed normally in scsi_eh_done() function, and the same race also exists in the original code, no matter what we do, unless we make timer expiration and removal of

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd-eh_timeout

2005-04-18 Thread Tejun Heo
James Bottomley wrote: On Tue, 2005-04-19 at 07:31 +0900, Tejun Heo wrote: The original code also uses timer pending status as a signal that command completed normally in scsi_eh_done() function, and the same race also exists in the original code, no matter what we do, unless we make timer

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd-eh_timeout

2005-04-10 Thread Tejun Heo
02_scsi_timer_eh_timer_fix.patch scmd-eh_timeout is used to resolve the race between command completion and timeout. However, during error handling, scsi_send_eh_cmnd uses scmd-eh_timeout. This creates a race condition between eh and normal completion for a