Re: [PATCH scsi-misc-2.6 05/13] scsi: remove a timer race from scsi_queue_insert() and cleanup timer

2005-03-31 Thread Tejun Heo
Hello, Chritoph. On Thu, Mar 31, 2005 at 11:13:53AM +0100, Christoph Hellwig wrote: > > /* Queue the command and wait for it to complete */ > > /* Abuse eh_timeout in the scsi_cmnd struct for our purposes */ > > init_timer(&cmd->eh_timeout); > > + cmd

Re: [PATCH scsi-misc-2.6 05/13] scsi: remove a timer race from scsi_queue_insert() and cleanup timer

2005-03-31 Thread Christoph Hellwig
> /* Queue the command and wait for it to complete */ > /* Abuse eh_timeout in the scsi_cmnd struct for our purposes */ > init_timer(&cmd->eh_timeout); > + cmd->eh_timeout.function = NULL; I'd rather not see aic7xxx poke even deeper into this i

Re: [PATCH scsi-misc-2.6 05/13] scsi: remove a timer race from scsi_queue_insert() and cleanup timer

2005-03-31 Thread Tejun Heo
05_scsi_timer_cleanup.patch scsi_queue_insert() has four callers. Three callers call with timer disabled and one (the second invocation in scsi_dispatch_cmd()) calls with timer activated. scsi_queue_insert() used to always call scsi_delete_timer() and ignor