Re: [PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-24 Thread Bart Van Assche
On 06/24/13 15:34, James Bottomley wrote: On Mon, 2013-06-24 at 09:13 +0200, Bart Van Assche wrote: On 06/24/13 04:36, James Bottomley wrote: On Wed, 2013-06-12 at 14:51 +0200, Bart Van Assche wrote: Now that all scsi_request_fn() callers hold a reference on the SCSI device that function is in

Re: [PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-24 Thread James Bottomley
On Mon, 2013-06-24 at 09:13 +0200, Bart Van Assche wrote: > On 06/24/13 04:36, James Bottomley wrote: > > On Wed, 2013-06-12 at 14:51 +0200, Bart Van Assche wrote: > >> Now that all scsi_request_fn() callers hold a reference on the > >> SCSI device that function is invoked for > > > > What makes yo

Re: [PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-24 Thread Bart Van Assche
On 06/24/13 04:36, James Bottomley wrote: On Wed, 2013-06-12 at 14:51 +0200, Bart Van Assche wrote: Now that all scsi_request_fn() callers hold a reference on the SCSI device that function is invoked for What makes you think that this is a true statement? The usual caller is the block layer,

Re: [PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-23 Thread James Bottomley
On Wed, 2013-06-12 at 14:51 +0200, Bart Van Assche wrote: > Now that all scsi_request_fn() callers hold a reference on the > SCSI device that function is invoked for What makes you think that this is a true statement? The usual caller is the block layer, which doesn't really know anything about t

Re: [PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-23 Thread Mike Christie
On 6/12/13 7:51 AM, Bart Van Assche wrote: Now that all scsi_request_fn() callers hold a reference on the SCSI device that function is invoked for and since blk_cleanup_queue() waits until scsi_request_fn() has finished it is safe to remove the get_device() / put_device() pair from scsi_request_f

[PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-12 Thread Bart Van Assche
Now that all scsi_request_fn() callers hold a reference on the SCSI device that function is invoked for and since blk_cleanup_queue() waits until scsi_request_fn() has finished it is safe to remove the get_device() / put_device() pair from scsi_request_fn(). Signed-off-by: Bart Van Assche Acked-b