Re: [PATCH v11 3/9] Avoid calling __scsi_remove_device() twice

2013-06-25 Thread James Bottomley
On Tue, 2013-06-25 at 10:37 +0200, Bart Van Assche wrote: On 06/24/13 19:38, James Bottomley wrote: On Wed, 2013-06-12 at 14:52 +0200, Bart Van Assche wrote: SCSI devices are added to the shost-__devices list from inside scsi_alloc_sdev(). If something goes wrong during LUN scanning, e.g.

Re: [PATCH v11 3/9] Avoid calling __scsi_remove_device() twice

2013-06-25 Thread Bart Van Assche
On 06/25/13 15:44, James Bottomley wrote: On Tue, 2013-06-25 at 10:37 +0200, Bart Van Assche wrote: On 06/24/13 19:38, James Bottomley wrote: On Wed, 2013-06-12 at 14:52 +0200, Bart Van Assche wrote: SCSI devices are added to the shost-__devices list from inside scsi_alloc_sdev(). If

Re: [PATCH v11 3/9] Avoid calling __scsi_remove_device() twice

2013-06-24 Thread Bart Van Assche
On 06/23/13 23:35, Mike Christie wrote: On 06/12/2013 07:52 AM, Bart Van Assche wrote: SCSI devices are added to the shost-__devices list from inside scsi_alloc_sdev(). If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get

Re: [PATCH v11 3/9] Avoid calling __scsi_remove_device() twice

2013-06-24 Thread James Bottomley
On Wed, 2013-06-12 at 14:52 +0200, Bart Van Assche wrote: SCSI devices are added to the shost-__devices list from inside scsi_alloc_sdev(). If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get invoked by the LUN scanning code

[PATCH v11 3/9] Avoid calling __scsi_remove_device() twice

2013-06-12 Thread Bart Van Assche
SCSI devices are added to the shost-__devices list from inside scsi_alloc_sdev(). If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get invoked by the LUN scanning code for a SCSI device in state SDEV_CREATED_BLOCK or SDEV_BLOCKED.