Re: [PATCH v2] cxlflash: Base support for IBM CXL Flash Adapter

Brian, Thanks for reviewing this patch. Responses are inline below. -matt On May 29, 2015, at 3:54 PM, Brian King wrote: +/* Check for power of 2 at compile time */ +#define NOT_POW2(_x) ((_x) ((_x) ((_x) - 1))) +#if NOT_POW2(CXLFLASH_NUM_CMDS) +#error CXLFLASH_NUM_CMDS is not a power

Re: [PATCH v2] cxlflash: Base support for IBM CXL Flash Adapter

Hi Matt, Comments below... -Brian On 05/22/2015 05:14 PM, Matthew R. Ochs wrote: +++ b/drivers/scsi/cxlflash/common.h @@ -0,0 +1,180 @@ +/* + * CXL Flash Device Driver + * + * Written by: Manoj N. Kumar ma...@linux.vnet.ibm.com, IBM Corporation + * Matthew R. Ochs

[PATCH v2] cxlflash: Base support for IBM CXL Flash Adapter

SCSI device driver to support filesystem access on the IBM CXL Flash adapter. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com --- drivers/scsi/Kconfig|1 + drivers/scsi/Makefile |1 +