Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-09 Thread Tomas Henzl
On 8.2.2017 19:51, Kashyap Desai wrote: >>> +static inline void >>> +megasas_complete_r1_command(struct megasas_instance *instance, >>> + struct megasas_cmd_fusion *cmd) { >>> + u8 *sense, status, ex_status; >>> + u32 data_length; >>> + u16 peer_smid; >>> + struct

Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-09 Thread Tomas Henzl
On 8.2.2017 10:28, Shivasharan S wrote: > fix in v2 - ex_status and status was wrongly re-used in > megasas_complete_r1_command. > discussed below - > http://marc.info/?l=linux-scsi=148638763409385=2 > > > No functional change. Code refactor. > Remove function megasas_fpio_to_ldio as we never

RE: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-08 Thread Kashyap Desai
> > +static inline void > > +megasas_complete_r1_command(struct megasas_instance *instance, > > + struct megasas_cmd_fusion *cmd) { > > + u8 *sense, status, ex_status; > > + u32 data_length; > > + u16 peer_smid; > > + struct fusion_context *fusion; > > + struct

Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-08 Thread Tomas Henzl
On 8.2.2017 10:28, Shivasharan S wrote: > fix in v2 - ex_status and status was wrongly re-used in > megasas_complete_r1_command. > discussed below - > http://marc.info/?l=linux-scsi=148638763409385=2 > > > No functional change. Code refactor. > Remove function megasas_fpio_to_ldio as we never

[PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-08 Thread Shivasharan S
fix in v2 - ex_status and status was wrongly re-used in megasas_complete_r1_command. discussed below - http://marc.info/?l=linux-scsi=148638763409385=2 No functional change. Code refactor. Remove function megasas_fpio_to_ldio as we never require to convert fpio to ldio because of frame