Re: [PATCH v2 04/16] iscsi-target: add void (*iscsit_release_cmd)()

On Sun, Apr 10, 2016 at 08:42:44PM +0300, Sagi Grimberg wrote: > > >Add void (*iscsit_release_cmd)() to > >struct iscsit_transport, iscsi-target > >uses this callback to release transport > >driver resources associated with an iSCSI cmd. > > I'd really like to see some reasoning on why you add >

Re: [PATCH v2 04/16] iscsi-target: add void (*iscsit_release_cmd)()

Add void (*iscsit_release_cmd)() to struct iscsit_transport, iscsi-target uses this callback to release transport driver resources associated with an iSCSI cmd. I'd really like to see some reasoning on why you add abstraction callouts. It may have a valid reason but it needs to be documented

[PATCH v2 04/16] iscsi-target: add void (*iscsit_release_cmd)()

Add void (*iscsit_release_cmd)() to struct iscsit_transport, iscsi-target uses this callback to release transport driver resources associated with an iSCSI cmd. Signed-off-by: Varun Prakash --- drivers/target/iscsi/iscsi_target_util.c | 3 +++