Re: [PATCH v2 07/36] ncr5380: Cleanup TAG_NEXT and TAG_NONE macros

2014-10-29 Thread Hannes Reinecke
On 10/27/2014 06:26 AM, Finn Thain wrote: Both atari_NCR5380.c and sun3_NCR5380.c core drivers #undef TAG_NONE and then redefine it. But the original definition is unused because NCR5380.c lacks support for tagged queueing. So just define it once. The TAG_NEXT macro only appears in the

[PATCH v2 07/36] ncr5380: Cleanup TAG_NEXT and TAG_NONE macros

2014-10-27 Thread Finn Thain
Both atari_NCR5380.c and sun3_NCR5380.c core drivers #undef TAG_NONE and then redefine it. But the original definition is unused because NCR5380.c lacks support for tagged queueing. So just define it once. The TAG_NEXT macro only appears in the arguments to NCR5380_select() calls. But that