RE: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

-Original Message- From: Wei Fang [mailto:fangw...@huawei.com] Sent: June-01-16 10:37 PM >The concurrently decrements of host_failed only lead to abnormal of >host_failed, host_busy will be zero after error handler, and >the result may >be host_failed > host_busy forever. But in your

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

On 2016/6/2 10:37, Wei Fang wrote: > Hi, Kevin, > > On 2016/6/1 22:36, Kevin Groeneveld wrote: >>> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >>> ->host_failed >> >> I wonder if this could be related to >> http:

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

Hi, Kevin, On 2016/6/1 22:36, Kevin Groeneveld wrote: >> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >> ->host_failed > > I wonder if this could be related to > http://www.spinics.net/lists/linux-scsi/msg86808.html? > >

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

Hi, James, On 2016/6/1 22:06, James Bottomley wrote: > On Tue, 2016-05-31 at 16:38 +0800, Wei Fang wrote: >> sas_ata_strategy_handler() adds the works of the ata error handler >> to system_unbound_wq. This workqueue asynchronously runs work items, >> so the ata error handler will be performed

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

On Wed, 2016-06-01 at 08:29 -0700, Bart Van Assche wrote: > On 06/01/2016 07:36 AM, Kevin Groeneveld wrote: > > > Subject: [PATCH v2 1/2] scsi: fix race between simultaneous > > > decrements of ->host_failed > > > > I wonder if this could be related to > &g

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

On 06/01/2016 07:36 AM, Kevin Groeneveld wrote: Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed I wonder if this could be related to http://www.spinics.net/lists/linux-scsi/msg86808.html? I never did get to the bottom of that. If I have time I h

RE: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of > ->host_failed I wonder if this could be related to http://www.spinics.net/lists/linux-scsi/msg86808.html? I never did get to the bottom of that. If I have time I hope to retest my scsi hang issue with t

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

On Tue, 2016-05-31 at 16:38 +0800, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, > so the ata error handler will be performed concurrently on different > CPUs. In this case, ->host_failed

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

On Tue, May 31, 2016 at 8:21 PM, Dan Williams wrote: > On Tue, May 31, 2016 at 1:38 AM, Wei Fang wrote: >> sas_ata_strategy_handler() adds the works of the ata error handler >> to system_unbound_wq. This workqueue asynchronously runs work items, >>

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

On Tue, May 31, 2016 at 1:38 AM, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, > so the ata error handler will be performed concurrently on different > CPUs. In this

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

Hi, Tejun, On 2016/5/31 22:33, Tejun Heo wrote: > On Tue, May 31, 2016 at 04:38:17PM +0800, Wei Fang wrote: >> sas_ata_strategy_handler() adds the works of the ata error handler >> to system_unbound_wq. This workqueue asynchronously runs work items, > > Are there more than one error handling

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

On Tue, May 31, 2016 at 04:38:17PM +0800, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, Are there more than one error handling work items per host? Thanks. -- tejun -- To unsubscribe

[PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

sas_ata_strategy_handler() adds the works of the ata error handler to system_unbound_wq. This workqueue asynchronously runs work items, so the ata error handler will be performed concurrently on different CPUs. In this case, ->host_failed will be decreased simultaneously in scsi_eh_finish_cmd() on