Re: [PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests

On Wed, Aug 30, 2017 at 09:13:00PM +, Bart Van Assche wrote: > On Wed, 2017-08-30 at 10:29 +0200, Christoph Hellwig wrote: > > Looks good except for the subject, which will need a little update: > > Hello Christoph, > > Thanks for the review. Sorry but I don't see what's wrong with the

Re: [PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests

On Wed, 2017-08-30 at 17:14 -0500, Brian King wrote: > On 08/29/2017 07:07 PM, Bart Van Assche wrote: > > If a pass-through request is submitted then blk_get_request() > > initializes that request by calling scsi_initialize_rq(). Also > > call this function for filesystem requests. Introduce > >

Re: [PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests

On 08/29/2017 07:07 PM, Bart Van Assche wrote: > If a pass-through request is submitted then blk_get_request() > initializes that request by calling scsi_initialize_rq(). Also > call this function for filesystem requests. Introduce > CMD_INITIALIZED to keep track of whether or not a request has >

Re: [PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests

On Wed, 2017-08-30 at 10:29 +0200, Christoph Hellwig wrote: > Looks good except for the subject, which will need a little update: Hello Christoph, Thanks for the review. Sorry but I don't see what's wrong with the subject. Can you clarify your comment? Bart.

Re: [PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests

Looks good except for the subject, which will need a little update: Reviewed-by: Christoph Hellwig

[PATCH v2 1/3] Call scsi_initialize_rq() also for filesystem requests

If a pass-through request is submitted then blk_get_request() initializes that request by calling scsi_initialize_rq(). Also call this function for filesystem requests. Introduce CMD_INITIALIZED to keep track of whether or not a request has already been initialized. Signed-off-by: Bart Van Assche