Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-21 Thread James Smart
On 2/20/2018 10:56 PM, Johannes Thumshirn wrote: Yes - I know. On the WC issue though, given how tightly bound the behavior is with the platform as well as whether it provides a real benefit vs a simple "it works", I don't believe this is one that I want to be "generic" on. Hmmm OK, but this

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-20 Thread Johannes Thumshirn
On Tue, Feb 20, 2018 at 10:25:56AM -0800, James Smart wrote: > > Wouldn't it be better to improve the 32Bit writeq() code? > > Well, now that I'm asking for specific details internally, I'm finding that > no one can find the failing machine any more. > > I'm going to keep looking (and testing)

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-20 Thread James Smart
On 2/19/2018 12:14 AM, Johannes Thumshirn wrote: On Fri, Feb 16, 2018 at 08:53:44AM -0800, James Smart wrote: Any reason you can't use writeq() on 32 Bit as well? There's a compat version in linux/io-64-nonatomic-hi-lo.h. We actually ran into issues on the existence of writeq() on a 32bit

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-19 Thread Johannes Thumshirn
On Fri, Feb 16, 2018 at 08:53:44AM -0800, James Smart wrote: > > Any reason you can't use writeq() on 32 Bit as well? There's a compat > > version > > in linux/io-64-nonatomic-hi-lo.h. > > We actually ran into issues on the existence of writeq() on a 32bit > platform. Thus this code block. Oh

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-16 Thread James Smart
On 2/14/2018 1:30 AM, Johannes Thumshirn wrote: On Tue, Feb 13, 2018 at 11:34:48AM -0800, James Smart wrote: [...] diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 3bff1f9c5df7..5e03b2c969e5 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-14 Thread Johannes Thumshirn
On Tue, Feb 13, 2018 at 11:34:48AM -0800, James Smart wrote: [...] > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 3bff1f9c5df7..5e03b2c969e5 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -35,6 +35,9 @@ > #include >

[PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-13 Thread James Smart
New if_type=6 adapters support an additional BAR that provides apertures to allow direct WQE to adapter push support - termed Direct Packet Push (DPP). WQ creation differs slightly to ask for a WQ to be DPP-ized. When submitting a WQE to a DPP WQ, it is submitted to the host memory for the WQ