Hi Wendy,
Thanks for reviewing. Comments inline below.
-matt
On Aug 11, 2015, at 11:15 PM, wenxi...@linux.vnet.ibm.com wrote:
Quoting Matthew R. Ochs mro...@linux.vnet.ibm.com:
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs
Mikey,
Thanks for reviewing. Responses to your comments inline below.
-matt
On Aug 10, 2015, at 9:05 PM, Michael Neuling mi...@neuling.org wrote:
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Introduce support for enhanced I/O error handling.
This needs more description of
On Aug 10, 2015, at 10:41 PM, Benjamin Herrenschmidt
b...@kernel.crashing.org wrote:
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com
Signed-off-by: Manoj N. Kumar
Actually, I forgot one thing:
config CXLFLASH
tristate Support for IBM CAPI Flash
- depends on PCI SCSI CXL
+ depends on PCI SCSI CXL EEH
Should you depend on CXL_EEH here, seeing as you use CONFIG_CXL_EEH?
+#ifndef CONFIG_CXL_EEH
+#define
On Tue, 2015-08-11 at 16:21 +1000, Daniel Axtens wrote:
Actually, I forgot one thing:
config CXLFLASH
tristate Support for IBM CAPI Flash
- depends on PCI SCSI CXL
+ depends on PCI SCSI CXL EEH
Should you depend on CXL_EEH here, seeing as you use CONFIG_CXL_EEH?
On Aug 10, 2015, at 6:52 PM, Daniel Axtens d...@axtens.net wrote:
@@ -487,11 +515,27 @@ static int cxlflash_eh_host_reset_handler(struct
scsi_cmnd *scp)
get_unaligned_be32(((u32 *)scp-cmnd)[2]),
get_unaligned_be32(((u32 *)scp-cmnd)[3]));
-rcr =
Quoting Matthew R. Ochs mro...@linux.vnet.ibm.com:
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com
Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com
---
drivers/scsi/cxlflash/Kconfig | 2 +-
drivers/scsi/cxlflash/common.h |
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com
Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com
---
drivers/scsi/cxlflash/Kconfig | 2 +-
drivers/scsi/cxlflash/common.h | 11 ++-
drivers/scsi/cxlflash/main.c | 166
@@ -487,11 +515,27 @@ static int cxlflash_eh_host_reset_handler(struct
scsi_cmnd *scp)
get_unaligned_be32(((u32 *)scp-cmnd)[2]),
get_unaligned_be32(((u32 *)scp-cmnd)[3]));
- rcr = cxlflash_afu_reset(cfg);
- if (rcr == 0)
- rc = SUCCESS;
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com
Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com
---
So I'm not necessarily very qualified to review SCSI bits as I
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Introduce support for enhanced I/O error handling.
This needs more description of what you're doing. What's the overall
approach? There seems to be a new limbo queue thats created stall things
while the device is in error state. That
11 matches
Mail list logo