Re: [PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

2015-04-23 Thread h...@infradead.org
On Thu, Apr 23, 2015 at 07:50:41AM +0200, Hannes Reinecke wrote: Yes, that's okay with me. Personally I would be using mempools when you need lots of small, frequently changed allocations (like sg elements), and kzalloc() for large or infrequently changed bits of memory. The array lookup is

RE: [PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

2015-04-22 Thread brace
Lindley; brace Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path On 04/16/2015 03:48 PM, Don Brace wrote: From: Webb Scales web...@hp.com Increase the request size for ioaccel2 path. The error, if any, returned

Re: [PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

2015-04-22 Thread Hannes Reinecke
On 04/22/2015 09:12 PM, brace wrote: The last I read about mempools was from: Linux Device Drivers By Jonathan Corbet, Alessandro Rubini, Greg Kroah-Hartman https://lwn.net/images/pdf/LDD3/ch08.pdf If you are considering using a mempool in your driver, please keep one

Re: [PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Webb Scales web...@hp.com Increase the request size for ioaccel2 path. The error, if any, returned by hpsa_allocate_ioaccel2_sg_chain_blocks to hpsa_alloc_ioaccel2_cmd_and_bft should be returned upstream rather than assumed to be -ENOMEM.

[PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

2015-04-16 Thread Don Brace
From: Webb Scales web...@hp.com Increase the request size for ioaccel2 path. The error, if any, returned by hpsa_allocate_ioaccel2_sg_chain_blocks to hpsa_alloc_ioaccel2_cmd_and_bft should be returned upstream rather than assumed to be -ENOMEM. This differs slightly from