Comments inline.
I'm not keen on the numerous pr_err() in here. I think it'll make the driver
chatty especially with a badly behaving userspace.
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Add support for physical LUN segmentation (virtual LUNs) to device
driver supporting the
Mikey: Thanks for your review. Comments inline below.
On 8/11/2015 5:54 AM, Michael Neuling wrote:
I'm not keen on the numerous pr_err() in here. I think it'll make the driver
chatty especially with a badly behaving userspace.
Will look at all the pr_err() and limit them to errors that are
Be good to do some clear sanity check the struct dk_cxlflash_resize
*resize
here. It's passed from userspace but then gets propogated to a bunch of
other
things here like nsectors, get_context etc who will all now be responsible
for
handling any dodgy data passed in.
Same
Add support for physical LUN segmentation (virtual LUNs) to device
driver supporting the IBM CXL Flash adapter. This patch allows user
space applications to virtually segment a physical LUN into N virtual
LUNs, taking advantage of the translation features provided by this
adapter.
Signed-off-by:
4 matches
Mail list logo
