Re: [PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2018 at 06:16:44AM +, Avri Altman wrote: > In V6, we removed the host and device indices from the bsg device name, > But I have some seconds thoughts about it. > > We are using the bsg device in passthrough mode (bsg_transport_ops), > But the device name: "ufs-bsg" does not imp

RE: [PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-26 Thread Avri Altman
Bart/Christoph, > + */ > +int ufs_bsg_probe(struct ufs_hba *hba) > +{ > + struct device *bsg_dev = &hba->bsg_dev; > + struct Scsi_Host *shost = hba->host; > + struct device *parent = &shost->shost_gendev; > + struct request_queue *q; > + int ret; > + > + device_initialize(b

RE: [PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-26 Thread Avri Altman
> > Avri, > > > this looks generally good to me, but I'd suggest two small tweaks: > > > > - please split out a new prep patch that creates > >include/uapi/scsi/scsi_bsg_ufs.h with the structures move there > > - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this > >new file

RE: [PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-26 Thread Avri Altman
> Hi Avri, > > this looks generally good to me, but I'd suggest two small tweaks: > > - please split out a new prep patch that creates >include/uapi/scsi/scsi_bsg_ufs.h with the structures move there > - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this >new file Done. Th

Re: [PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-26 Thread Martin K. Petersen
Avri, > this looks generally good to me, but I'd suggest two small tweaks: > > - please split out a new prep patch that creates >include/uapi/scsi/scsi_bsg_ufs.h with the structures move there > - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this >new file Also, when you r

Re: [PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-26 Thread Christoph Hellwig
Hi Avri, this looks generally good to me, but I'd suggest two small tweaks: - please split out a new prep patch that creates include/uapi/scsi/scsi_bsg_ufs.h with the structures move there - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this new file

[PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-21 Thread Avri Altman
Add a bsg endpoint that supports UPIUs. For now, just provide an API to allocate and remove ufs-bsg node. We will use this framework to manage ufs devices by sending UPIU transactions. For the time being, implements an empty bsg_request() - will add some more functionality in coming patches. Non