Re: [PATCHv2 4/4] scsi_devinfo: fixup string compare

2017-08-09 Thread Hannes Reinecke
On 08/09/2017 07:43 PM, Alan Stern wrote: > On Wed, 9 Aug 2017, Hannes Reinecke wrote: > >> When checking the model and vendor string we need to use the >> minimum value of either string, otherwise we'll miss out on >> wildcard matches. > > This is now true only for the model string, not the vend

Re: [PATCHv2 4/4] scsi_devinfo: fixup string compare

2017-08-09 Thread Alan Stern
On Wed, 9 Aug 2017, Hannes Reinecke wrote: > When checking the model and vendor string we need to use the > minimum value of either string, otherwise we'll miss out on > wildcard matches. This is now true only for the model string, not the vendor string. And even for the model string, you allow

[PATCHv2 4/4] scsi_devinfo: fixup string compare

2017-08-09 Thread Hannes Reinecke
When checking the model and vendor string we need to use the minimum value of either string, otherwise we'll miss out on wildcard matches. And we should take card when matching with zero size strings; results might be unpredictable. With this patch the rules for matching devinfo strings are as foll