Re: [PATCH V2 16/18] be2iscsi: Fix possible reentrancy issue in be_iopoll

2013-05-02 Thread James Bottomley
On Fri, 2013-04-05 at 20:38 -0700, Jayamohan Kallickal wrote: > From: Shlomo Pongratz > > The driver creates "NAPI" context per core which is fine, > however the above routine declares the ret variable as static! > Thus there is only one instance of this variable! > When this routine is calle

[PATCH V2 16/18] be2iscsi: Fix possible reentrancy issue in be_iopoll

2013-04-05 Thread Jayamohan Kallickal
From: Shlomo Pongratz The driver creates "NAPI" context per core which is fine, however the above routine declares the ret variable as static! Thus there is only one instance of this variable! When this routine is called from more than one thread of execution, than the result is unpredictabl

RE: Possible reentrancy issue in be_iopoll

2013-03-19 Thread Kallickal, Jayamohan
@vger.kernel.org Cc: Kallickal, Jayamohan; micha...@cs.wisc.edu Subject: Possible reentrancy issue in be_iopoll Hi Jayamohan. I think that there is a reentrancy issue in "drivers/scsi/be2iscsi/be_main.c::be_iopoll". The driver creates "NAPI" context per core which is fine, howeve

Possible reentrancy issue in be_iopoll

2013-03-18 Thread Shlomo Pongratz
Hi Jayamohan. I think that there is a reentrancy issue in "drivers/scsi/be2iscsi/be_main.c::be_iopoll". The driver creates "NAPI" context per core which is fine, however the above routine declares the ret variable as static! Thus there is only one instance of this variable, so if this routine i