Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

2016-05-09 Thread Martin K. Petersen
> "Anil" == Anil Gurumurthy writes: Anil> Apologies for the delay. Patch looks good. Acked by: Anil Anil> Gurumurthy Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list:

RE: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

2016-05-06 Thread Anil Gurumurthy
lt;anil.gurumur...@qlogic.com>; Sudarsana Kalluru <sudarsana.kall...@qlogic.com>; James E.J. Bottomley <j...@linux.vnet.ibm.com>; Martin K. Petersen <martin.peter...@oracle.com>; linux-scsi <linux-scsi@vger.kernel.org>; kernel-janit...@vger.kernel.org Subject: Re: [PATCH rese

Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

2016-05-05 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> The caller assumes that "itnim" is NULL on error and non-NULL on Dan> success but really "itnim" is uninitialized on error. This Dan> function should just use normal error handling where it returns Dan> zero on success and