Re: return value warnings about scsi_add_host, anything in progre ss?

2005-02-08 Thread Alexander Stohr
Matthew Wilcox wrote: I think you misunderstood my point. megaraid does not produce a warning about a missing return check when I compile it with gcc-3.4. Does it warn for you? If not, why did you include it in the list? I grepped the whole source tree and discared the locations where in

RE: return value warnings about scsi_add_host, anything in progre ss?

2005-02-07 Thread Ju, Seokmann
On Monday, February 07, 2005 4:40 AM, Alex wrote: is anything going to happen with the below listed locations? (Some are part of the USB system, one is in block device, rest is SCSI.) Note that a few locations do still lack the XXX comment. I am asking because i am seeing ther respective

Re: return value warnings about scsi_add_host, anything in progre ss?

2005-02-07 Thread Matthew Wilcox
On Mon, Feb 07, 2005 at 08:47:36AM -0500, Ju, Seokmann wrote: On Monday, February 07, 2005 4:40 AM, Alex wrote: is anything going to happen with the below listed locations? (Some are part of the USB system, one is in block device, rest is SCSI.) Note that a few locations do still lack the

RE: return value warnings about scsi_add_host, anything in progre ss?

2005-02-07 Thread Ju, Seokmann
On Monday, February 07, 2005 11:29 AM, Matthew wrote: I don't get a warning from this line, using gcc 3.4.4 20041218 (prerelease) (Debian 3.4.3-7): drivers/scsi/megaraid.c: In function `megadev_ioctl': drivers/scsi/megaraid.c:3626: warning: ignoring return value of `copy_to_user', declared

Re: return value warnings about scsi_add_host, anything in progre ss?

2005-02-07 Thread Alexander Stohr
On Mon, Feb 07, 2005 at 04:10:22PM +, Matthew Wilcox wrote: I'm not sure why returning the result doesn't count as a use of the result (in the case of megaraid). From: Alexander Stohr [mailto:[EMAIL PROTECTED] ./drivers/scsi/megaraid.c:4890: error = scsi_add_host(host,