Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-18 Thread Quinn Tran
On 6/18/19, 8:57 AM, "Bart Van Assche" wrote: On 6/17/19 5:01 PM, Quinn Tran wrote: > Attached is the clean-up patch that we held back from the series. > We felt it wasn't ready for wider audience because it needed additional > soak time with our test group. > > We want to

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-18 Thread Bart Van Assche
On 6/17/19 5:01 PM, Quinn Tran wrote: Attached is the clean-up patch that we held back from the series. > We felt it wasn't ready for wider audience because it needed additional soak time with our test group. We want to ahead and share it with you to let you know that we intent to cleanup the d

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-17 Thread Quinn Tran
Bart, Attached is the clean-up patch that we held back from the series. We felt it wasn't ready for wider audience because it needed additional soak time with our test group. We want to ahead and share it with you to let you know that we intent to cleanup the duplicate atomic [ref_count|kref]

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-17 Thread Bart Van Assche
On 6/14/19 3:58 PM, Himanshu Madhani wrote: Yes. We are in process of doing the larger cleanup. However, this > patch was part of fixes we verified for a crash and want to get this in a distro before the wider cleanup is submitted for inclusion. Hi Himanshu, It's not that hard to fix this pro

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-14 Thread Bart Van Assche
On 6/14/19 3:58 PM, Himanshu Madhani wrote: Would you consider allowing us to add this patch and we'll provide larger patch fixing all code path in next series. Hi Himanshu, I think this is something Martin should decide. Thanks, Bart.

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-14 Thread Himanshu Madhani
Hi Bart, On 6/14/19, 3:24 PM, "Bart Van Assche" wrote: External Email -- On 6/14/19 3:10 PM, Himanshu Madhani wrote: > From: Quinn Tran > > This patch uses kref to protect access between fcp_abor