Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-14 Thread Tejun Heo
Hello, Todd. On Mon, Jan 13, 2014 at 03:30:26PM -0800, Todd E Brandt wrote: Ahh, sorry, yea I think async should work for the entire resume pathway. Would you be willing to accept this ata patch separately from the scsi one? It wouldn't provide any performance benefit on its own, but would

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Todd E Brandt
On Sat, Jan 11, 2014 at 02:13:15PM -0500, Tejun Heo wrote: Hello, On Tue, Jan 07, 2014 at 04:56:07PM -0800, Todd E Brandt wrote: On resume, the ATA port driver currently waits until the AHCI controller finishes executing the port wakeup command. This patch changes the Is there anything

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Todd E Brandt
On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote: On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi ps...@ubuntu.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/10/2014 06:11 PM, Brandt, Todd E wrote: Yes yours is simpler, but it also opens a potential memory

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Tejun Heo
Hello, On Mon, Jan 13, 2014 at 11:55:44AM -0800, Todd E Brandt wrote: I see your point, why have two paths if one will do. The only thing that worries me is that the PM resume from hibernate function doesn't have an error handler. What happens when it tries to read the image from swap and the

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Dan Williams
On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt todd.e.bra...@linux.intel.com wrote: On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote: On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi ps...@ubuntu.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/10/2014 06:11 PM,

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Todd E Brandt
On Mon, Jan 13, 2014 at 03:30:07PM -0500, Tejun Heo wrote: Hello, On Mon, Jan 13, 2014 at 11:55:44AM -0800, Todd E Brandt wrote: I see your point, why have two paths if one will do. The only thing that worries me is that the PM resume from hibernate function doesn't have an error

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Todd E Brandt
On Mon, Jan 13, 2014 at 12:37:01PM -0800, Dan Williams wrote: On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt todd.e.bra...@linux.intel.com wrote: On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote: On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi ps...@ubuntu.com wrote: -BEGIN

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Dan Williams
On Mon, Jan 13, 2014 at 3:51 PM, Todd E Brandt todd.e.bra...@linux.intel.com wrote: On Mon, Jan 13, 2014 at 12:37:01PM -0800, Dan Williams wrote: On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt Actually there's one other reason. In the ata_port_request_pm function it checks to see if there's

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-11 Thread Tejun Heo
Hello, On Tue, Jan 07, 2014 at 04:56:07PM -0800, Todd E Brandt wrote: On resume, the ATA port driver currently waits until the AHCI controller finishes executing the port wakeup command. This patch changes the Is there anything ahci specific about this? There shouldn't be. This patch only

RE: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-10 Thread Brandt, Todd E
On Thursday, January 09, 2014 9:04 AM, Phillip Susi wrote: I think my patch for this libata: resume in the background was a LOT simpler. It just used the existing behavior of becoming async when the async argument was !NULL, and fixed the one caller that didn't actually care about the result

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-10 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/10/2014 06:11 PM, Brandt, Todd E wrote: Yes yours is simpler, but it also opens a potential memory issue by passing a static int as the return location for the error value. I think it's just safer to tell the callback to attempt no return

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-09 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/7/2014 7:56 PM, Todd E Brandt wrote: On resume, the ATA port driver currently waits until the AHCI controller finishes executing the port wakeup command. This patch changes the ata_port_resume callback to issue the wakeup and then return