Re: [PATCH 0/5] sg_ring for scsi

2007-12-27 Thread Rusty Russell
On Thursday 27 December 2007 13:09:27 FUJITA Tomonori wrote: On Wed, 26 Dec 2007 11:27:40 +1100 Rusty Russell [EMAIL PROTECTED] wrote: There are many signs through the code that it needs a great deal of work: what is the purpose of sg_break? Why does the code check if kmap_atomic fails?

Re: [PATCH 0/5] sg_ring for scsi

2007-12-26 Thread FUJITA Tomonori
On Wed, 26 Dec 2007 11:27:40 +1100 Rusty Russell [EMAIL PROTECTED] wrote: On Friday 21 December 2007 15:37:46 FUJITA Tomonori wrote: Some scsi drivers like ips access to sglist in a tricky way. Indeed. I fail to see how this code works, in fact: drivers/scsi/ips.c:ips_queue() line 1101

Re: [PATCH 0/5] sg_ring for scsi

2007-12-25 Thread Rusty Russell
On Friday 21 December 2007 15:37:46 FUJITA Tomonori wrote: Some scsi drivers like ips access to sglist in a tricky way. Indeed. I fail to see how this code works, in fact: drivers/scsi/ips.c:ips_queue() line 1101 if (ips_is_passthru(SC)) { ips_copp_wait_item_t

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Jens Axboe
On Thu, Dec 20 2007, Rusty Russell wrote: On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote: On Thu, 20 Dec 2007 16:45:18 +1100 Rusty Russell [EMAIL PROTECTED] wrote: OK, some fixes since last time, as I wade through more SCSI drivers. Some drivers use use_sg as a flag to

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Boaz Harrosh
On Thu, Dec 20 2007 at 9:58 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Thu, Dec 20 2007, Rusty Russell wrote: On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote: On Thu, 20 Dec 2007 16:45:18 +1100 Rusty Russell [EMAIL PROTECTED] wrote: OK, some fixes since last time, as I wade

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Rusty Russell
On Thursday 20 December 2007 18:58:07 David Miller wrote: From: Rusty Russell [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 18:53:48 +1100 Manipulating the magic chains is horrible; it looks simple to the places which simply want to iterate through it, but it's awful for code which wants to

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Rusty Russell
On Friday 21 December 2007 13:28:34 FUJITA Tomonori wrote: I'm not sure about chaining the headers (as your sg_ring and scsi_sgtable do) would simplify LLDs. Have you looked at ips or qla1280? Not yet, am working my way through the drivers, but I don't expect it will be a simplification to

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread FUJITA Tomonori
On Fri, 21 Dec 2007 14:26:47 +1100 Rusty Russell [EMAIL PROTECTED] wrote: On Friday 21 December 2007 13:28:34 FUJITA Tomonori wrote: I'm not sure about chaining the headers (as your sg_ring and scsi_sgtable do) would simplify LLDs. Have you looked at ips or qla1280? Not yet, am working

Re: [PATCH 0/5] sg_ring for scsi

2007-12-19 Thread FUJITA Tomonori
On Thu, 20 Dec 2007 16:45:18 +1100 Rusty Russell [EMAIL PROTECTED] wrote: OK, some fixes since last time, as I wade through more SCSI drivers. Some drivers use use_sg as a flag to know whether the request_buffer is a scatterlist: I don't need the counter, but I still need the flag, so I