Re: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-21 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Make sure we only have the logic for requeing commands in one Christoph> place. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi

Re: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-09 Thread Hannes Reinecke
On 06/25/2014 06:51 PM, Christoph Hellwig wrote: Make sure we only have the logic for requeing commands in one place. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi.c | 35 --- drivers/scsi/scsi_lib.c |9 ++--- 2 files changed, 18 insert

Re: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-08 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 08:51:30PM +, Elliott, Robert (Server Storage) wrote: > In scsi_lib.c, both scsi_done() and scsi_mq_done() always call > trace_scsi_dispatch_cmd_done(), so trace_scsi_dispatch_cmd_start() > should be called before scsi_done() is called. That way the > trace will always

RE: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Wednesday, 25 June, 2014 11:52 AM > To: James Bottomley > Cc: Jens Axboe; Bart Van Assche; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATCH 03/14] scs