Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-13 Thread Sagi Grimberg
Back to the original question, I don't think Sagi was asking if it was valid to do a legacy/unprotected READ, it was what to expect with a protected READ on unwritten blocks: So this takes me to a corner I still don't understand, if a LUN is pre-formatted as T10-protected, what happens to

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 10:46 PM, Martin K. Petersen wrote: Andy == Andy Grover agro...@redhat.com writes: Andy Yes, don't you need FORMAT UNIT because protection information is Andy going to mean the pi-enabled lun will need to report less blocks? Modern disk drives won't shrink when you reformat them

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 10:39 PM, Martin K. Petersen wrote: Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi What about FORMAT_UNIT emulation? The backstore protection Sagi configuration is done at the target side via configfs/targetcli, I don't know of any non-disk devices that actually implement

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 10:39 PM, Martin K. Petersen wrote: Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi What about FORMAT_UNIT emulation? The backstore protection Sagi configuration is done at the target side via configfs/targetcli, I don't know of any non-disk devices that actually implement

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: I don't know of any non-disk devices that actually implement FORMAT UNIT. Usually such configuration is done using the array management interface. Sagi So this takes me to a corner I still don't understand, if a LUN is Sagi pre-formatted

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Sagi Grimberg
On 1/12/2014 2:33 PM, Martin K. Petersen wrote: Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: I don't know of any non-disk devices that actually implement FORMAT UNIT. Usually such configuration is done using the array management interface. Sagi So this takes me to a corner I still

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Martin K. Petersen
Doug == Douglas Gilbert dgilb...@interlog.com writes: So this takes me to a corner I still don't understand, if a LUN is pre-formatted as T10-protected, what happens to unwritten blocks read? I mean, SCSI login executes some reads from sevel LBAs which will probably fail as blocks are

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Douglas Gilbert
On 14-01-12 12:21 PM, Martin K. Petersen wrote: Doug == Douglas Gilbert dgilb...@interlog.com writes: So this takes me to a corner I still don't understand, if a LUN is pre-formatted as T10-protected, what happens to unwritten blocks read? I mean, SCSI login executes some reads from sevel

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Andy Grover
On 01/09/2014 10:21 PM, Nicholas A. Bellinger wrote: What about FORMAT_UNIT emulation? Would certainly be useful to have.. The backstore protection configuration is done at the target side via configfs/targetcli, if you publish DIF support in INQUERY_EVPD/READ_CAPACITY you need to accept

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Nicholas A. Bellinger
On Fri, 2014-01-10 at 11:50 -0800, Andy Grover wrote: On 01/09/2014 10:21 PM, Nicholas A. Bellinger wrote: What about FORMAT_UNIT emulation? Would certainly be useful to have.. The backstore protection configuration is done at the target side via configfs/targetcli, if you publish DIF

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates sbc_emulate_readcapacity_16() to set P_TYPE and nab PROT_EN bits when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi What about FORMAT_UNIT emulation? The backstore protection Sagi configuration is done at the target side via configfs/targetcli, I don't know of any non-disk devices that actually implement FORMAT UNIT. Usually such configuration is done

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@linux-iscsi.org writes: The backstore protection configuration is done at the target side via configfs/targetcli, if you publish DIF support in INQUERY_EVPD/READ_CAPACITY you need to accept protection information format? nab Mmmm, these two bits bits are

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
Andy == Andy Grover agro...@redhat.com writes: Andy Yes, don't you need FORMAT UNIT because protection information is Andy going to mean the pi-enabled lun will need to report less blocks? Modern disk drives won't shrink when you reformat them with PI. This is a result of an IDEMA agreement

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-09 Thread Sagi Grimberg
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates sbc_emulate_readcapacity_16() to set P_TYPE and PROT_EN bits when DIF emulation is enabled by the backend device. Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-09 Thread Nicholas A. Bellinger
On Thu, 2014-01-09 at 12:24 +0200, Sagi Grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates sbc_emulate_readcapacity_16() to set P_TYPE and PROT_EN bits when DIF emulation is enabled by the backend device.