Re: [PATCH 1/3] block: Return error in rescan_partitions if revalidating disk failed

2015-04-21 Thread James Bottomley
On Tue, 2015-03-24 at 18:16 +0800, Fam Zheng wrote: If the disk can't read capacity, we should return an error. I'm not sure I buy this: you need to justify why. For instance removable media return an error in revalidate that causes the medium not present flag to be set ... do we really want to

Re: [PATCH 1/3] block: Return error in rescan_partitions if revalidating disk failed

2015-04-21 Thread Fam Zheng
On Tue, 04/21 19:58, James Bottomley wrote: On Tue, 2015-03-24 at 18:16 +0800, Fam Zheng wrote: If the disk can't read capacity, we should return an error. I'm not sure I buy this: you need to justify why. For instance removable media return an error in revalidate that causes the medium