On Thu, Sep 27, 2018 at 06:16:44AM +, Avri Altman wrote:
> In V6, we removed the host and device indices from the bsg device name,
> But I have some seconds thoughts about it.
>
> We are using the bsg device in passthrough mode (bsg_transport_ops),
> But the device name: "ufs-bsg" does not
Bart/Christoph,
> + */
> +int ufs_bsg_probe(struct ufs_hba *hba)
> +{
> + struct device *bsg_dev = >bsg_dev;
> + struct Scsi_Host *shost = hba->host;
> + struct device *parent = >shost_gendev;
> + struct request_queue *q;
> + int ret;
> +
> + device_initialize(bsg_dev);
>
>
> Avri,
>
> > this looks generally good to me, but I'd suggest two small tweaks:
> >
> > - please split out a new prep patch that creates
> >include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> > - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
> >new file
> Hi Avri,
>
> this looks generally good to me, but I'd suggest two small tweaks:
>
> - please split out a new prep patch that creates
>include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
>new file
Done.
Avri,
> this looks generally good to me, but I'd suggest two small tweaks:
>
> - please split out a new prep patch that creates
>include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
>new file
Also, when you
Hi Avri,
this looks generally good to me, but I'd suggest two small tweaks:
- please split out a new prep patch that creates
include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
- pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
new file
6 matches
Mail list logo
