Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

Hi Arun, On Wed, Oct 19, 2016 at 05:14:59PM -0700, Arun Easi wrote: > Thanks Johannes for the review, please see my response below. > [...] > > > > Why not introduce a small helper like: > > static inline bool qed_is_iscsi_personality() > > { > > return IS_ENABLED(CONFIG_QEDI) &&

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

Thanks Johannes for the review, please see my response below. On Wed, 19 Oct 2016, 2:09am, Johannes Thumshirn wrote: > Hi Manish, > > Some initital comments > > On Wed, Oct 19, 2016 at 01:01:08AM -0400, manish.rangan...@cavium.com wrote: > > From: Yuval Mintz > > > >

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

Thanks Hannes for the review. Please see my comments inline.. On Wed, 19 Oct 2016, 12:31am, Hannes Reinecke wrote: > On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > > From: Yuval Mintz > > > > This adds the backbone required for the various HW

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This adds the backbone required for the various HW initalizations > which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ > 4 line of adapters - FW notification, resource

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

Hi Manish, Some initital comments On Wed, Oct 19, 2016 at 01:01:08AM -0400, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This adds the backbone required for the various HW initalizations > which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ