Re: SCSI regression in 4.11

2017-03-03 Thread Stephen Hemminger
On Thu, 02 Mar 2017 11:18:23 -0800 James Bottomley wrote: > On March 2, 2017 11:05:05 AM PST, Stephen Hemminger > wrote: > >On Thu, 02 Mar 2017 10:36:17 -0800 > >James Bottomley wrote: > > > >> On March 2, 2017 10:23:24 AM PST, Stephen Hemminger > > wrote: > >> >On Thu, 2 Mar 2017 14:25:

Re: SCSI regression in 4.11

2017-03-02 Thread James Bottomley
On March 2, 2017 10:23:24 AM PST, Stephen Hemminger wrote: >On Thu, 2 Mar 2017 14:25:14 +0100 >Hannes Reinecke wrote: > >> On 03/02/2017 02:40 AM, Stephen Hemminger wrote: >> > On Thu, 2 Mar 2017 01:56:15 +0100 >> > Christoph Hellwig wrote: >> > >> >> On Thu, Mar 02, 2017 at 01:01:35AM +0100,

Re: SCSI regression in 4.11

2017-03-02 Thread James Bottomley
On March 2, 2017 11:05:05 AM PST, Stephen Hemminger wrote: >On Thu, 02 Mar 2017 10:36:17 -0800 >James Bottomley wrote: > >> On March 2, 2017 10:23:24 AM PST, Stephen Hemminger > wrote: >> >On Thu, 2 Mar 2017 14:25:14 +0100 >> >Hannes Reinecke wrote: >> > >> >> On 03/02/2017 02:40 AM, Stephen

Re: SCSI regression in 4.11

2017-03-02 Thread Stephen Hemminger
On Thu, 02 Mar 2017 10:36:17 -0800 James Bottomley wrote: > On March 2, 2017 10:23:24 AM PST, Stephen Hemminger > wrote: > >On Thu, 2 Mar 2017 14:25:14 +0100 > >Hannes Reinecke wrote: > > > >> On 03/02/2017 02:40 AM, Stephen Hemminger wrote: > >> > On Thu, 2 Mar 2017 01:56:15 +0100 > >> >

Re: SCSI regression in 4.11

2017-03-02 Thread Stephen Hemminger
On Thu, 2 Mar 2017 14:25:14 +0100 Hannes Reinecke wrote: > On 03/02/2017 02:40 AM, Stephen Hemminger wrote: > > On Thu, 2 Mar 2017 01:56:15 +0100 > > Christoph Hellwig wrote: > > > >> On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: > >>> On Wed, Mar 01, 2017 at 07:54:12AM

Re: SCSI regression in 4.11

2017-03-02 Thread Stephen Hemminger
On Thu, 2 Mar 2017 14:25:14 +0100 Hannes Reinecke wrote: > On 03/02/2017 02:40 AM, Stephen Hemminger wrote: > > On Thu, 2 Mar 2017 01:56:15 +0100 > > Christoph Hellwig wrote: > > > >> On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: > >>> On Wed, Mar 01, 2017 at 07:54:12AM

Re: SCSI regression in 4.11

2017-03-02 Thread Hannes Reinecke
On 03/02/2017 02:40 AM, Stephen Hemminger wrote: On Thu, 2 Mar 2017 01:56:15 +0100 Christoph Hellwig wrote: On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote: http://git.infradead.org/users/hch/block.

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
On Thu, 2 Mar 2017 01:56:15 +0100 Christoph Hellwig wrote: > On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: > > On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote: > > > > > > > > http://git.infradead.org/users/hch/block.git/commitdiff/148cff67b401e22

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
On Thu, 2 Mar 2017 01:01:35 +0100 Christoph Hellwig wrote: > On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote: > > > > > > http://git.infradead.org/users/hch/block.git/commitdiff/148cff67b401e2229c076c0ea418712654be77e4 > > > > > > > It appears that is already in the code

Re: SCSI regression in 4.11

2017-03-01 Thread Christoph Hellwig
On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: > On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote: > > > > > > http://git.infradead.org/users/hch/block.git/commitdiff/148cff67b401e2229c076c0ea418712654be77e4 > > > > It appears that is already in the code I a

Re: SCSI regression in 4.11

2017-03-01 Thread James Bottomley
On Wed, 2017-03-01 at 10:57 -0800, James Bottomley wrote: > On Wed, 2017-03-01 at 10:48 -0800, Stephen Hemminger wrote: > > On Tue, 28 Feb 2017 22:20:58 -0800 > > James Bottomley wrote: > > > > > On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote: > > > > [1.346023] hv_storvsc: IO cm

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
On Wed, 01 Mar 2017 15:09:44 -0800 James Bottomley wrote: > On Wed, 2017-03-01 at 13:27 -0800, Stephen Hemminger wrote: > > Ok here is much better data, wasn't accounting for the offset in the > > payload > > But now both responses are the same: > > > Working 4.10 > [...] > > [1.048920]

Re: SCSI regression in 4.11

2017-03-01 Thread James Bottomley
On Wed, 2017-03-01 at 13:27 -0800, Stephen Hemminger wrote: > Ok here is much better data, wasn't accounting for the offset in the > payload But now both responses are the same: > Working 4.10 [...] > [1.048920] hv_storvsc: INQUIRY cmd 0x12 0x0 0x0 scsi status 0x0 > srb status 0x20 length 36

Re: SCSI regression in 4.11

2017-03-01 Thread Christoph Hellwig
On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote: > > > > http://git.infradead.org/users/hch/block.git/commitdiff/148cff67b401e2229c076c0ea418712654be77e4 > > It appears that is already in the code I am testing in linux-next... It's in -next now, but it wasn't at the time yo

Re: SCSI regression in 4.11

2017-03-01 Thread Linus Torvalds
On Wed, Mar 1, 2017 at 10:48 AM, Stephen Hemminger wrote: > > Bad 4.11 initial INQUIRY buffer > [1.218159] data: : 00 00 05 02 1f 00 00 02 4d 73 66 74 20 20 20 20 > [1.225654] data: 0010: 56 69 72 74 75 61 6c 20 44 69 73 6b 20 20 20 20 > [1.242930] data: 0020: 31 2e 30

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
Ok here is much better data, wasn't accounting for the offset in the payload Working 4.10 [1.020041] scsi host0: storvsc_host_t [1.024998] hv_storvsc: INQUIRY cmd 0x12 0x0 0x0 scsi status 0x0 srb status 0x1 length 36 [1.027452] hv_storvsc: payload size 288 count 1 offset 3072 len 36

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
On Wed, 01 Mar 2017 11:20:22 -0800 James Bottomley wrote: > On Wed, 2017-03-01 at 10:57 -0800, James Bottomley wrote: > > On Wed, 2017-03-01 at 10:48 -0800, Stephen Hemminger wrote: > > > On Tue, 28 Feb 2017 22:20:58 -0800 > > > James Bottomley wrote: > > > > > > > On Tue, 2017-02-28 at 17:

Re: SCSI regression in 4.11

2017-03-01 Thread James Bottomley
On Wed, 2017-03-01 at 10:48 -0800, Stephen Hemminger wrote: > On Tue, 28 Feb 2017 22:20:58 -0800 > James Bottomley wrote: > > > On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote: > > > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 > > > srb > > > status 0x20 length 36 >

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
On Tue, 28 Feb 2017 22:20:58 -0800 James Bottomley wrote: > On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote: > > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb > > status 0x20 length 36 > > [1.352913] inquiry data: : 00 aa be f1 5c 98 ff ff f0 64 > > 02

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
Dexuan has reproduced the same problem and discovered that is related to whether virtual DVD is attached to the VM. My VM had empty virtual DVD (offline) from the installation of the ISO. If the DVD device is removed then the VM boots. This makes the problem less of a catastrophic but we still

Re: SCSI regression in 4.11

2017-03-01 Thread Christoph Hellwig
On Tue, Feb 28, 2017 at 10:48:45PM -0800, Stephen Hemminger wrote: > Let me know, I can run another test and dump more data. Could it be that we keep the old sense buffer values around because my commit change the way how sense buffers are handled. A while ago I suggested this patch to fix it, so

Re: SCSI regression in 4.11

2017-03-01 Thread Stephen Hemminger
On Wed, 1 Mar 2017 16:50:57 +0100 Christoph Hellwig wrote: > On Tue, Feb 28, 2017 at 10:48:45PM -0800, Stephen Hemminger wrote: > > Let me know, I can run another test and dump more data. > > Could it be that we keep the old sense buffer values around because > my commit change the way how sen

Re: SCSI regression in 4.11

2017-02-28 Thread Stephen Hemminger
On Tue, 28 Feb 2017 22:20:58 -0800 James Bottomley wrote: > On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote: > > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb > > status 0x20 length 36 > > [1.352913] inquiry data: : 00 aa be f1 5c 98 ff ff f0 64 > > 02

Re: SCSI regression in 4.11

2017-02-28 Thread James Bottomley
On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote: > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb > status 0x20 length 36 > [1.352913] inquiry data: : 00 aa be f1 5c 98 ff ff f0 64 > 02 89 ff ff ff ff > [1.356543] inquiry data: 0010: 00 00 00 00 0

Re: SCSI regression in 4.11

2017-02-28 Thread James Bottomley
On Tue, 2017-02-28 at 10:41 -0800, Stephen Hemminger wrote: > [1.652279] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb > status 0x20 length 36 > [1.652297] scsi host1: scsi scan: INQUIRY result too short (5), > using 36 This is definitive. We sent the Inquiry command, we got 36 byt

Re: SCSI regression in 4.11

2017-02-28 Thread James Bottomley
On Tue, 2017-02-28 at 10:57 -0800, Stephen Hemminger wrote: > On Tue, 28 Feb 2017 09:06:13 -0800 > James Bottomley wrote: > > > On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > > > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen H

Re: SCSI regression in 4.11

2017-02-28 Thread Stephen Hemminger
> Let's concentrate on INQUIRY since that's the first command in the > probe sequence. I think it's completing successfully because your > hyperv layer says it has 36 bytes of transfer and that's the size of a > successful initial INQUIRY, so the fact that the code above would break > stuff if th

Re: SCSI regression in 4.11

2017-02-28 Thread Stephen Hemminger
On Tue, 28 Feb 2017 09:06:13 -0800 James Bottomley wrote: > On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: > > > > Fixes: ee5242360424 ("scsi: zero per-cmd drive

Re: SCSI regression in 4.11

2017-02-28 Thread Stephen Hemminger
On Tue, 28 Feb 2017 09:06:13 -0800 James Bottomley wrote: > On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: > > > > Fixes: ee5242360424 ("scsi: zero per-cmd drive

Re: SCSI regression in 4.11

2017-02-28 Thread Stephen Hemminger
On Tue, 28 Feb 2017 09:06:13 -0800 James Bottomley wrote: > On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: > > > > Fixes: ee5242360424 ("scsi: zero per-cmd drive

Re: SCSI regression in 4.11

2017-02-28 Thread Jens Axboe
On 02/28/2017 10:16 AM, Stephen Hemminger wrote: > On Tue, 28 Feb 2017 09:06:13 -0800 > James Bottomley wrote: > >> On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: >>> On 02/28/2017 07:08 AM, Christoph Hellwig wrote: On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote:

Re: SCSI regression in 4.11

2017-02-28 Thread Stephen Hemminger
On Tue, 28 Feb 2017 15:08:12 +0100 Christoph Hellwig wrote: > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: > > Fixes: ee5242360424 ("scsi: zero per-cmd driver data before each I/O") > > > > but that is already in linux-next. > > > > Noticed another place where memset(of th

Re: SCSI regression in 4.11

2017-02-28 Thread James Bottomley
On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: > > > Fixes: ee5242360424 ("scsi: zero per-cmd driver data before each > > > I/O") > > > > > > but that is already in linux

Re: SCSI regression in 4.11

2017-02-28 Thread Jens Axboe
On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: >> Fixes: ee5242360424 ("scsi: zero per-cmd driver data before each I/O") >> >> but that is already in linux-next. >> >> Noticed another place where memset(of the data was being don

Re: SCSI regression in 4.11

2017-02-28 Thread Christoph Hellwig
On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: > Fixes: ee5242360424 ("scsi: zero per-cmd driver data before each I/O") > > but that is already in linux-next. > > Noticed another place where memset(of the data was being done not the extra > bits. > Tried this, but didn't fix

Re: SCSI regression in 4.11

2017-02-27 Thread Jens Axboe
On 02/27/2017 06:19 PM, Stephen Hemminger wrote: > On Mon, 27 Feb 2017 15:30:30 -0800 > Stephen Hemminger wrote: > >> Something in SCSI in 4.11 broke booting on Hyper-V Generation 2 VM with 8 >> VCPU and 4G of memory. >> Both Linus's current tree (4.11 pre-rc1) and linux-next fail in a similar

Re: SCSI regression in 4.11

2017-02-27 Thread Stephen Hemminger
On Mon, 27 Feb 2017 15:30:30 -0800 Stephen Hemminger wrote: > Something in SCSI in 4.11 broke booting on Hyper-V Generation 2 VM with 8 > VCPU and 4G of memory. > Both Linus's current tree (4.11 pre-rc1) and linux-next fail in a similar > manner. It looks like some error > in SCSI device detect