Re: scsi: BUG in scsi_init_io

2017-02-19 Thread Linus Torvalds
On Sat, Feb 18, 2017 at 11:15 PM, Al Viro wrote: > > AFAICS, the minimal fix would be something like this: Applied, along with getting rid of the BUG_ON() that made this bug much worse than it would have been without it. Linus

Re: scsi: BUG in scsi_init_io

2017-02-19 Thread Linus Torvalds
On Tue, Jan 31, 2017 at 7:41 AM, James Bottomley wrote: > > It is a kernel bug and it should not be user triggerable, so it should > have a warn_on or bug_on. Hell NO. Christ, James, listen to yourself. What you are basically saying when you say it should be a BUG_ON() is "This shouldn't happe

Re: scsi: BUG in scsi_init_io

2017-02-19 Thread Christoph Hellwig
On Sun, Feb 19, 2017 at 07:15:27AM +, Al Viro wrote: > The root cause is unfixable without access to TARDIS and dose of > antipsychotics sufficient to prevent /dev/sg API creation. > > What happens is that write to /dev/sg is given a request with non-zero > ->iovec_count combined with zero ->d

Re: scsi: BUG in scsi_init_io

2017-02-18 Thread Al Viro
On Tue, Jan 31, 2017 at 07:41:51AM -0800, James Bottomley wrote: > > Please-please-please, let's not use WARN for something that is not a > > kernel bug and is user-triggerable. > > It is a kernel bug and it should not be user triggerable, so it should > have a warn_on or bug_on. It means someth

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread James Bottomley
On Tue, 2017-01-31 at 10:50 +0100, Dmitry Vyukov wrote: > On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn < > jthumsh...@suse.de> wrote: > > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: > > > Hello, > > > > > > The following program triggers BUG in scsi_init_io: > > > > Wel

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Dmitry Vyukov
On Tue, Jan 31, 2017 at 10:58 AM, Johannes Thumshirn wrote: > > [...] > >> Please-please-please, let's not use WARN for something that is not a >> kernel bug and is user-triggerable. This makes it impossible to >> automate kernel testing and requires hiring an army of people doing >> mechanical jo

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Johannes Thumshirn
On Tue, Jan 31, 2017 at 10:50:49AM +0100, Dmitry Vyukov wrote: > On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn > wrote: > > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: [...] > Please-please-please, let's not use WARN for something that is not a > kernel bug and is user

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Dmitry Vyukov
On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn wrote: > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: >> Hello, >> >> The following program triggers BUG in scsi_init_io: > > Well crashing a machine just because of an empty dma transfer is a bit harsh, > isn't it? > > From 86

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Johannes Thumshirn
On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers BUG in scsi_init_io: Well crashing a machine just because of an empty dma transfer is a bit harsh, isn't it? >From 86e6fa5f618fe588b98e923e032f33e075fcd4f4 Mon Sep 17 00:00:00 2001 From: Jo

scsi: BUG in scsi_init_io

2017-01-31 Thread Dmitry Vyukov
Hello, The following program triggers BUG in scsi_init_io: kernel BUG at drivers/scsi/scsi_lib.c:1043! invalid opcode: [#1] SMP KASAN Modules linked in: CPU: 0 PID: 2899 Comm: a.out Not tainted 4.10.0-rc5+ #201 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 task