Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Bart Van Assche
On Feb 5, 2008 6:50 PM, Jeff Garzik [EMAIL PROTECTED] wrote: For remotely accessing data, iSCSI+fs is quite simply more overhead than a networked fs. With iSCSI you are doing local VFS - local blkdev - network whereas a networked filesystem is local VFS - network There

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Bart Van Assche
On Feb 5, 2008 6:01 PM, Erez Zilber [EMAIL PROTECTED] wrote: Using such large values for FirstBurstLength will give you poor performance numbers for WRITE commands (with iSER). FirstBurstLength means how much data should you send as unsolicited data (i.e. without RDMA). It means that your

ABORT_TASK defined in aic94xx_sas.h

2008-02-06 Thread Boaz Harrosh
include/scsi/scsi.h as a definition: #define ABORT_TASK 0x0d on the other hand drivers/scsi/aic94xx/aic94xx_sas.h has: #define ABORT_TASK 0x03 am I right in thinking that aic94xx_sas.h is wrong in polluting the global name-space? If you ask me aic94xx_sas.h is a global

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Jeff Garzik
Bart Van Assche wrote: On Feb 5, 2008 6:50 PM, Jeff Garzik [EMAIL PROTECTED] wrote: For remotely accessing data, iSCSI+fs is quite simply more overhead than a networked fs. With iSCSI you are doing local VFS - local blkdev - network whereas a networked filesystem is local

Re: diskdump fails on x3850 (x86_64)

2008-02-06 Thread Chandru
We looked at the code and there seem to be atleast two functions that may be required in the driver to support diskdump, dump_poll and dump_sanity_check as part of Scsi_Host_Template structure. Different drivers have their own way of implementing these routines in the driver code. Hence we

Re: ABORT_TASK defined in aic94xx_sas.h

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 15:38 +0200, Boaz Harrosh wrote: include/scsi/scsi.h as a definition: #define ABORT_TASK 0x0d on the other hand drivers/scsi/aic94xx/aic94xx_sas.h has: #define ABORT_TASK 0x03 am I right in thinking that aic94xx_sas.h is wrong in polluting the

Re: diskdump fails on x3850 (x86_64)

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 19:56 +0530, Chandru wrote: We looked at the code and there seem to be atleast two functions that may be required in the driver to support diskdump, dump_poll and dump_sanity_check as part of Scsi_Host_Template structure. Different drivers have their own way of

Re: ABORT_TASK defined in aic94xx_sas.h

2008-02-06 Thread Boaz Harrosh
On Wed, Feb 06 2008 at 17:13 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-02-06 at 15:38 +0200, Boaz Harrosh wrote: include/scsi/scsi.h as a definition: #define ABORT_TASK 0x0d on the other hand drivers/scsi/aic94xx/aic94xx_sas.h has: #define ABORT_TASK

Re: ABORT_TASK defined in aic94xx_sas.h

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 17:34 +0200, Boaz Harrosh wrote: On Wed, Feb 06 2008 at 17:13 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-02-06 at 15:38 +0200, Boaz Harrosh wrote: include/scsi/scsi.h as a definition: #define ABORT_TASK 0x0d on the other hand

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Benny Halevy
On Feb. 06, 2008, 14:16 +0200, Bart Van Assche [EMAIL PROTECTED] wrote: On Feb 5, 2008 6:01 PM, Erez Zilber [EMAIL PROTECTED] wrote: Using such large values for FirstBurstLength will give you poor performance numbers for WRITE commands (with iSER). FirstBurstLength means how much data should

[PATCH 1/1] aacraid: pci_set_dma_max_seg_size opened up for late model controllers

2008-02-06 Thread Salyzyn, Mark
This patch depends on 'RE: [patch 048/265] iommu sg merging: aacraid: use pci_set_dma_max_seg_size' and ensures that the modern adapters get a maximum sg segment size on par with the maximum transfer size. Added some localized janitor fixes to the discussion patch I used with Fujita. FUJITA

Re: [PATCH 1/24][RFC] scsi_eh: Define new API for sense handling

2008-02-06 Thread James Bottomley
On Tue, 2008-02-05 at 17:43 +0200, Boaz Harrosh wrote: On Mon, Feb 04 2008 at 19:33 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2008-02-04 at 17:30 +0200, Boaz Harrosh wrote: This patch defines a new API for sense handling. All drivers will be converted to this API, before the

Re: [PATCH] sr: update to follow tray status correctly

2008-02-06 Thread Daniel Drake
Hi James, James Bottomley wrote: It's been a while with no status on this one, so I corrected the patch based on my original input. The attached is what I think is the best way of doing this (I've replaced the home grown test_unit_ready routine with the SCSI one and updated some of the sense

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'

2008-02-06 Thread James Bottomley
On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote: It should be like this I guess? this patch was not yet tested, please confirm. -- Note the duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE' from Documentation/DMA-API.txt: DMA_TO_DEVICE = PCI_DMA_TODEVICE data is

Re: [PATCH 1/1] aacraid: pci_set_dma_max_seg_size opened up for late model controllers

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 09:00 -0800, Salyzyn, Mark wrote: This patch depends on 'RE: [patch 048/265] iommu sg merging: aacraid: use pci_set_dma_max_seg_size' and ensures that the modern adapters get a maximum sg segment size on par with the maximum transfer size. Added some localized janitor

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Vladislav Bolkhovitin
James Bottomley wrote: On Tue, 2008-02-05 at 21:59 +0300, Vladislav Bolkhovitin wrote: Hmm, how can one write to an mmaped page and don't touch it? I meant from user space ... the writes are done inside the kernel. Sure, the mmap() approach agreed to be unpractical, but could you

[PATCH 1/1] aacraid: pci_set_dma_max_seg_size opened up for late model controllers (take 2)

2008-02-06 Thread Salyzyn, Mark
Merde, excuse my english. No idea how those spaces snuck in, a last minute vi fumble finger?! Updated patch enclosed. My apologies for the gaff! Signed-off-by: Mark Salyzyn [EMAIL PROTECTED] drivers/scsi/aacraid/linit.c | 42 -- 1 file changed, 20

Re: [Bugme-new] [Bug 9901] New: kernel panic in stex modules (?)

2008-02-06 Thread Andrew Morton
On Wed, 6 Feb 2008 09:40:15 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9901 Summary: kernel panic in stex modules (?) Product: IO/Storage Version: 2.5 KernelVersion: 2.6.24 Platform: All

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'

2008-02-06 Thread Roel Kluin
James Bottomley wrote: On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote: Note the duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE' - if (SCpnt-sc_data_direction == DMA_FROM_DEVICE) { + if (SCpnt-sc_data_direction == DMA_TO_DEVICE) { cpp-xdir = DTD_IN;

Re: [Bugme-new] [Bug 9901] New: kernel panic in stex modules (?)

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 10:15 -0800, Andrew Morton wrote: On Wed, 6 Feb 2008 09:40:15 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9901 Summary: kernel panic in stex modules (?) Product: IO/Storage Version: 2.5

Re: [PATCH 3/9] scsi_dh: scsi handling of REQ_LB_OP_TRANSITION

2008-02-06 Thread Mike Anderson
James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-02-01 at 14:00 -0600, Mike Christie wrote: Chandra Seetharaman wrote: @@ -1445,9 +1479,24 @@ static void scsi_kill_request(struct req static void scsi_softirq_done(struct request *rq) { struct scsi_cmnd *cmd =

Re: [PATCH] sr: update to follow tray status correctly

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 17:09 +, Daniel Drake wrote: Hi James, James Bottomley wrote: It's been a while with no status on this one, so I corrected the patch based on my original input. The attached is what I think is the best way of doing this (I've replaced the home grown

Re: ABORT_TASK defined in aic94xx_sas.h

2008-02-06 Thread Luben Tuikov
--- On Wed, 2/6/08, Boaz Harrosh [EMAIL PROTECTED] wrote: include/scsi/scsi.h as a definition: #define ABORT_TASK 0x0d on the other hand drivers/scsi/aic94xx/aic94xx_sas.h has: #define ABORT_TASK 0x03 am I right in thinking that aic94xx_sas.h is wrong in polluting

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-06 Thread Alan Stern
On Tue, 5 Feb 2008, Matthew Dharm wrote: Six of one and a half-dozen of the other. All we're arguing over is the definition of correct behavior here. You want to change the API so that overrun is acceptable and handled; I prefer calling it a Bad Thing(tm). We both agree that the code

Re: [PATCH 3/9] scsi_dh: scsi handling of REQ_LB_OP_TRANSITION

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 11:00 -0800, Mike Anderson wrote: James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-02-01 at 14:00 -0600, Mike Christie wrote: Chandra Seetharaman wrote: @@ -1445,9 +1479,24 @@ static void scsi_kill_request(struct req static void scsi_softirq_done(struct

Re: [PATCH] sr: update to follow tray status correctly

2008-02-06 Thread Daniel Drake
James Bottomley wrote: However, I think you're right, the vanilla TUR does eat NOT_READY for removable media, which CDs are. Does this fix it? Works great, thanks! Daniel - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More

[PATCH 1/1] aacraid: add optional MSI support.

2008-02-06 Thread Salyzyn, Mark
Added support for MSI utilizing the aacraid.msi=1 parameter. This patch adds some localized or like-minded janitor fixes. Since the default is disabled, there is no impact on the code paths unless the customer wishes to experiment with the MSI performance. This patch is against current

[PATCH 1/1] aacraid: do not set valid bit in sense information

2008-02-06 Thread Salyzyn, Mark
Luben Tuikov [mailto:[EMAIL PROTECTED] sez: Just as in your case and Tony's case, which I presume uses the same RAID firmware vendor, it would've probably been better if the RAID firmware vendor fixed the firmware to not set the VALID bit if the INFORMATION field is not valid. Point taken

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-06 Thread Alan Stern
On Wed, 6 Feb 2008, Matthew Dharm wrote: Maybe this is a crazy question, but... Why is this not in the SCSI core? Or even in the block core? It's hardly USB-specific, and I'm willing to bet that there are other HCDs (at least spb2) which need to do this sort of thing... James, do you

Re: Kernel Panic in MPT SAS on 2.6.24 (and 2.6.23.14, 2.6.23.9)

2008-02-06 Thread Andrew Morton
On Wed, 6 Feb 2008 22:04:26 +0100 Maximilian Wilhelm [EMAIL PROTECTED] wrote: Hi! While installing my new firewall I got the following kernel panic in the MPT SAS driver which I need for the disks. The first kernel I bootet was 2.6.23.14 which did panic so I tried a 2.6.24 which panics,

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 17:18 -0500, Alan Stern wrote: On Wed, 6 Feb 2008, Matthew Dharm wrote: Maybe this is a crazy question, but... Why is this not in the SCSI core? Or even in the block core? It's hardly USB-specific, and I'm willing to bet that there are other HCDs (at

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-06 Thread Alan Stern
On Wed, 6 Feb 2008, James Bottomley wrote: What we're talking about is a routine that provides drivers a simple way to access the data in a scatter-gather buffer (which may lie in highmem or otherwise not be easily reachable). The idea is that some commands are emulated by the driver

Re: [PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-06 Thread James Bottomley
On Tue, 2008-02-05 at 16:53 +0900, Tejun Heo wrote: This patchset updates block layer padding and draining support and make libata use it. It's based on James Bottomley's initial work and, of the five, the last two patches are from James with some modifications. Please read the following

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-06 Thread James Bottomley
On Wed, 2008-02-06 at 18:25 -0500, Alan Stern wrote: On Wed, 6 Feb 2008, James Bottomley wrote: What we're talking about is a routine that provides drivers a simple way to access the data in a scatter-gather buffer (which may lie in highmem or otherwise not be easily reachable). The

Re: [PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-06 Thread Jeff Garzik
Tejun Heo wrote: This patchset updates block layer padding and draining support and make libata use it. It's based on James Bottomley's initial work and, of the five, the last two patches are from James with some modifications. Please read the following thread for more info.

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-06 Thread Jeff Garzik
Ke Wei wrote: Added support for hotplug and wide port. Signed-off-by: Ke Wei [EMAIL PROTECTED] --- drivers/scsi/mvsas.c | 445 ++ 1 files changed, 339 insertions(+), 106 deletions(-) Technically speaking, everything is looking great so far.