Re: [Bug 9775] HOST_MSG_LOOP invalid SCB ff

2008-02-12 Thread James Bottomley
On Fri, 2008-02-08 at 18:52 -0800, [EMAIL PROTECTED] wrote: Ok, I've spent some time trying different combinations of devices. Against kernel 2.6.24 T0 is Quantum DLT8000 ID0 T1 is Quantum DLT8000 ID1 MTX is STK L80 ID 15 Terminators A, B Channel A

Re: [PATCH] bsg: bidi bio map failure fix

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 15:40 -0500, Pete Wyckoff wrote: If blk_rq_map_user requires more than one bio, and fails mapping somewhere after the first bio, it will return with rq-bio set to non-NULL, but it will have already unmapped the partial bio. The out: error exit section will see the

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 12:21 -1000, Joshua Hoblitt wrote: I've got a few compilation errors on head. Before I try it, is it possible to backport the 76d78300a6eb8b7f08e47703b7e68a659ffc2053 change to 2.6.24.y? I don't see any reason why not but I'd have to cherry pick it to see ... so you

Re: aic94xx: wrong order of SATA disks

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 23:22 +0200, Sergey Kononenko wrote: Hello, I have server with motherboard Supermicro X7DBR-3 (AIC-9410 onboard). And there are three SATA disks in following order: 1st drive bay: WD800AAJS-60 2nd drive bay: WD2500YS-01S 3rd drive bay: WD2500YS-01S in BIOS they

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: reposting an updated version of it. Please check if it's ok. Looks fine, thanks! You added an extra space at the end of while ((pdev = pci_get_device(vendor, device, pdev)) Which I fixed. Unfortunately checkpatch isn't very helpful for

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-12 Thread Nicholas A. Bellinger
Greetings all, On Tue, 2008-02-12 at 17:05 +0100, Bart Van Assche wrote: On Feb 6, 2008 1:11 AM, Nicholas A. Bellinger [EMAIL PROTECTED] wrote: I have always observed the case with LIO SE/iSCSI target mode ... Hello Nicholas, Are you sure that the LIO-SE kernel module source code is

RE: arcmsr + archttp64 calls dma_free_coherent() with irqsdisabled - dmesg filled with warnings

2008-02-12 Thread nickcheng
Please keep me in the loop. -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Wednesday, February 13, 2008 6:31 AM To: Joshua Hoblitt Cc: Kim H?jgaard-Hansen; [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: arcmsr +

[PATCH] gdth: convert to PCI hotplug API

2008-02-12 Thread Jeff Garzik
Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- drivers/scsi/gdth.c | 143 +++- 1 file changed, 86 insertions(+), 57 deletions(-) 06196f50915da97bb897495863f9f084d785c1e4 diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-12 Thread Joshua Hoblitt
I've got a few compilation errors on head. Before I try it, is it possible to backport the 76d78300a6eb8b7f08e47703b7e68a659ffc2053 change to 2.6.24.y? -J -- On Tue, Feb 12, 2008 at 10:53:45AM -1000, Joshua Hoblitt wrote: I tried doing a build from that commit id but I get an oops from an

[Bug 9775] HOST_MSG_LOOP invalid SCB ff

2008-02-12 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9775 --- Comment #10 from [EMAIL PROTECTED] 2008-02-12 13:56 --- Reply-To: [EMAIL PROTECTED] On Fri, 2008-02-08 at 18:52 -0800, [EMAIL PROTECTED] wrote: Ok, I've spent some time trying different combinations of devices. Against kernel

aic94xx: wrong order of SATA disks

2008-02-12 Thread Sergey Kononenko
Hello, I have server with motherboard Supermicro X7DBR-3 (AIC-9410 onboard). And there are three SATA disks in following order: 1st drive bay: WD800AAJS-60 2nd drive bay: WD2500YS-01S 3rd drive bay: WD2500YS-01S in BIOS they listed in the same order. But after I've loaded linux (2.6.23.14 and

Re: [PATCH 1/3] iscsi iser: remove DMA restrictions

2008-02-12 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:10 -0600: On Tue, 2008-02-12 at 15:54 -0500, Pete Wyckoff wrote: iscsi_iser does not have any hardware DMA restrictions. Add a slave_configure function to remove any DMA alignment restriction, allowing the use of direct IO from arbitrary

Re: [PATCH 1/3] iscsi iser: remove DMA restrictions

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 16:46 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:10 -0600: On Tue, 2008-02-12 at 15:54 -0500, Pete Wyckoff wrote: iscsi_iser does not have any hardware DMA restrictions. Add a slave_configure function to remove any DMA alignment

Re: [PATCH 1/3] iscsi iser: remove DMA restrictions

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 15:54 -0500, Pete Wyckoff wrote: iscsi_iser does not have any hardware DMA restrictions. Add a slave_configure function to remove any DMA alignment restriction, allowing the use of direct IO from arbitrary offsets within a page. Also disable page bouncing; iser has no

[PATCH 3/3] iscsi iser: increase sg_tablesize

2008-02-12 Thread Pete Wyckoff
Increase FMR limits from 512 kB to 1 MB. This matches the limit used by SRP which also uses FMRs for memory mapping. Also correct a bug where the sg_tablesize was 1 smaller than what was allocated, by folding the + 1 used everywhere into the definition of the constant. Signed-off-by: Pete

Re: [PATCH 0/3] iscsi bidi varlen support

2008-02-12 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Thu, 31 Jan 2008 20:08 +0200: Cheers after 1.3 years these can go in. [PATCH 1/3] iscsi: extended cdb support The varlen support is not yet in mainline for block and scsi-ml. But the API for drivers will not change. All LLD need to do is max_command to

Re: [patch 02/13] git-scsi-misc gdth fix

2008-02-12 Thread Andrew Morton
On Tue, 12 Feb 2008 17:27:33 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: On Tue, Feb 05 2008 at 9:53 +0200, [EMAIL PROTECTED] wrote: From: James Bottomley [EMAIL PROTECTED] On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote: On Sun, 14 Oct 2007 22:45:47 +0400 Dave Milter [EMAIL

Re: Subject: [PATCH 1/3] Let scsi_cmnd-cmnd use request-cmd buffer

2008-02-12 Thread James Bottomley
On Sun, 2008-02-10 at 21:05 +0200, Boaz Harrosh wrote: - struct scsi_cmnd had a 16 bytes command buffer of its own. This is an unnecessary duplication and copy of request's cmd. It is probably left overs from the time that scsi_cmnd could function without a request attached. So clean

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: I understand what you are trying to do - I guess I just doubt the value you've added by doing this. I think that there's going to be so much customization that system vendors will want to add, that they are going to wind up

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 12:45:35 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote: I apologize for taking so long to review this patch. I obviously agree wholeheartedly with Luben. The problem I ran into while trying to design an

[Bug 8908] 3ware 9650SE -8LPML not recognized by 3w-9xxx driver

2008-02-12 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=8908 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |REJECTED Resolution|

[Bug 8908] 3ware 9650SE -8LPML not recognized by 3w-9xxx driver

2008-02-12 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=8908 --- Comment #6 from [EMAIL PROTECTED] 2008-02-12 11:30 --- The 9650SE (vendor:0x13c1, device id: 0x1004) controller series has been supported by the in-kernel 3w-9xxx driver since 2.6.19 kernel. The user did not properly configure

Re: Open bugs

2008-02-12 Thread Natalie Protasevich
On Feb 12, 2008 9:57 AM, James Bottomley [EMAIL PROTECTED] wrote: Added linux-scsi for the SCSI ones On Tue, 2008-02-12 at 00:18 -0800, Natalie Protasevich wrote: Hello, The bugs listed are over a month old, and haven't been addressed yet. It would be appreciated if corresponding

[Bug 8908] 3ware 9650SE -8LPML not recognized by 3w-9xxx driver

2008-02-12 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=8908 [EMAIL PROTECTED] changed: What|Removed |Added CC|linux-scsi@vger.kernel.org | AssignedTo|[EMAIL

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote: I apologize for taking so long to review this patch. I obviously agree wholeheartedly with Luben. The problem I ran into while trying to design an enclosure management interface for the SATA devices is that there is all this

Re: [PATCH 3/3] scsi: varlen extended and vendor-specific cdbs

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 19:51 +0200, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sun, Feb 10, 2008 at 09:12:02PM +0200, Boaz Harrosh wrote: @@ -525,6 +516,7 @@ int scsi_dispatch_cmd(struct scsi_cmnd *cmd) unsigned long flags = 0; unsigned long timeout; int rtn = 0; +

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Mon, 4 Feb 2008 18:01:36 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Mon, 2/4/08, James Bottomley [EMAIL PROTECTED] wrote: The enclosure misc device is really just a library providing sysfs support for physical enclosure devices and their components. Who

Re: [PATCH 2/3] block layer varlen-cdb

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 19:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Tue, Feb 12 2008 at 19:48 +0200, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sun, Feb 10, 2008 at 09:09:41PM +0200, Boaz Harrosh wrote: - add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed.

Re: [BUGFIX 1/2] gdth: scan for scsi devices

2008-02-12 Thread Christoph Hellwig
On Tue, Feb 12, 2008 at 07:35:22PM +0200, Boaz Harrosh wrote: The patch: gdth: switch to modern scsi host registration missed one simple fact when moving a way from scsi_module.c. That is to call scsi_scan_host() on the probed host. With this the gdth driver from 2.6.24 is again able to

Re: Open bugs

2008-02-12 Thread James Bottomley
Added linux-scsi for the SCSI ones On Tue, 2008-02-12 at 00:18 -0800, Natalie Protasevich wrote: Hello, The bugs listed are over a month old, and haven't been addressed yet. It would be appreciated if corresponding maintainers identify whether the bugs have been fixed, or need to be worked

Re: [PATCH 2/3] block layer varlen-cdb

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 19:48 +0200, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sun, Feb 10, 2008 at 09:09:41PM +0200, Boaz Harrosh wrote: - add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed. They start as empty. Allocation of buffer must be done by user and held until

Re: [PATCH 3/3] scsi: varlen extended and vendor-specific cdbs

2008-02-12 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:12:02PM +0200, Boaz Harrosh wrote: @@ -525,6 +516,7 @@ int scsi_dispatch_cmd(struct scsi_cmnd *cmd) unsigned long flags = 0; unsigned long timeout; int rtn = 0; + unsigned cmd_len; /* check if the device is still usable */ if

Re: Subject: [PATCH 1/3] Let scsi_cmnd-cmnd use request-cmd buffer

2008-02-12 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:05:17PM +0200, Boaz Harrosh wrote: - Lots of drivers still use MAX_COMMAND_SIZE. So I have left that #define but equate it to BLK_MAX_CDB. The way I see it and is reflected in the patch below is. MAX_COMMAND_SIZE - means: The longest fixed-length (*) SCSI CDB

[BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-12 Thread Boaz Harrosh
gdth _exit would first remove all cards then stop the timer and would not sync with the timer function. This caused a crash in gdth_timer() when module was unloaded. del_timer_sync the timer before we delete the cards. NOT YET TESTED Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] ---

[BUGFIX 1/2] gdth: scan for scsi devices

2008-02-12 Thread Boaz Harrosh
The patch: gdth: switch to modern scsi host registration missed one simple fact when moving a way from scsi_module.c. That is to call scsi_scan_host() on the probed host. With this the gdth driver from 2.6.24 is again able to see drives and boot. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]

[PATCH] bsg: bidi bio map failure fix

2008-02-12 Thread Pete Wyckoff
If blk_rq_map_user requires more than one bio, and fails mapping somewhere after the first bio, it will return with rq-bio set to non-NULL, but it will have already unmapped the partial bio. The out: error exit section will see the non-null bio and try to unmap it again, triggering a mapcount bug

Re: [PATCH 0/3] iscsi bidi varlen support

2008-02-12 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:12 -0500: [EMAIL PROTECTED] wrote on Thu, 31 Jan 2008 20:08 +0200: Cheers after 1.3 years these can go in. [PATCH 1/3] iscsi: extended cdb support The varlen support is not yet in mainline for block and scsi-ml. But the API for

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 18:22 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning:

[PATCH 1/3] iscsi iser: remove DMA restrictions

2008-02-12 Thread Pete Wyckoff
iscsi_iser does not have any hardware DMA restrictions. Add a slave_configure function to remove any DMA alignment restriction, allowing the use of direct IO from arbitrary offsets within a page. Also disable page bouncing; iser has no restrictions on which pages it can address. Signed-off-by:

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Luben Tuikov
--- On Tue, 2/12/08, Kristen Carlson Accardi [EMAIL PROTECTED] wrote: Hi, I apologize for taking so long to review this patch. I obviously agree wholeheartedly with Luben. The problem I ran into while trying to design an enclosure management interface for the SATA devices is that there

[BUGFIXES 0/2] gdth: fix 2.6.24 driver breakage

2008-02-12 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 12:08 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Wed, Jan 30 2008 at 21:47 +0200, Sven Köhler [EMAIL PROTECTED] wrote: Hi, so i have upgraded a system to kernel 2.6.24. After that, it failed to boot with the usual message telling, that the rootfs on device

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:495)

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-12 Thread Bart Van Assche
On Feb 6, 2008 1:11 AM, Nicholas A. Bellinger [EMAIL PROTECTED] wrote: I have always observed the case with LIO SE/iSCSI target mode ... Hello Nicholas, Are you sure that the LIO-SE kernel module source code is ready for inclusion in the mainstream Linux kernel ? As you know I tried to test the

Re: [patch 02/13] git-scsi-misc gdth fix

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 05 2008 at 9:53 +0200, [EMAIL PROTECTED] wrote: From: James Bottomley [EMAIL PROTECTED] On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote: On Sun, 14 Oct 2007 22:45:47 +0400 Dave Milter [EMAIL PROTECTED] wrote: I build linux-2.6.23-mm1 and try to boot it using qemu, and it

[PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread Sergio Luis
Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:495) Signed-off-by: Sergio Luis [EMAIL PROTECTED] gdth.c |2 +-

2.6.24.2: MPT Fusion LTO-3 tape troubles

2008-02-12 Thread Gerhard Schneider
After using 2.6.11.12 for long time (with success) I tried to update to 2.6.24.2 Hardware: LSI53C1030 B2 Overland NEO Changer HP Ultrium 3-SCSI tape drive Kernel messages when booting: Feb 12 14:28:03 ilfb03 kernel: Fusion MPT base driver 3.04.06 Feb 12 14:28:03

[PATCH] SCSI: fix data corruption caused by ses

2008-02-12 Thread Yinghai Lu
one system: initrd get courrupted: RAMDISK: Compressed image found at block 0 RAMDISK: incomplete write (-28 != 2048) 134217728 crc error VFS: Mounted root (ext2 filesystem). Freeing unused kernel memory: 388k freed init_special_inode: bogus i_mode (17) Warning: unable to open an initial

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-12 Thread Stefan Priebe - allied internet ag
Hello! I've tested this patch now - and it works fine. Now rmmod, halt and reboot also works. Stefan Priebe Boaz Harrosh schrieb: gdth _exit would first remove all cards then stop the timer and would not sync with the timer function. This caused a crash in gdth_timer() when module was

Re: [PATCH 2/3] block layer varlen-cdb

2008-02-12 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:09:41PM +0200, Boaz Harrosh wrote: - add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed. They start as empty. Allocation of buffer must be done by user and held until request execution is done. - Since there can be either a fix_length command up