Re: [PATCH] virtio-scsi: Fix incorrect lock release order in virtscsi_kick_cmd

2012-11-09 Thread Paolo Bonzini
Il 09/11/2012 07:29, Nicholas A. Bellinger ha scritto: From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a regression bug in virtscsi_kick_cmd() that relinquishes the acquired spinlocks in the incorrect order using the wrong spin_unlock macros, namely releasing vq-vq_lock before

Re: [PATCH] virtio_scsi: fix memory leak on full queue condition.

2012-11-09 Thread Paolo Bonzini
Il 08/11/2012 10:55, Eric Northup ha scritto: virtscsi_queuecommand was leaking memory when the virtio queue was full. Tested: Guest operates correctly even with very small queue sizes, validated we're not leaking kmalloc-192 sized allocations anymore. Signed-off-by: Eric Northup

Re: scsi target, likely GPL violation

2012-11-09 Thread Alan Cox
For our commercial target core, we only use Linux kernel symbols that are not marked as GPL. In addition, we define the API between the target And this has what meaning ? The Linux kernel is a GPL work, any derivative work is a GPL work. The symbol tags are just a guidance. You do not have

Re: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-09 Thread Xi Wang
On 11/9/12 2:30 AM, Xiangliang Yu wrote: Agree with James, and just need to do NOT operation one time Thanks for reviewing the patches. Okay I'll remove patch 2 in v2 then. About patch 3, I check the ffz code and found it will check ~0 conditions. Can you point me to the ~0 check in ffz

USB enclosures seem to require read(16) with 2TB drives

2012-11-09 Thread Jason J. Herne
Hello, I've noticed Linux seems to have issues with external USB enclosures containing drives 2 TB. The USB mass storage driver apparently emulates a SCSI device and sends a read/write(10) for all requests where the target sector is not large enough to require the use of read(16). The issue is

[PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-09 Thread Jason J. Herne
From: Jason J. Herne hern...@gmail.com Force large capacity ( 2TB) drives in USB enclosures to use READ(16) instead of READ(10). Some(most/all?) enclosures do not like READ(10) commands when a large capacity drive is installed. Signed-off-by: Jason J. Herne hern...@gmail.com ---

Re: USB enclosures seem to require read(16) with 2TB drives

2012-11-09 Thread Alan Stern
On Fri, 9 Nov 2012, Jason J. Herne wrote: Hello, I've noticed Linux seems to have issues with external USB enclosures containing drives 2 TB. The USB mass storage driver apparently emulates a SCSI device and sends a read/write(10) for all Actually, it's the SCSI disk driver which decides

RE: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-09 Thread Elliott, Robert (Server Storage)
I recommend broadening this patch. T10 is discussing making READ (10), WRITE (10), etc. obsolete in SBC-4 in favor of their 16-byte CDB counterparts. The algorithm should be: 1. During discovery, determine if 16-byte CDBs are supported. There are several ways to determine this: a) REPORT

[patch,v3 00/10] make I/O path allocations more numa-friendly

2012-11-09 Thread Jeff Moyer
Hi, This patch set makes memory allocations for data structures used in the I/O path more numa friendly by allocating them from the same numa node as the storage device. I've only converted a handful of drivers at this point. My testing showed that, for workloads where the I/O processes were

[patch,v3 02/10] scsi: make __scsi_alloc_queue numa-aware

2012-11-09 Thread Jeff Moyer
Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_lib.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[patch,v3 09/10] lpfc: use scsi_host_alloc_node

2012-11-09 Thread Jeff Moyer
Acked-By: James Smart james.sm...@emulex.com Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/lpfc/lpfc_init.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 7dc4218..65956d3 100644

[patch,v3 10/10] cciss: use blk_init_queue_node

2012-11-09 Thread Jeff Moyer
Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/block/cciss.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index b0f553b..5fe5546 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -1930,7 +1930,8

[patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

2012-11-09 Thread Jeff Moyer
Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..1750702 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -173,16

[patch,v3 05/10] sd: use alloc_disk_node

2012-11-09 Thread Jeff Moyer
Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..a5dae6b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2714,7 +2714,7 @@ static int

[patch,v3 03/10] scsi: make scsi_alloc_sdev numa-aware

2012-11-09 Thread Jeff Moyer
Use the numa node id set in the Scsi_Host to allocate the sdev structure on the device-local numa node. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_scan.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c

[patch,v3 01/10] scsi: add scsi_host_alloc_node

2012-11-09 Thread Jeff Moyer
Allow an LLD to specify on which numa node to allocate scsi data structures. Thanks to Bart Van Assche for the suggestion. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/hosts.c | 13 +++-- include/scsi/scsi_host.h | 28 2 files

[patch,v3 08/10] mpt2sas: use scsi_host_alloc_node

2012-11-09 Thread Jeff Moyer
Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/mpt2sas/mpt2sas_scsih.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index af4e6c4..a4d6b36 100644 ---

[patch,v3 06/10] ata: use scsi_host_alloc_node

2012-11-09 Thread Jeff Moyer
Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index e3bda07..9d5dd09 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c

[patch,v3 07/10] megaraid_sas: use scsi_host_alloc_node

2012-11-09 Thread Jeff Moyer
Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index d2c5366..707a6cd 100644 ---

Re: [PATCH] virtio-scsi: Fix incorrect lock release order in virtscsi_kick_cmd

2012-11-09 Thread Nicholas A. Bellinger
Hi Paolo, On Fri, 2012-11-09 at 09:42 +0100, Paolo Bonzini wrote: Il 09/11/2012 07:29, Nicholas A. Bellinger ha scritto: From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a regression bug in virtscsi_kick_cmd() that relinquishes the acquired spinlocks in the incorrect order

Re: scsi target, likely GPL violation

2012-11-09 Thread Andy Grover
On 11/09/2012 03:03 AM, Alan Cox wrote: I fail to understand the maintainer question however. If you were trying to block people adding target features that competed that would be a different thing. You think it's ok for us to have an unrepentant GPL violator as a subsystem maintainer?? If

Re: scsi target, likely GPL violation

2012-11-09 Thread Alan Cox
On Fri, 09 Nov 2012 11:52:19 -0800 Andy Grover agro...@redhat.com wrote: On 11/09/2012 03:03 AM, Alan Cox wrote: I fail to understand the maintainer question however. If you were trying to block people adding target features that competed that would be a different thing. You think it's

Re: [patch,v2 00/10] make I/O path allocations more numa-friendly

2012-11-09 Thread Jeff Moyer
Bart Van Assche bvanass...@acm.org writes: On 11/06/12 16:41, Elliott, Robert (Server Storage) wrote: It's certainly better to tie them all to one node then let them be randomly scattered across nodes; your 6% observation may simply be from that. How do you think these compare, though (for

[PATCH] target: Update copyright ownership to 2012

2012-11-09 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hello everyone, This patch to update copyright year to current for principal target core ownership is now being pushed into target-pending/for-next. Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/target_core_alua.c

Re: scsi target, likely GPL violation

2012-11-09 Thread Andy Grover
On 11/08/2012 06:08 PM, Nicholas A. Bellinger wrote: Support for certified VAAI is part of our commercial target core. The target core constitutes a stand-alone kernel subsystem of which we are the sole copyright owners. In addition, our target contains a number of backend drivers, of which we

Re: [PATCH] virtio-scsi: Fix incorrect lock release order in virtscsi_kick_cmd

2012-11-09 Thread Paolo Bonzini
Il 09/11/2012 20:31, Nicholas A. Bellinger ha scritto: That's done on purpose. After you do virtqueue_add_buf, you don't need the sg list anymore, nor the lock that protects it. The cover letter is at https://lkml.org/lkml/2012/6/13/295 and had this text: This series reorganizes the