Hello Hiral Patel,
The patch d3c995f1dcf9: [SCSI] fnic: FIP VLAN Discovery Feature
Support from Feb 25, 2013, leads to the following
static checker warning:
drivers/scsi/fnic/fnic_fcs.c:278 is_fnic_fip_flogi_reject()
warn: is it ok to set 'els_len' to negative?
This is some
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Wednesday, October 30, 2013 10:44 PM
To: DL-MegaRAID Linux
Cc: James E.J. Bottomley; linux-scsi@vger.kernel.org; secur...@kernel.org;
Nico Golde; Fabian Yamaguchi
Subject: [patch] [SCSI] megaraid: missing
-Original Message-
From: Jasper Spaans [mailto:spa...@fox-it.com]
Sent: Friday, October 25, 2013 5:53 PM
To: DL-MegaRAID Linux
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] megaraid_sas: make the log message about rescanning
more informative.
Hi,
I was working on one of our servers,
-Original Message-
From: Wei Yongjun [mailto:weiyj...@gmail.com]
Sent: Friday, December 20, 2013 8:38 AM
To: DL-MegaRAID Linux; jbottom...@parallels.com; simon.pu...@gmail.com;
jkos...@suse.cz
Cc: yongjun_...@trendmicro.com.cn; linux-scsi@vger.kernel.org
Subject: [PATCH] [SCSI] megaraid:
Hiral isn't at Cisco any more.
regards,
dan carpenter
On Wed, Jan 08, 2014 at 12:57:41PM +0300, Dan Carpenter wrote:
Hello Hiral Patel,
The patch d3c995f1dcf9: [SCSI] fnic: FIP VLAN Discovery Feature
Support from Feb 25, 2013, leads to the following
static checker warning:
On Tue, Jan 07, 2014 at 08:37:23PM +0200, Sergey Meirovich wrote:
Actually my initial report (14.67Mb/sec 3755.41 Requests/sec) was about ext4
However I have tried XFS as well. It was a bit slower than ext4 on all
occasions.
I wasn't trying to say XFS fixes your problem, but that we could
Hi James,
On 7 January 2014 22:57, James Smart james.sm...@emulex.com wrote:
Sergey,
The Thor chipset is a bit old - a 4Gig adapter. Most of our performance
improvements, including parallelization, have gone into the 8G and 16G
adapters. But you still should have seen significantly beyond
On 01/08/2014 03:32 PM, Hannes Reinecke wrote:
On 12/24/2013 04:35 AM, Chen Gang wrote:
On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote:
On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote:
On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote:
Hi Chen,
On Sat, 2013-12-21 at 10:08 +0800,
Hi Christoph,
On 8 January 2014 16:03, Christoph Hellwig h...@infradead.org wrote:
On Tue, Jan 07, 2014 at 08:37:23PM +0200, Sergey Meirovich wrote:
Actually my initial report (14.67Mb/sec 3755.41 Requests/sec) was about ext4
However I have tried XFS as well. It was a bit slower than ext4 on
James == James Bottomley james.bottom...@hansenpartnership.com writes:
James No, I think you're confusing algorithms with protocols. DIF and
James DIX are two names for protection envelopes. DIF verifies
James integrity from the HBA to the device surface. DIX verifies
James integrity from an
On Wed, 8 Jan 2014, James Bottomley wrote:
OK, Agreed, but that means modifying the 1/2 patch with the below. This
should make the proposed diff to 2/2 correct.
James
---
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index ef3f958..5fad646 100644
---
From: Sarah Sharp
On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote:
On 01/07/2014 01:21 PM, Sarah Sharp wrote:
Can you please try the attached patch, on top of the previous three
patches, and send me dmesg?
Hi Sarah, I just now finished running 0001-More-debugging.patch for the
On Tue, 7 Jan 2014, Sarah Sharp wrote:
On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote:
On 01/07/2014 01:21 PM, Sarah Sharp wrote:
Can you please try the attached patch, on top of the previous three
patches, and send me dmesg?
Hi Sarah, I just now finished running
From: Alan Stern
This may be a foolish question, but why is xhci-hcd using no-op TRBs in
the first place?
Because it can't write in a link TRB because other parts of the
code use link TRBs to detect the end of the ring.
The problem is that it can't put a link TRB in the middle of
a chain of
On Wed, 8 Jan 2014, David Laight wrote:
From: Alan Stern
This may be a foolish question, but why is xhci-hcd using no-op TRBs in
the first place?
Because it can't write in a link TRB because other parts of the
code use link TRBs to detect the end of the ring.
The problem is that
On 8 January 2014 17:26, Christoph Hellwig h...@infradead.org wrote:
On my laptop SSD I get the following results (sometimes up to 200MB/s,
sometimes down to 100MB/s, always in the 40k to 50k IOps range):
time elapsed (sec.):5
bandwidth (MiB/s): 160.00
IOps:
From: Alan Stern
On Wed, 8 Jan 2014, David Laight wrote:
From: Alan Stern
This may be a foolish question, but why is xhci-hcd using no-op TRBs in
the first place?
Because it can't write in a link TRB because other parts of the
code use link TRBs to detect the end of the ring.
On Tue, 7 Jan 2014, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 01/07/2014 02:18 PM, Alan Stern wrote:
I don't know how you manually spin down your disk, but one
reasonable way to do it is to set the autosuspend timeout to 0. If
you use this approach and
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/8/2014 2:00 AM, Aaron Lu wrote:
Then I would say we just keep the pm_request_resume call in their
system resume callback. For drives that have that cool feature
turned on, it will be in runtime active state while it's actually
in standby
On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
Building advansys.o triggers this warning:
drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
not properly converted to the DMA API [-Wcpp]
This warning can
On Wednesday 08 January 2014 21:05:14 Paul Bolle wrote:
On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
Building advansys.o triggers this warning:
drivers/scsi/advansys.c:71:2: warning: #warning this driver is
still not
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/8/2014 12:46 PM, Alan Stern wrote:
I/O _was_ done. To spin up the disk requires sending it a START
command. That's I/O.
Yes, currently, but that's exactly what I'm trying to get rid of.
In essence, you want your disk's state to move
On Wed, 2014-01-08 at 21:15 +0100, Ondrej Zary wrote:
The driver works fine with narrow boards. Please don't break working drivers
because of some stupid warning.
My patch changed a buildtime warning for both narrow and wide boards in
a runtime error on wide boards only. That wouldn't break
From: Nicholas Bellinger n...@linux-iscsi.org
Hi MKP SCSI folks,
This series contains initial support for target mode DIF Type1+Type3
emulation within target core, RAMDISK_MCP device backend, and tcm_loop
fabric driver.
DIF emulation is enabled via a new 'pi_prot_type' device attribute
within
From: Nicholas Bellinger n...@linux-iscsi.org
This patch updates spc_emulate_evpd_86() (extended INQUIRY) to
report GRD_CHK (Guard Check) and REF_CHK (Reference Check) bits
when DIF emulation is enabled by the backend device.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support to target_submit_cmd_map_sgls() for
accepting 'sgl_prot' + 'sgl_prot_count' parameters for
DIF protection information.
Note the passed parameters are stored at se_cmd-t_prot_sg
and se_cmd-t_prot_nents respectively.
Also,
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds rd_build_prot_space() + rd_release_prot_space() logic
to setup + release protection information scatterlists.
It also adds rd_init_prot() + rd_free_prot() se_subsystem_api
callbacks used by target core code for setup + release of
From: Nicholas Bellinger n...@linux-iscsi.org
This patch updates tcm_loop_driver_probe() to set protection
information using scsi_host_set_prot() and scsi_host_set_guard(),
which currently enabled all modes of DIF/DIX protection, minus
DIF TYPE0.
Also, update tcm_loop_submission_work() to pass
From: Nicholas Bellinger n...@linux-iscsi.org
This patch refactors rd_build_device_space() + rd_release_device_space()
into rd_allocate_sgl_table() + rd_release_device_space() so that they
may be used seperatly for setup + release of protection information
scatterlists.
Also add explicit memset
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for exposing DIF protection device
attributes via configfs. This includes:
pi_prot_type: Protection Type (0, 1, 3 currently support)
pi_prot_version: Protection Version (DIF v1 currently supported)
pi_guard_type:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for DIF protection into rd_execute_rw() code
for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic.
It also adds rd_get_prot_table() for locating protection SGLs
assoicated with the ramdisk backend device.
Cc: Martin
From: Nicholas Bellinger n...@linux-iscsi.org
This patch updates sbc_emulate_readcapacity_16() to set
P_TYPE and PROT_EN bits when DIF emulation is enabled by
the backend device.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
From: Nicholas Bellinger n...@linux-iscsi.org
This patch updates spc_modesense_control() to set the Application
Tag Owner (ATO) bit when when DIF emulation is enabled by the
backend device.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke
From: Nicholas Bellinger n...@linux-iscsi.org
This patch updates spc_emulate_inquiry_std() to set the
PROTECT bit when DIF emulation is enabled by the backend
device.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ
exception cases into transport_send_check_condition_and_sense().
This includes:
LOGICAL BLOCK GUARD CHECK FAILED
LOGICAL BLOCK APPLICATION TAG CHECK FAILED
LOGICAL BLOCK
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for DIF read/write verify emulation
for TARGET_DIF_TYPE1_PROT + TARGET_DIF_TYPE3_PROT operation.
This includes sbc_dif_verify_write() + sbc_dif_verify_read()
calls accessable by backend drivers to perform DIF verify
for SGL
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds DIF related definitions to target_core_base.h
that includes enums for target_prot_op + target_prot_type +
target_prot_version + target_guard_type + target_pi_error.
Also included is struct se_dif_v1_tuple, along with changes
to struct
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds sbc_check_prot() for performing various DIF
related CDB sanity checks, along with setting SCF_PROT once
sanity checks have passed.
Also, add calls in sbc_parse_cdb() for READ_[10,12,16] +
WRITE_[10,12,16] to perform DIF sanity
On Wed, 8 Jan 2014, Phillip Susi wrote:
In essence, you want your disk's state to move directly from
unpowered (system asleep) to runtime-suspended with no intermediate
active -- but only if the disk doesn't spin up all by itself.
One problem: How can the kernel tell whether the disk
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/8/2014 4:21 PM, Alan Stern wrote:
I never saw your patches. Where were they posted?
Higher up in this thread on linux-ide and linux-scsi. Subject was Let
sleeping disks lie.
If you issue the REQUEST SENSE command in the usual way (going
On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote:
On 12/24/2013 04:35 AM, Chen Gang wrote:
On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote:
On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote:
SNIP
The related fix patch changed start_lba = lba % ... to start_lba =
lba / ...,
On 01/03/2014 03:29 PM, Sarah Sharp wrote:
I'll let you know when I have some diagnostic patches ready.
Hi Sarah. I see today gregkh committed the patches you've already sent
me, so I assume someone (other than me) has tested those patches and
discovered some benefit from them?
I'm still
On 01/09/2014 05:21 AM, Alan Stern wrote:
On Wed, 8 Jan 2014, Phillip Susi wrote:
You issue a REQUEST SENSE command and that returns status indicating
whether the drive is stopped, or in standby. See my patches. One of
I never saw your patches. Where were they posted?
If you issue the
This patch makes reject messages show right value for opcode and itt, which
is converse previously.
Signed-off-by: Vaughan Cao vaughan@oracle.com
---
drivers/scsi/libiscsi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/libiscsi.c
On 01/08/2014 08:21 PM, Vaughan Cao wrote:
This patch makes reject messages show right value for opcode and itt, which
is converse previously.
Signed-off-by: Vaughan Cao vaughan@oracle.com
---
drivers/scsi/libiscsi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
45 matches
Mail list logo
