Re: [SCSI] qla2xxx: Enhancements to support ISPFx00.

On 4/13/16, 5:39 AM, "Dan Carpenter" wrote: >Hello Giridhar Malavali, > >The patch 8ae6d9c7eb10: "[SCSI] qla2xxx: Enhancements to support >ISPFx00." from Mar 28, 2013, leads to the following static checker >warning: > > drivers/scsi/qla2xxx/qla_mr.c:2264

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

On Fri, Apr 15, 2016 at 07:45:19AM +0200, Ingo Molnar wrote: > > * Denys Vlasenko wrote: > > > > In fact, the following patch seems to fix it: > > > > > > diff --git a/include/scsi/scsi_transport_fc.h > > > b/include/scsi/scsi_transport_fc.h > > > index bf66ea6..56b9e81

[PATCH 2/3] hisi_sas: add slot_index_alloc_quirk_v2_hw()

Add v2 hw custom function slot_index_alloc_quirk_v2_hw(). SAS devices should have IPTT bit0 equal to 1. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 28 1 file changed, 28 insertions(+) diff --git

[PATCH 3/3] hisi_sas: add alloc_dev_quirk_v2_hw()

Add custom version of function to allocate device, alloc_dev_quirk_v2_hw(). For sata devices the device id bit0 should be 0. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 30 ++ 1 file changed, 30 insertions(+) diff

Re: [PATCH v14 0/9] add support for DWC UFS Controller

On 04/13/2016 11:04 AM, Joao Pinto wrote: > As requested, I am sending v14 to be included in the SCSI patchwork. > > The work consisted of: > - Fixed typo in ufshcd-pltfrm.c > - Tweak ufshcd.c for UFS 2.0 support > - Implement ufshcd-dwc which contains all DWC HW specific code > - Unipro

Re: [PATCH 3/9] sd: configure ZBC devices

On 04/04/2016 03:00 AM, Hannes Reinecke wrote: +static int +sd_zbc_report_zones(struct scsi_disk *sdkp, sector_t start_lba, + unsigned char *buffer, int bufflen ) +{ [ ... ] + put_unaligned_be64(start_lba, [2]); + put_unaligned_be32(bufflen, [10]); The argument

Re: [PATCH 2/4] megaraid_sas: call ISR function to clean up pending replies in OCR path

On 04/15/2016 09:23 AM, Sumit Saxena wrote: > In OCR path, before calling chip reset calls function > megasas_wait_for_outstanding_fusion to check reason > of OCR. In case of firmware FAULT initiated OCR and DCMD timeout initiated > timeout, driver will clear any > outstanding reply(yet to be

Re: [PATCH 1/4] megaraid_sas: reduce memory footprints in kdump mode

On 04/15/2016 09:23 AM, Sumit Saxena wrote: > This patch will reduce memory footprints of megaraid_sas driver when booted > in kdump mode. > Driver will not allocate memory for optional and perfromance oriented > features. > Below are key changes done in megaraid_sas driver to do this- > 1.

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: > More info here: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 This bug is under investigation, so I'd rather not alter code for a gcc bug until we know if we can supply options to fix it rather than changing code. James >

Re: [PATCH 2/3] hisi_sas: add slot_index_alloc_quirk_v2_hw()

On 04/15/2016 03:36 PM, John Garry wrote: > Add v2 hw custom function slot_index_alloc_quirk_v2_hw(). > SAS devices should have IPTT bit0 equal to 1. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 28 > 1 file

Re: [PATCH 1/3] hisi_sas: add device and slot alloc hw methods

On 04/15/2016 03:36 PM, John Garry wrote: > Add methods to use HW specific versions of > functions to allocate slot and device. > HW specific methods are permitted to workaround > device id vs IPTT collision issue in v2 hw. > > Signed-off-by: John Garry > --- >

Re: [PATCH 3/3] hisi_sas: add alloc_dev_quirk_v2_hw()

On 04/15/2016 03:36 PM, John Garry wrote: > Add custom version of function to allocate > device, alloc_dev_quirk_v2_hw(). > For sata devices the device id bit0 should be > 0. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 30

Re: [PATCH 3/4] megaraid_sas: task management code optimizations

On 04/15/2016 09:23 AM, Sumit Saxena wrote: > This patch will do code optmization for task management functions. > Below are key changes- > 1. Remove reset_device hook as it was not being used and driver was setting > this to NULL. > 2. Create wrapper functions for task abort and target reset and

Re: [PATCH 4/4] megaraid_sas: driver version upgrade

On 04/15/2016 09:23 AM, Sumit Saxena wrote: > Signed-off-by: Sumit Saxena > --- > drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas.h >

Re: [PATCH 7/9] block: Introduce BLKPREP_DONE

On 04/04/2016 03:00 AM, Hannes Reinecke wrote: @@ -2460,9 +2460,13 @@ struct request *blk_peek_request(struct request_queue *q) rq = NULL; break; - } else if (ret == BLKPREP_KILL || ret == BLKPREP_INVALID) { + } else if

Re: [PATCH 6/9] block: Add 'zoned' sysfs queue attribute

On 04/15/2016 07:45 PM, Bart Van Assche wrote: On 04/04/2016 03:00 AM, Hannes Reinecke wrote: Add a sysfs queue attribute 'zoned' to display the zone layout for zoned devices. Signed-off-by: Hannes Reinecke --- block/blk-sysfs.c | 47

[PATCH 41/42] block: do not use REQ_FLUSH for tracking flush support

From: Mike Christie The last patch added a REQ_OP_FLUSH for request_fn drivers and the next patch renames REQ_FLUSH to REQ_PREFLUSH which will be used by file systems and make_request_fn drivers so they can send a write/flush combo. This patch drops xen's use of REQ_FLUSH

[PATCH 19/42] dm: set bi_op to REQ_OP

From: Mike Christie This patch has dm use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- drivers/md/dm-bufio.c

[PATCH 09/42] btrfs: update __btrfs_map_block for bi_op transition

From: Mike Christie We no longer pass in a bitmap of rq_flag_bits bits to __btrfs_map_block. It will always be a REQ_OP, or the btrfs specific REQ_GET_READ_MIRRORS, so this drops the bit tests. Signed-off-by: Mike Christie Reviewed-by: Christoph

[PATCH 40/42] block, drivers: add REQ_OP_FLUSH operation

From: Mike Christie This adds a REQ_OP_FLUSH operation that is sent to request_fn based drivers by the block layer's flush code, instead of sending requests with the request->cmd_flags REQ_FLUSH bit set. For the following 3 flush related patches, I have not tested every

[PATCH 42/42] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH

From: Mike Christie To avoid confusion between REQ_OP_FLUSH, which is handled by request_fn drivers, and upper layers requesting the block layer perform a flush sequence along with possibly a WRITE, this patch renames REQ_FLUSH to REQ_PREFLUSH. Signed-off-by: Mike Christie

[PATCH 03/42] block, fs, mm, drivers: set bi_op to REQ_OP

From: Mike Christie This patch converts the simple bi_rw use cases in the block, drivers, mm and fs code to set the bio->bi_op to a REQ_OP. These should be simple one liner cases, so I just did them in one patch. The next patches handle the more complicated cases in a

[PATCH 02/42] block: add REQ_OP definitions and bi_op/op fields

From: Mike Christie The following patches separate the operation (write, read, discard, etc) from the rq_flag_bits flags. This patch adds definitions for request/bio operations, adds fields to the request/bio to set them, and some temporary compat code so the kernel/modules

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

> "Dan" == Dan Carpenter writes: Dan> It's possible to use "err" without initializing it. If it happens Dan> to be a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Dan> Van Assche pointed out that we should probably re-initialize it for Dan> every

[PATCH 24/42] xen: set bi_op to REQ_OP

From: Mike Christie This patch has the xen block driver use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke ---

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

On Fri, Apr 15, 2016 at 12:05:26PM -0700, James Bottomley wrote: > On Fri, 2016-04-15 at 20:56 +0200, Denys Vlasenko wrote: > > and now *many* users of qla2x00 and new-ish gcc are going to > > very much notice it, as their kernels will start crashing reliably. > > > > The commits can be reverted,

[PATCH 04/42] fs: have submit_bh users pass in op and flags separately

From: Mike Christie This has submit_bh users pass in the operation and flags separately, so submit_bh_wbc can setup bio->bi_op and bio-bi_rw on the bio that is submitted. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig

[PATCH 00/42] v7: separate operations from flags in the bio/request structs

point, we abused them so much we just made cmd_flags 64 bits, so we could add more. The following patches seperate the operation (read, write discard, flush, etc) from cmd_flags/bi_rw. This patchset was made against linux-next from today April 15 (git tag next-20160415). I put a git tree here:

[PATCH 01/42] block/fs/drivers: remove rw argument from submit_bio

From: Mike Christie This has callers of submit_bio/submit_bio_wait set the bio->bi_rw instead of passing it in. This makes that use the same as generic_make_request and how we set the other bio fields. v5: 1. Missed crypto fs submit_bio_wait call. v2: 1. Set bi_rw instead

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

, > flush, etc) from cmd_flags/bi_rw. > > This patchset was made against linux-next from today April 15 > (git tag next-20160415). > > I put a git tree here: > https://github.com/mikechristie/linux-kernel.git > The patches are in the op branch. > > v7: > 1. Fix broken feature_f

[PATCH 07/42] btrfs: have submit_one_bio users setup bio bi_op

From: Mike Christie This patch has btrfs's submit_one_bio callers set the bio->bi_op to a REQ_OP and the bi_rw to rq_flag_bits. The next patches will continue to convert btrfs, so submit_bio_hook and merge_bio_hook related code will be modified to take only the bio. I did

Re: [PATCH] mpt3sas: Remove usage of 'struct timeval'

> "Tina" == Tina Ruchandani writes: Tina> 'struct timeval' will have its tv_sec value overflow on 32-bit Tina> systems in year 2038 and beyond. This patch replaces the use of Tina> struct timeval for computing mpi_request.TimeStamp, and instead Tina> uses ktime_t

Re: [PATCH 0/4] megaraid_sas: Updates for scsi-next

> "Sumit" == Sumit Saxena writes: Sumit> This patchset has few small fixes/optimizations. Please consider Sumit> this for next release. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

[PATCH 10/42] btrfs: use bio fields for op and flags

From: Mike Christie The bio bi_op and bi_rw is now setup, so there is no need to pass around the rq_flag_bits bits too. btrfs users should should access the bio. v2: 1. Fix merge_bio issue where instead of removing rw/op argument I passed it in again to the merge_bio

[PATCH 11/42] f2fs: set bi_op to REQ_OP

From: Mike Christie This patch has f2fs use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- fs/f2fs/checkpoint.c|

[PATCH 14/42] hfsplus: set bi_op to REQ_OP

From: Mike Christie This patch has hfsplus use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- fs/hfsplus/hfsplus_fs.h |

[PATCH 21/42] bcache: set bi_op to REQ_OP

From: Mike Christie This patch has bcache use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- drivers/md/bcache/btree.c

[PATCH 16/42] nilfs: set bi_op to REQ_OP

From: Mike Christie This patch has nilfs use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- fs/nilfs2/segbuf.c | 18

[PATCH 23/42] md/raid: set bi_op to REQ_OP

From: Mike Christie This patch has md use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- drivers/md/bitmap.c | 2

[PATCH 22/42] drbd: set bi_op to REQ_OP

From: Mike Christie This patch has drbd use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Lars and Philip, I might have split this patch up a little weird. The block layer has compat so you can set either bi_rw or bi_op. This patch handles setting up the bio in

[PATCH 18/42] pm: set bi_op to REQ_OP

From: Mike Christie This patch has the pm code use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- kernel/power/swap.c |

[PATCH 08/42] btrfs: set bi_op tp REQ_OP

From: Mike Christie This patch has btrfs use the bio bi_op for REQ_OP and bi_rw for rq_flag_bits. v5: - Misset bi_rw to REQ_OP_WRITE in finish_parity_scrub Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes

[PATCH 15/42] mpage: set bi_op to REQ_OP

From: Mike Christie This patch has mpage.c use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- fs/mpage.c | 41

[PATCH 26/42] block: copy bio op to request op

From: Mike Christie The bio users should now always be setting up the bio->bi_op. This patch has us copy that to the struct request op field. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke

[PATCH 20/42] dm: pass dm stats data dir instead of bi_rw

From: Mike Christie It looks like dm stats cares about the data direction (READ vs WRITE) and does not need the bio/request flags. Commands like REQ_FLUSH, REQ_DISCARD and REQ_WRITE_SAME are currently always set with REQ_WRITE, so the extra check for REQ_DISCARD in

[PATCH 17/42] ocfs2: set bi_op to REQ_OP

From: Mike Christie This patch has ocfs2 use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- fs/ocfs2/cluster/heartbeat.c

[PATCH 13/42] xfs: set bi_op to REQ_OP

From: Mike Christie This patch has xfs use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Acked-by: Dave Chinner

[PATCH 12/42] gfs2: set bi_op to REQ_OP

From: Mike Christie This patch has gfs2 use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- fs/gfs2/log.c| 8

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

> "John" == John Garry writes: John, John> Could these also be applied to 4.6 fixes branch? Maybe I should John> have explicitly asked. Only taking critical patches for 4.6 at this point. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH] scsi_dh_alua: Declare local functions static

> "Bart" == Bart Van Assche writes: Bart> This patch avoids that building with W=1 causes gcc to report the Bart> following type of warning: Bart> no previous prototype for ... [-Wmissing-prototypes] Applied to 4.7/scsi-queue. -- Martin K. Petersen

RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

Chaitra, I think you are looking for the patch "mpt2sas: [Resend] Host Reset code cleanup". Joe, The initial drivers for SAS2 controller's handle firmware reset using the rescan barrier and later we redesigned it through the above patch. I hope it clarifies, please let us know if you are looking

Re: [PATCH 5/9] block: Implement support for zoned block devices

On 04/04/2016 03:00 AM, Hannes Reinecke wrote: +struct blk_zone *blk_lookup_zone(struct request_queue *q, sector_t lba) A similar comment applies to this function: does this function expect a sector_t or an LBA as its second argument? diff --git a/include/linux/blkdev.h

Re: [PATCH 8/9] block: Add 'BLK_MQ_RQ_QUEUE_DONE' return value

On 04/04/2016 03:00 AM, Hannes Reinecke wrote: Add a return value BLK_MQ_RQ_QUEUE_DONE to terminate a request without error. Hello Hannes, Are you sure it's OK not to update blk_mq_direct_issue_request()? Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH 8/9] block: Add 'BLK_MQ_RQ_QUEUE_DONE' return value

On 04/15/2016 07:56 PM, Bart Van Assche wrote: On 04/04/2016 03:00 AM, Hannes Reinecke wrote: Add a return value BLK_MQ_RQ_QUEUE_DONE to terminate a request without error. Hello Hannes, Are you sure it's OK not to update blk_mq_direct_issue_request()? Ah. Missed that one. Will be updating

Re: [PATCH 41/42] block: do not use REQ_FLUSH for tracking flush support

On 04/15/2016 05:50 AM, Juergen Gross wrote: > On 15/04/16 12:40, mchri...@redhat.com wrote: >> From: Mike Christie >> >> The last patch added a REQ_OP_FLUSH for request_fn drivers >> and the next patch renames REQ_FLUSH to REQ_PREFLUSH which >> will be used by file systems

RE: [PATCH] mpt3sas: fix possible NULL dereference

We need to do some more changes in this. The concept is first pool alloc and then memory alloc in the pool, so the memory has to be freed if the memory is allocated in the pool and irrespective of memory allocated or not the pool has to be destroyed if it is created. We will work internally and

RE: [PATCH] mpt3sas: Remove usage of 'struct timeval'

Hi, Please consider this patch as Ack-by: Sathya Prakash Thanks, Sathya -Original Message- From: mpt-fusionlinux@broadcom.com [mailto:mpt-fusionlinux@broadcom.com] On Behalf Of Martin K. Petersen Sent: Thursday, April 14, 2016 8:48 PM To: Tina

Re: [PATCH 3/9] sd: configure ZBC devices

On 04/15/2016 05:47 PM, Bart Van Assche wrote: On 04/04/2016 03:00 AM, Hannes Reinecke wrote: +static int +sd_zbc_report_zones(struct scsi_disk *sdkp, sector_t start_lba, +unsigned char *buffer, int bufflen ) +{ [ ... ] +put_unaligned_be64(start_lba, [2]); +

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

On Fri, 2016-04-15 at 20:56 +0200, Denys Vlasenko wrote: > On 04/15/2016 04:40 PM, James Bottomley wrote: > > On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: > > > More info here: > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 > > > > This bug is under investigation, so I'd

[PATCH 31/42] block: convert merge/insert code to check for REQ_OPs.

From: Mike Christie This patch converts the block layer merging code to use separate variables for the operation and flags, and to check request->op for the REQ_OP. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by:

[PATCH 25/42] target: set bi_op to REQ_OP

From: Mike Christie This patch has the target modules use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Acked-by: Nicholas

[PATCH 29/42] block: prepare elevator to use REQ_OPs.

From: Mike Christie This patch converts the elevator code to use separate variables for the operation and flags, and to check request->op for the REQ_OP. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes

Re: [PATCH 6/9] block: Add 'zoned' sysfs queue attribute

On 04/04/2016 03:00 AM, Hannes Reinecke wrote: Add a sysfs queue attribute 'zoned' to display the zone layout for zoned devices. Signed-off-by: Hannes Reinecke --- block/blk-sysfs.c | 47 +++ 1 file changed, 47 insertions(+) diff

Re: [PATCH 9/9] sd: Implement support for ZBC devices

On 04/04/2016 03:00 AM, Hannes Reinecke wrote: @@ -728,6 +729,10 @@ static int sd_setup_discard_cmnd(struct scsi_cmnd *cmd) int ret = 0; char *buf; struct page *page = NULL; +#ifdef CONFIG_SCSI_ZBC + struct blk_zone *zone; + unsigned long flags; +#endif

Re: [PATCH 6/9] block: Add 'zoned' sysfs queue attribute

On 04/15/2016 11:03 AM, Hannes Reinecke wrote: On 04/15/2016 07:45 PM, Bart Van Assche wrote: Additionally, have you considered to create one sysfs directory per zone instead of one sysfs attribute with all zone information? From Documentation/filesystems/sysfs.txt: "Attributes should be ASCII

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

On 04/15/2016 04:40 PM, James Bottomley wrote: > On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: >> More info here: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 > > This bug is under investigation, so I'd rather not alter code for a gcc > bug until we know if we can supply

[PATCH 06/42] direct-io: set bi_op to REQ_OP

From: Mike Christie This patch has the dio code set the bio bi_op to a REQ_OP and bio op_flags to rq_flag_bits. It also begins to convert btrfs's dio_submit_t because of the dio submit_io callout use. In the btrfs_submit_direct change, I OR'd the op and flag back together.

[PATCH 05/42] fs: have ll_rw_block users pass in op and flags separately

From: Mike Christie This has ll_rw_block users pass in the operation and flags separately, so ll_rw_block can setup bio->bi_op and bio-bi_rw on the bio that is submitted. v2: 1. Fix for kbuild error in ll_rw_block comments. Signed-off-by: Mike Christie

[PATCH 34/42] drivers: set request op to REQ_OP

From: Mike Christie This patch has the block drivers use the request->op for REQ_OP operations and cmd_flags for rq_flag_bits. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke ---

[PATCH 28/42] block: prepare mq request creation to use REQ_OPs

From: Mike Christie This patch modifies the blk mq request creation code to use separate variables for the operation and flags, because in the the next patches the struct request users will be converted like was done for bios. request->op will be used for the REQ_OP and

[PATCH 38/42] block, fs: remove old REQ definitions.

From: Mike Christie We no longer use REQ_WRITE. REQ_WRITE_SAME and REQ_DISCARD, so this patch removes them. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke ---

[PATCH 39/42] block: shrink bio/request fields

From: Mike Christie bi_op only needed to be a int for temp compat reasons, so this patch shrinks it to u8. There is no need for bi_rw to be so large now, so that is reduced to a unsigned int and bi_ioprio is just put in its own field. Signed-off-by: Mike Christie

[PATCH 37/42] block, fs, drivers: do use bi_rw/cmd_flags for REQ_OPs.

From: Mike Christie We no longer use the bio->bi_rw and request->cmd_flags field for REQ_OPs: REQ_WRITE, REQ_DISCARD, REQ_WRITE_SAME, so this patch stops checking for them in bi_rw/cmd_flags and also removes the related compat code. v2: 1. Remove compat code in

[PATCH 27/42] block: prepare request creation/destruction code to use REQ_OPs

From: Mike Christie This patch prepares *_get_request/*_put_request and freed_request, to use separate variables for the operation and flags. In the next patches the struct request users will be converted like was done for bios. request->op will be used for the REQ_OP and

[PATCH 30/42] blkg_rwstat: separate op from flags

From: Mike Christie The bio and request operation and flags are going to be separate definitions, so we cannot pass them in as a bitmap. This patch converts the blkg_rwstat code and its caller, cfq, to pass in the values separately. Signed-off-by: Mike Christie

[PATCH 35/42] blktrace: get op from req->op/bio->bi_op

From: Mike Christie The bio and request structs now store the operation in bio->bi_op/request->op. This patch has blktrace use that field instead of bi_rw/cmd_flags. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by:

[PATCH 33/42] block: convert rq_data_dir helper to use REQ_OPs

From: Mike Christie The request->op field is now always setup up with a REQ_OP. This patch has the rq_data_dir helper convert the operation to a WRITE or READ direction based on that. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig

[PATCH 36/42] ide cd: do not set REQ_WRITE on requests.

From: Mike Christie The block layer will set the correct READ/WRITE operation flags/fields when creating a request, so there is not need for drivers to set the REQ_WRITE flag. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig

[PATCH 32/42] block: convert is_sync helpers to use REQ_OPs.

From: Mike Christie This patch converts the is_sync helpers to use separate variables for the operation and flags. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke ---

[PATCH] mptsas: fix checks for dma mapping errors

mptsas_smp_handler() checks for dma mapping errors by comparison returned address with zero, while pci_dma_mapping_error() should be used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/message/fusion/mptsas.c

Re: [PATCH 0/3] hisi_sas: device id/IPTT collision workaround

> "John" == John Garry writes: John> This patchset introduces a workaround to a hw quirk in the John> HiSilicon SAS controller v2 hw. John> The quirk is as follows: When a SATA and SAS frame arrives at the John> host at the same time the frames may be swapped under

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

On Fri, Apr 15, 2016 at 08:47:45AM -0500, Josh Poimboeuf wrote: > On Fri, Apr 15, 2016 at 07:45:19AM +0200, Ingo Molnar wrote: > > > > * Denys Vlasenko wrote: > > > > > > In fact, the following patch seems to fix it: > > > > > > > > diff --git

Re: [-next] BUG_ON in scsi_target_destroy()

> "James" == James Bottomley writes: James> The STARGET_REMOVE state you added only applies to the case we're James> trying to kill a target. In the natural operation case, which is James> what everyone else is running into, we will try to remove a James> running

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

On Fri, 2016-04-15 at 23:09 +0200, Denys Vlasenko wrote: > On 04/15/2016 09:05 PM, James Bottomley wrote: > > On Fri, 2016-04-15 at 20:56 +0200, Denys Vlasenko wrote: > > > On 04/15/2016 04:40 PM, James Bottomley wrote: > > > > On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: > > > > >

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

On 04/15/2016 09:05 PM, James Bottomley wrote: > On Fri, 2016-04-15 at 20:56 +0200, Denys Vlasenko wrote: >> On 04/15/2016 04:40 PM, James Bottomley wrote: >>> On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: More info here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 >>>

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

On Fri, 2016-04-15 at 15:02 -0500, Josh Poimboeuf wrote: > On Fri, Apr 15, 2016 at 12:05:26PM -0700, James Bottomley wrote: > > On Fri, 2016-04-15 at 20:56 +0200, Denys Vlasenko wrote: > > > and now *many* users of qla2x00 and new-ish gcc are going to > > > very much notice it, as their kernels

Re: [PATCH 1/9] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

On 04/14/2016 09:09 PM, Bart Van Assche wrote: > On 04/04/2016 03:00 AM, Hannes Reinecke wrote: >> The queue limits already have a 'chunk_sectors' setting, so >> we should be presenting it via sysfs. > > This patch does more than exporting chunk_sectors via sysfs. It also > makes that parameter

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

On 15/04/2016 03:20, Martin K. Petersen wrote: "John" == John Garry writes: John> This patchset introduces SATA support fixes for the HiSilicon v2 John> hw SAS controller. John> Fixes include: - attach issue for SATA disk attached through John> expander - intermittent

Re: [PATCH 2/9] block: update chunk_sectors in blk_stack_limits()

On 04/15/2016 05:41 AM, Bart Van Assche wrote: > On 04/04/16 03:00, Hannes Reinecke wrote: >> diff --git a/block/blk-settings.c b/block/blk-settings.c >> index c7bb666..29fa900 100644 >> --- a/block/blk-settings.c >> +++ b/block/blk-settings.c >> @@ -630,6 +630,9 @@ int blk_stack_limits(struct

Re: [PATCH] mpt3sas: Remove usage of 'struct timeval'

On Mittwoch, 13. April 2016 00:01:40 CEST Tina Ruchandani wrote: > 'struct timeval' will have its tv_sec value overflow on 32-bit systems > in year 2038 and beyond. This patch replaces the use of struct timeval > for computing mpi_request.TimeStamp, and instead uses ktime_t which provides > 64-bit

[PATCH 2/4] megaraid_sas: call ISR function to clean up pending replies in OCR path

In OCR path, before calling chip reset calls function megasas_wait_for_outstanding_fusion to check reason of OCR. In case of firmware FAULT initiated OCR and DCMD timeout initiated timeout, driver will clear any outstanding reply(yet to be processed by driver) in reply queues before going for

[PATCH 4/4] megaraid_sas: driver version upgrade

Signed-off-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 1784b09..ca86c88 100644 ---

[PATCH 3/4] megaraid_sas: task management code optimizations

This patch will do code optmization for task management functions. Below are key changes- 1. Remove reset_device hook as it was not being used and driver was setting this to NULL. 2. Create wrapper functions for task abort and target reset and inside these functions adapter specific calls be

[PATCH 0/4] megaraid_sas: Updates for scsi-next

This patchset has few small fixes/optimizations. Please consider this for next release. Sumit Saxena (4): megaraid_sas: reduce memory footprints in kdump mode megaraid_sas: call ISR function to clean up pending replies in OCR path megaraid_sas: task management code optimizations

[PATCH 1/4] megaraid_sas: reduce memory footprints in kdump mode

This patch will reduce memory footprints of megaraid_sas driver when booted in kdump mode. Driver will not allocate memory for optional and perfromance oriented features. Below are key changes done in megaraid_sas driver to do this- 1. Limit Controller's queue depth to 100 in kdump mode. 2. Do

RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

Joe , The below mentioned patch is an older patch, verified latest code also the code before merging(mpt2sas & mpt3sas) didn't find changes of below patch. So I am searching for the patch which has removed the functionality/changes of the below patch. I shall get back to you on this by Monday.

[PATCH 35/42] blktrace: get op from req->op/bio->bi_op

From: Mike Christie The bio and request structs now store the operation in bio->bi_op/request->op. This patch has blktrace use that field instead of bi_rw/cmd_flags. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by:

[PATCH 38/42] block, fs: remove old REQ definitions.

From: Mike Christie We no longer use REQ_WRITE. REQ_WRITE_SAME and REQ_DISCARD, so this patch removes them. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke ---

[PATCH 36/42] ide cd: do not set REQ_WRITE on requests.

From: Mike Christie The block layer will set the correct READ/WRITE operation flags/fields when creating a request, so there is not need for drivers to set the REQ_WRITE flag. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig

[PATCH 33/42] block: convert rq_data_dir helper to use REQ_OPs

From: Mike Christie The request->op field is now always setup up with a REQ_OP. This patch has the rq_data_dir helper convert the operation to a WRITE or READ direction based on that. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig

  1   2   >