Re: [PATCH v6 3/3] ata: ATA Command Priority Disabled By Default

The 10/19/2016 14:38, Tejun Heo wrote: > Hello, > > Removed ata_ncq_prio_on() and renamed _on to _enable. If I messed up > anything, please let me know. > Works as expected. Thanks for cleaning this up. > Also, can you please send a follow-up patch to make the store function > reject prio

Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

On 2016-10-19 10:45, Vivek Gautam wrote: Hi, On Wed, Oct 19, 2016 at 1:43 AM, Subhash Jadavani wrote: On 2016-10-18 07:28, Vivek Gautam wrote: Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the

Re: [PATCH v3 04/11] blk-mq: Introduce blk_mq_quiesce_queue()

On 10/18/2016 02:50 PM, Bart Van Assche wrote: blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations have finished. This function does *not* wait until all outstanding requests have finished (this means invocation of request.end_io()). (replying to my own e-mail) The zero-day

Re: iscsi_trx going into D state

On Tue, 2016-10-18 at 16:13 -0600, Robert LeBlanc wrote: > Nicholas, > > We patched this in and for the first time in many reboots, we didn't > have iSCSI going straight into D state. We have had to work on a > couple of other things, so we don't know if this is just a coincidence > or not. We

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

On Tue 18-10-16 14:56:09, Lorenzo Stoakes wrote: > On Tue, Oct 18, 2016 at 02:54:25PM +0200, Jan Kara wrote: > > > @@ -1282,7 +1282,7 @@ long get_user_pages(unsigned long start, unsigned > > > long nr_pages, > > > int write, int force, struct page **pages, > > >

Re: Need some pointers to debug a target hang

On Tue, 2016-10-18 at 19:35 +0200, Johannes Thumshirn wrote: > On Tue, Oct 18, 2016 at 09:01:34AM +0200, Johannes Thumshirn wrote: > > [...] > > > > > > > This is likely the missing SCF_ACK_KREF assignment in >= v4.1.y: > > > > > > http://www.spinics.net/lists/target-devel/msg13530.html > >

Re: [RFC 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > This patch adds support for iscsiuio interface using Light L2 (LL2) qed > interface. > > Signed-off-by: Nilesh Javali > Signed-off-by: Adheer

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

On Wed 19-10-16 09:40:45, Lorenzo Stoakes wrote: > On Wed, Oct 19, 2016 at 10:13:52AM +0200, Michal Hocko wrote: > > On Wed 19-10-16 09:59:03, Jan Kara wrote: > > > On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > > > > This patch removes the write parameter from __access_remote_vm() and > > >

Re: [RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module > for 41000 Series Converged Network Adapters by QLogic. > > This patch consists of following changes: >

Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags

On Thu 13-10-16 01:20:16, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour (and hence > bugs)

Re: [PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags

On Thu 13-10-16 01:20:17, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages_remote() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and >

Re: [PATCH v3 0/11] Fix race conditions related to stopping block layer queues

Hi Bart, I'm running linux 4.9-rc1 + linux-block/for-linus, and alternating tests with and without this series. Without this, I'm not seeing any problems in a link-down test while running fio after ~30 runs. With this series, I only see the test pass infrequently. Most of the time I observe one

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

Thanks Hannes for the review. Please see my comments inline.. On Wed, 19 Oct 2016, 12:31am, Hannes Reinecke wrote: > On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > > From: Yuval Mintz > > > > This adds the backbone required for the various HW

Re: [PATCH v3 01/11] blk-mq: Do not invoke .queue_rq() for a stopped queue

On Wed, Oct 19, 2016 at 5:48 AM, Bart Van Assche wrote: > The meaning of the BLK_MQ_S_STOPPED flag is "do not call > .queue_rq()". Hence modify blk_mq_make_request() such that requests > are queued instead of issued if a queue has been stopped. > > Signed-off-by: Bart

Re: [PATCH v3 04/11] blk-mq: Introduce blk_mq_quiesce_queue()

On Thu, Oct 20, 2016 at 5:04 AM, Bart Van Assche wrote: > On 10/18/2016 02:50 PM, Bart Van Assche wrote: >> >> blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations >> have finished. This function does *not* wait until all outstanding >> requests have

Re: [PATCH v3 0/11] Fix race conditions related to stopping block layer queues

On 10/19/2016 03:14 PM, Keith Busch wrote: I'm running linux 4.9-rc1 + linux-block/for-linus, and alternating tests with and without this series. Without this, I'm not seeing any problems in a link-down test while running fio after ~30 runs. With this series, I only see the test pass

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

Thanks Johannes for the review, please see my response below. On Wed, 19 Oct 2016, 2:09am, Johannes Thumshirn wrote: > Hi Manish, > > Some initital comments > > On Wed, Oct 19, 2016 at 01:01:08AM -0400, manish.rangan...@cavium.com wrote: > > From: Yuval Mintz > > > >

Re: [RFC 2/6] qed: Add iSCSI out of order packet handling.

On Wed, 19 Oct 2016, 2:39am, Johannes Thumshirn wrote: > On Wed, Oct 19, 2016 at 01:01:09AM -0400, manish.rangan...@cavium.com wrote: > > From: Yuval Mintz > > > > This patch adds out of order packet handling for hardware offloaded > > iSCSI. Out of order packet handling

Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

On Thu, Oct 20, 2016 at 12:48 AM, Subhash Jadavani wrote: > On 2016-10-19 10:45, Vivek Gautam wrote: >> >> Hi, >> >> >> On Wed, Oct 19, 2016 at 1:43 AM, Subhash Jadavani >> wrote: >>> >>> On 2016-10-18 07:28, Vivek Gautam wrote:

Re: [PATCH v3 03/11] blk-mq: Introduce blk_mq_queue_stopped()

Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 09/11] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 10/11] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Device or HBA QD throttling creates holes in Sequential work load

Hi, I am doing some performance tuning in MR driver to understand how sdev queue depth and hba queue depth play role in IO submission from above layer. I have 24 JBOD connected to MR 12GB controller and I can see performance for 4K Sequential work load as below. HBA QD for MR controller is 4065

Re: [RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

On Wed, Oct 19, 2016 at 01:01:10AM -0400, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module > for 41000 Series Converged Network Adapters by QLogic. > > This patch consists of

Re: [RFC 2/6] qed: Add iSCSI out of order packet handling.

On Wed, Oct 19, 2016 at 01:01:09AM -0400, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This patch adds out of order packet handling for hardware offloaded > iSCSI. Out of order packet handling requires driver buffer allocation > and assistance. > >

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

On Wed, Oct 19, 2016 at 10:13:52AM +0200, Michal Hocko wrote: > On Wed 19-10-16 09:59:03, Jan Kara wrote: > > On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > > > This patch removes the write parameter from __access_remote_vm() and > > > replaces it > > > with a gup_flags parameter as use of

Re: [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped()

On 10/19/2016 06:19 AM, Christoph Hellwig wrote: On Tue, Oct 18, 2016 at 02:49:09PM -0700, Bart Van Assche wrote: Multiple functions test the BLK_MQ_S_STOPPED bit so introduce a helper function that performs this test. Looks sensible. Any reason to have it in the public blk-mq.h instead of

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

On Wed 19-10-16 10:06:46, Lorenzo Stoakes wrote: > On Wed, Oct 19, 2016 at 10:52:05AM +0200, Michal Hocko wrote: > > yes this is the desirable and expected behavior. > > > > > wonder if this is desirable behaviour or whether this ought to be limited > > > to > > > ptrace system calls. Regardless,

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: > I am wondering whether we can go further. E.g. it is not really clear to > me whether we need an explicit FOLL_REMOTE when we can in fact check > mm != current->mm and imply that. Maybe there are some contexts which > wouldn't work, I

Re: [PATCH v3 05/11] blk-mq: Add a kick_requeue_list argument to blk_mq_requeue_request()

On Tue, Oct 18, 2016 at 02:51:02PM -0700, Bart Van Assche wrote: > Most blk_mq_requeue_request() and blk_mq_add_to_requeue_list() calls > are followed by kicking the requeue list. Hence add an argument to > these two functions that allows to kick the requeue list. This was > proposed by Christoph

Re: [PATCH v3 04/11] blk-mq: Introduce blk_mq_quiesce_queue()

> +/** > + * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have > finished > + * > + * Note: this function does not prevent that the struct request end_io() > + * callback function is invoked. Additionally, it is not prevented that > + * new queue_rq() calls occur unless the

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

Shaun Tancheff writes: > On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer wrote: >> Damien Le Moal writes: >> >>> + if (!is_power_of_2(zone_blocks)) { >>> + if (sdkp->first_scan) >>> +

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

"Martin K. Petersen" writes: >> "Jeff" == Jeff Moyer writes: > > Jeff, > > Jeff> Are power of 2 zone sizes required by the standard? I see why > Jeff> you've done this, but I wonder if we're artificially limiting the > Jeff> implementation,

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

On Wed, Oct 19, 2016 at 10:52:05AM +0200, Michal Hocko wrote: > yes this is the desirable and expected behavior. > > > wonder if this is desirable behaviour or whether this ought to be limited to > > ptrace system calls. Regardless, by making the flag more visible it makes it > > easier to see

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages_locked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and >

Re: [PATCH v3 07/11] dm: Fix a race condition related to stopping and starting queues

Looks good: Reviewed-by: Christoph Hellwig FYI, I wonder how many of the blk_mq_stop_hw_queues do not need the quiesce call. In the long run it might be better to have blk_mq_stop_hw_queues to stop an quiesce, and have a __blk_mq_stop_hw_queues variant to just stop. -- To

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > This patch removes the write parameter from __access_remote_vm() and replaces > it > with a gup_flags parameter as use of this function previously _implied_ > FOLL_FORCE, whereas after this patch callers explicitly pass this flag. > > We make

Re: [RFC 5/6] qedi: Add support for iSCSI session management.

On Wed, Oct 19, 2016 at 01:01:12AM -0400, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > This patch adds support for iscsi_transport LLD Login, > Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing > and Firmware async event handling support. > >

Re: [PATCH v3 06/11] dm: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

This looks good: Reviewed-by: Christoph Hellwig On Tue, Oct 18, 2016 at 02:51:33PM -0700, Bart Van Assche wrote: > static void dm_mq_start_queue(struct request_queue *q) > { > - unsigned long flags; > - > - spin_lock_irqsave(q->queue_lock, flags); > -

[Bug 178381] New: Suspend to RAM test failed while CONFIG_SCSI_MQ_DEFAULT is set

https://bugzilla.kernel.org/show_bug.cgi?id=178381 Bug ID: 178381 Summary: Suspend to RAM test failed while CONFIG_SCSI_MQ_DEFAULT is set Product: SCSI Drivers Version: 2.5 Kernel Version: 4.8.2 Hardware: x86-64

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This adds the backbone required for the various HW initalizations > which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ > 4 line of adapters - FW notification, resource

Re: [RFC 6/6] qedi: Add support for data path.

On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > This patch adds support for data path and TMF handling. > > Signed-off-by: Nilesh Javali > Signed-off-by: Adheer Chandravanshi

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

On Wed 19-10-16 09:58:15, Lorenzo Stoakes wrote: > On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: > > I am wondering whether we can go further. E.g. it is not really clear to > > me whether we need an explicit FOLL_REMOTE when we can in fact check > > mm != current->mm and imply

Re: [PATCH v3 08/11] SRP transport: Move queuecommand() wait code to SCSI core

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/20] libfc: Replace ->rport_logoff callback with function call

On Tue, 18 Oct 2016, 8:01am -, Hannes Reinecke wrote: > The ->rport_logoff callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/bnx2fc/bnx2fc_tgt.c | 3 +-- >

Re: [RFC 2/6] qed: Add iSCSI out of order packet handling.

On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This patch adds out of order packet handling for hardware offloaded > iSCSI. Out of order packet handling requires driver buffer allocation > and assistance. > > Signed-off-by: Arun Easi

Re: [PATCH 13/20] libfc: Remove fc_rport_init()

On Tue, 18 Oct 2016, 8:01am -, Hannes Reinecke wrote: > Function is empty now and can be removed. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 1 - > drivers/scsi/fcoe/fcoe_ctlr.c | 1 - > drivers/scsi/libfc/fc_rport.c | 10

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

On 10/19/2016 02:07 AM, Michal Hocko wrote: > On Wed 19-10-16 09:58:15, Lorenzo Stoakes wrote: >> On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: >>> I am wondering whether we can go further. E.g. it is not really clear to >>> me whether we need an explicit FOLL_REMOTE when we can in

Re: [PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags

On Thu 13-10-16 01:20:15, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_vaddr_frames() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour (and hence >

Re: [PATCH v3 04/11] blk-mq: Introduce blk_mq_quiesce_queue()

On 10/19/2016 06:23 AM, Christoph Hellwig wrote: +/** + * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have finished + * + * Note: this function does not prevent that the struct request end_io() + * callback function is invoked. Additionally, it is not prevented that + * new

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

Hi Tomas, SCSI command checking in queuecommand function of arcmsr can be removed safely. Now driver can pass all scsi command to controller firmware. diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2016-10-19

Re: iscsi_trx going into D state

Nicholas, I didn't have high hopes for the patch because we were not seeing TMR_ABORT_TASK (or 'abort') in dmesg or /var/log/messages, but it seemed to help regardless. Our clients finally OOMed from the hung sessions, so we are having to reboot them and we will do some more testing. We haven't

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

On Wed 19-10-16 09:49:43, Dave Hansen wrote: > On 10/19/2016 02:07 AM, Michal Hocko wrote: > > On Wed 19-10-16 09:58:15, Lorenzo Stoakes wrote: > >> On Tue, Oct 18, 2016 at 05:30:50PM +0200, Michal Hocko wrote: > >>> I am wondering whether we can go further. E.g. it is not really clear to > >>> me

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

On 19.10.2016 11:50, Ching Huang wrote: > Hi Tomas, > > SCSI command checking in queuecommand function of arcmsr can be removed > safely. > Now driver can pass all scsi command to controller firmware. thanks for your quick reply. Is this (passing the SYNCHRONIZE_CACHE command to firmware) safe

Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

Hi, On Wed, Oct 19, 2016 at 2:48 AM, Stephen Boyd wrote: > On 10/18/2016 07:28 AM, Vivek Gautam wrote: >> From: Yaniv Gardi >> >> Since in future UFS Phy's the tx_iface_clk and rx_iface_clk >> are no longer exist, we should not fail when their

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

On 10/19/2016 10:01 AM, Michal Hocko wrote: > The question I had earlier was whether this has to be an explicit FOLL > flag used by g-u-p users or we can just use it internally when mm != > current->mm The reason I chose not to do that was that deferred work gets run under a basically random

[PATCH RFC] fcping: allow pings using FC_BSG_RPT_ELS

fcping uses FC-ELS to perform pings. FC ELS is a host as well as rport service, so allow the rport version of the BSG ioctl() as well as the host version. Signed-off-by: Johannes Thumshirn --- fcping.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-)

Re: [PATCH v6 1/3] block: Add iocontext priority to request

Hello, On Mon, Oct 17, 2016 at 11:27:28AM -0700, Adam Manzanares wrote: > Patch adds an association between iocontext ioprio and the ioprio of a > request. This is done to enable request based drivers the ability to > act on priority information stored in the request. An example being > ATA

Re: [PATCH v6 1/3] block: Add iocontext priority to request

On 10/19/2016 12:05 PM, Tejun Heo wrote: Hello, On Mon, Oct 17, 2016 at 11:27:28AM -0700, Adam Manzanares wrote: Patch adds an association between iocontext ioprio and the ioprio of a request. This is done to enable request based drivers the ability to act on priority information stored in the

Re: [PATCH v6 3/3] ata: ATA Command Priority Disabled By Default

The 10/19/2016 14:05, Tejun Heo wrote: > On Mon, Oct 17, 2016 at 11:27:30AM -0700, Adam Manzanares wrote: > > Add a sysfs entry to turn on priority information being passed > > to a ATA device. By default this feature is turned off. > > > > This patch depends on ata: Enabling ATA Command

Re: [PATCH v6 3/3] ata: ATA Command Priority Disabled By Default

On Mon, Oct 17, 2016 at 11:27:30AM -0700, Adam Manzanares wrote: > Add a sysfs entry to turn on priority information being passed > to a ATA device. By default this feature is turned off. > > This patch depends on ata: Enabling ATA Command Priorities > > Signed-off-by: Adam Manzanares

Re: [PATCH v6 2/3] ata: Enabling ATA Command Priorities

Hello, I removed ata_ncq_prio_enabled() as it was colliding with the sysfs file rename and these trivial test functions tend to obscure more than help anything. Thanks. -- 8< -- >From 8e061784b51ec4a4efed0deaafb5bd9725bf5b06 Mon Sep 17 00:00:00 2001 From: Adam Manzanares

Re: [PATCH v6 3/3] ata: ATA Command Priority Disabled By Default

Hello, Removed ata_ncq_prio_on() and renamed _on to _enable. If I messed up anything, please let me know. Also, can you please send a follow-up patch to make the store function reject prio enabling if the device doesn't support it? Thanks. -- 8< -- >From

Re: [PATCH v6 0/3] Enabling ATA Command Priorities

On Mon, Oct 17, 2016 at 11:27:27AM -0700, Adam Manzanares wrote: > This patch builds ATA commands with high priority if the iocontext of a > process > is set to real time. The goal of the patch is to improve tail latencies of > workloads that use higher queue depths. This requires setting the

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

Hi Tomas, > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Wednesday, October 19, 2016 5:56 AM > To: Ching Huang > Cc: James Bottomley; Kashyap Desai; Ric Wheeler; Hannes Reinecke; Sumit > Saxena; linux-scsi@vger.kernel.org; martin.peter...@oracle.com; Christoph

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

On Wed 19-10-16 09:59:03, Jan Kara wrote: > On Thu 13-10-16 01:20:18, Lorenzo Stoakes wrote: > > This patch removes the write parameter from __access_remote_vm() and > > replaces it > > with a gup_flags parameter as use of this function previously _implied_ > > FOLL_FORCE, whereas after this

Re: [RFC 5/6] qedi: Add support for iSCSI session management.

On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: > From: Manish Rangankar > > This patch adds support for iscsi_transport LLD Login, > Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing > and Firmware async event handling support. > > Signed-off-by:

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

Hi Manish, Some initital comments On Wed, Oct 19, 2016 at 01:01:08AM -0400, manish.rangan...@cavium.com wrote: > From: Yuval Mintz > > This adds the backbone required for the various HW initalizations > which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ

Re: [PATCH v3 11/11] nvme: Fix a race condition

Hi Bart, this looks great! Reviewed-by: Christoph Hellwig Some minor nitpicks below: > void nvme_requeue_req(struct request *req) > { > + blk_mq_requeue_request(req, true); > } > EXPORT_SYMBOL_GPL(nvme_requeue_req); Please just remove the nvme_requeue_req wrapper. > >

Re: [PATCH v3 01/11] blk-mq: Do not invoke .queue_rq() for a stopped queue

Good catch, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped()

On Tue, Oct 18, 2016 at 02:49:09PM -0700, Bart Van Assche wrote: > Multiple functions test the BLK_MQ_S_STOPPED bit so introduce > a helper function that performs this test. Looks sensible. Any reason to have it in the public blk-mq.h instead of the private one, though? I see that dm is using

Re: [PATCH 00/20] libfc callback cleanup

On Tue, 18 Oct 2016, 8:01am -, Hannes Reinecke wrote: > Hi all, > > it has been bugging me for a while that libfc has tons of callbacks > in an attempt to abstract things away. But as it turned out > no-one ever used those, rendering them quite pointless. > As I got some time to kill on the

Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

Hi, On Wed, Oct 19, 2016 at 1:43 AM, Subhash Jadavani wrote: > On 2016-10-18 07:28, Vivek Gautam wrote: >> >> Add phy clock enable code to phy_power_on/off callbacks, and >> remove explicit calls to enable these phy clocks from the >> ufs-qcom hcd driver. >> >>