[GIT PULL] target fixes for v4.10

2017-02-09 Thread Nicholas A. Bellinger
Hello Linus, The following target series for v4.10 contains fixes which address a few long-standing bugs that DATERA's QA + automation teams have uncovered while putting v4.1.y target code into production usage. We've been running the top three in our nightly automated regression runs for the

Re: [PATCH v2 10/14] qla2xxx: Fix request queue corruption.

2017-02-09 Thread Tran, Quinn
Bart, thanks for reviewing. Will clean it up. Regards, Quinn Tran -Original Message- From: on behalf of Bart Van Assche Date: Wednesday, February 8, 2017 at 11:22 AM To: "h...@infradead.org" , "Madhani,

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

2017-02-09 Thread ojab
On 2017/02/09 05:09, Sreekanth Reddy wrote: On Wed, Dec 28, 2016 at 4:35 PM, ojab wrote: MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled. Signed-off-by: Slava Kardakov Fixes:

Re: [PATCH v4] scsi/sd: release scan_mutex during sync_cache and start_stop

2017-02-09 Thread Christoph Hellwig
And what is the lock protecting if we can just release and reacquire it safely? Probably nothing, but someone needs to do the audit carefully. Once that is done we can just apply a patch like the one below and be done with it: --- >From 47572d7f0758cc0cbd979b1a2c3791f3b94c566e Mon Sep 17

Re: [PATCH v2 21/39] megaraid_sas: big endian support changes

2017-02-09 Thread Martin K. Petersen
> "Kashyap" == Kashyap Desai writes: Kashyap, Kashyap> We will fix this patch and resend. Only fixing this patch and Kashyap> resend works fine with complete series (there is no hunk Kashyap> failure observe), so just going to push one particular patch Kashyap>

Re: [PATCH] zfcp: fix use-after-free by not tracing WKA port open/close on failed send

2017-02-09 Thread Martin K. Petersen
> "Steffen" == Steffen Maier writes: Steffen> Rather than relying on req being NULL (or ERR_PTR) for all Steffen> cases where we don't want to trace or should not trace, simply Steffen> check retval which is unconditionally initialized with -EIO != Steffen> 0 and it

Re: [PATCH -next] scsi: qedi: Fix possible memory leak in qedi_iscsi_update_conn()

2017-02-09 Thread Martin K. Petersen
> "Wei" == Wei Yongjun writes: Wei> 'conn_info' is malloced in qedi_iscsi_update_conn() and should be Wei> freed before leaving from the error handling cases, otherwise it Wei> will cause memory leak. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH v4] scsi/sd: release scan_mutex during sync_cache and start_stop

2017-02-09 Thread Song Liu
Hi Christoph, IMHO, scan_mutex maybe still needed for other part of scsi_remove_device(). For example, device_del() in sd_remove() and scsi_sysfs_add_devices() in scsi_finish_async_scan() should not run in parallel? On the other hand, other parts of sd_remove(), including sd_shutdown(),

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

2017-02-09 Thread Martin K. Petersen
> "ojab" == ojab writes: >> Acked-by: Sreekanth Reddy Applied to 4.10/scsi-fixes. ojab> Is it too late for 4.10.0? We'll see. Worst case I'll shuffle it over to the 4.11 tree. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] aacraid: Fix INTx/MSI-x issue with older controllers

2017-02-09 Thread Martin K. Petersen
> "Dave" == Dave Carroll writes: Dave> commit 78cbccd3bd683 ("[PATCH] aacraid: Fix for KDUMP driver Dave> hang") caused a problem on older controllers which do not support Dave> MSI-x (namely ASR3405,ASR3805). This patch conditionalizes the Dave> previous patch

Re: [PATCH v2 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-09 Thread Martin K. Petersen
> "Shivasharan" == Shivasharan S > writes: Shivasharan> fix in v2 - split patches into two. discussed below Shivasharan> http://marc.info/?l=linux-scsi=148638999110404=2 ^^^ Comments like this need to go after the "---" separator so they don't

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

2017-02-09 Thread Dan Williams
On Wed, Feb 8, 2017 at 4:08 PM, James Bottomley wrote: > On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote: [..] >> ...but it reproduces on current mainline with the same config. I >> haven't spotted what makes scsi_debug behave like this. > > Looking at

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Sreekanth Reddy
On Thu, Feb 9, 2017 at 6:42 PM, Hannes Reinecke wrote: > On 02/09/2017 02:03 PM, Sreekanth Reddy wrote: >> On Wed, Feb 1, 2017 at 1:13 PM, Hannes Reinecke wrote: >>> >>> On 02/01/2017 08:07 AM, Kashyap Desai wrote: > > -Original Message- > From:

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Hannes Reinecke
On 02/10/2017 05:43 AM, Sreekanth Reddy wrote: > On Thu, Feb 9, 2017 at 6:42 PM, Hannes Reinecke wrote: >> On 02/09/2017 02:03 PM, Sreekanth Reddy wrote: [ .. ] >>> >>> >>> Hannes, >>> >>> I have created a md raid0 with 4 SAS SSD drives using below command, >>> #mdadm --create

Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-09 Thread Tomas Henzl
On 8.2.2017 19:51, Kashyap Desai wrote: >>> +static inline void >>> +megasas_complete_r1_command(struct megasas_instance *instance, >>> + struct megasas_cmd_fusion *cmd) { >>> + u8 *sense, status, ex_status; >>> + u32 data_length; >>> + u16 peer_smid; >>> + struct

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Hannes Reinecke
On 02/09/2017 02:03 PM, Sreekanth Reddy wrote: > On Wed, Feb 1, 2017 at 1:13 PM, Hannes Reinecke wrote: >> >> On 02/01/2017 08:07 AM, Kashyap Desai wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Wednesday, February 01, 2017

Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-09 Thread Tomas Henzl
On 8.2.2017 10:28, Shivasharan S wrote: > fix in v2 - ex_status and status was wrongly re-used in > megasas_complete_r1_command. > discussed below - > http://marc.info/?l=linux-scsi=148638763409385=2 > > > No functional change. Code refactor. > Remove function megasas_fpio_to_ldio as we never

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-09 Thread Kalle Valo
Florian Fainelli writes: >>> If not, for something like this it's a must: >>> >>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ >>> before ‘bool’ >>> module_param(disable_ap_sme, bool, 0444); >>> ^ >>>

Re: [PATCH 00/10] mpt3sas: full mq support

2017-02-09 Thread Sreekanth Reddy
On Wed, Feb 1, 2017 at 1:13 PM, Hannes Reinecke wrote: > > On 02/01/2017 08:07 AM, Kashyap Desai wrote: >>> >>> -Original Message- >>> From: Hannes Reinecke [mailto:h...@suse.de] >>> Sent: Wednesday, February 01, 2017 12:21 PM >>> To: Kashyap Desai; Christoph Hellwig >>> Cc:

RE: [PATCH v2 19/39] megaraid_sas: MR_TargetIdToLdGet u8 to u16 and avoid invalid raid-map access

2017-02-09 Thread Kashyap Desai
> Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai In this patch series, we are done with review but this particular patch missed Review-by tag. Kashyap

[PATCH] aacraid: Fix INTx/MSI-x issue with older controllers

2017-02-09 Thread Dave Carroll
commit 78cbccd3bd683 ("[PATCH] aacraid: Fix for KDUMP driver hang") caused a problem on older controllers which do not support MSI-x (namely ASR3405,ASR3805). This patch conditionalizes the previous patch to controllers which support MSI-x cc: sta...@vger.kernel.org Fixes:

RE: [PATCH v2 21/39] megaraid_sas: big endian support changes

2017-02-09 Thread Kashyap Desai
> +static inline void set_num_sge(struct RAID_CONTEXT_G35 rctx_g35, > +u16 sge_count) > +{ > + rctx_g35.u.bytes[0] = (u8)(sge_count & NUM_SGE_MASK_LOWER); > + rctx_g35.u.bytes[1] |= (u8)((sge_count >> NUM_SGE_SHIFT_UPPER) > +