RE: [PATCH v2 02/10] be2iscsi: Fix closing of connection

> > + attempts = 0; > > + while (attempts++ < 3) { > > + tag = beiscsi_invalidate_cxn(phba, beiscsi_ep); > > + if (tag) { > > + ret = beiscsi_mccq_compl_wait(phba, tag, NULL, > NULL); > > + if (!ret) > > + break;

[PATCH v3 09/10] be2iscsi: Update Copyright

Update Broadcom Copyright markings in all files. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be.h | 11 --- drivers/scsi/be2iscsi/be_cmds.c | 11 --- drivers/scsi/be2iscsi/be_cmds.h | 11 ---

[PATCH v3 05/10] be2iscsi: Increase HDQ default queue size

Currently, ASYNC PDU default queue size is set to max connections. This leaves only one buffer per connection for any ASYNC PDUs from targets. Double the size of the default queue. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 29

[PATCH v3 06/10] be2iscsi: Use num_cons field in Rx CQE

FW runs out of buffer if buffers are not posted back soon. ASYNC Rx CQE indicates that FW has consumed 8 RQEs. Use it to post back buffers instead of waiting for buffers to be processed and freed by driver. Signed-off-by: Jitendra Bhivare ---

[PATCH v3 02/10] be2iscsi: Fix closing of connection

CID needs to be freed even when invalidate or upload connection fails. Attempt to close connection 3 times before freeing CID. Set cleanup_type to INVALIDATE instead of force TCP_RST. This unnecessarily is terminating connection with reset instead of gracefully closing it. Set save_cfg to 0 -

[PATCH v3 01/10] be2iscsi: Check tag in beiscsi_mccq_compl_wait

scsi host12: BS_1377 : mgmt_invalidate_connection Failed for cid=256 BUG: unable to handle kernel NULL pointer dereference at 0008 IP: [] __list_add+0xf/0xc0 PGD 0 Oops: [#1] SMP Modules linked in: ... CPU: 9 PID: 1542 Comm: iscsid Tainted: G T

[PATCH v3 00/10] be2iscsi: driver update 11.4.0.0

This patch is generated against for-next branch. v3 changes: be2iscsi: Fix closing of connection - Fixed per Tomas's review comments. v2 changes: +be2iscsi: Update Copyright Jitendra Bhivare (10): be2iscsi: Check tag in beiscsi_mccq_compl_wait be2iscsi: Fix closing of connection

[PATCH v3 08/10] be2iscsi: Check size before copying ASYNC handle

Data in buffers are gathered into a single buffer before giving to iSCSI layer. Though less likely to have payload more than 8K in ASYNC PDU, the data length is provide by FW and check is missing for overrun. Signed-off-by: Jitendra Bhivare ---

[PATCH v3 07/10] be2iscsi: Remove free_list for ASYNC handles

With previous patch adding ASYNC Rx buffers to free_list is not required. Remove all free_list related operations. Add in_use to track if buffer posted is being processed by driver and purge all buffers received for connection if found so. Signed-off-by: Jitendra Bhivare

[PATCH v3 04/10] scsi_transport_iscsi: Use flush_work in iscsi_remove_session

scsi_flush_work flushes workqueue for the Scsi_Host. In iSCSI offload enabled host, this would wait for all other sessions under the host. Use flush_work for the session being removed instead. Signed-off-by: Jitendra Bhivare ---

[PATCH v3 03/10] be2iscsi: Replace spin_unlock_bh with spin_lock

spin_unlock_bh back_lock is used in beiscsi_eh_device_reset instead of spin_lock. Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 10/10] be2iscsi: Update driver version

Version 11.4.0.0 Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index c6b95dc..ee18a95 100644 ---

[PATCH] MAINTAINERS: remove pmchba list for PM8001

From: Jack Wang The email address is undeliverable for some time now, so just remove it. Signed-off-by: Jack Wang --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 12a528a..e3e61c5

Re: [PATCH v3 02/10] be2iscsi: Fix closing of connection

On 24.3.2017 09:41, Jitendra Bhivare wrote: > CID needs to be freed even when invalidate or upload connection fails. > Attempt to close connection 3 times before freeing CID. > > Set cleanup_type to INVALIDATE instead of force TCP_RST. > This unnecessarily is terminating connection with reset

Re: [PATCH v2] libsas: fix "sysfs group not found" warnings at port teardown time

[ +Cc Tejun ] On Fri, Mar 24, 2017 at 11:44:55AM +, John Garry wrote: > To be clear, was this the same test with isci which you initially reported? Yes, just echo into the PCI device's sysfs remove file and it'll trigger the problem. I did some archeology and it seems as if commit bcdde7e

Re: [PATCH v3 07/10] be2iscsi: Remove free_list for ASYNC handles

On 24.3.2017 09:41, Jitendra Bhivare wrote: > With previous patch adding ASYNC Rx buffers to free_list is not required. > Remove all free_list related operations. > > Add in_use to track if buffer posted is being processed by driver and > purge all buffers received for connection if found so. > >

Re: [PATCH v3 08/10] be2iscsi: Check size before copying ASYNC handle

On 24.3.2017 09:41, Jitendra Bhivare wrote: > Data in buffers are gathered into a single buffer before giving to > iSCSI layer. Though less likely to have payload more than 8K in > ASYNC PDU, the data length is provide by FW and check is missing > for overrun. > > Signed-off-by: Jitendra Bhivare

Re: [PATCH v3 10/10] be2iscsi: Update driver version

On 24.3.2017 09:41, Jitendra Bhivare wrote: > Version 11.4.0.0 > > Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v3 06/10] be2iscsi: Use num_cons field in Rx CQE

On 24.3.2017 09:41, Jitendra Bhivare wrote: > FW runs out of buffer if buffers are not posted back soon. > ASYNC Rx CQE indicates that FW has consumed 8 RQEs. > Use it to post back buffers instead of waiting for buffers > to be processed and freed by driver. > > Signed-off-by: Jitendra Bhivare

Re: [PATCH v3 00/10] be2iscsi: driver update 11.4.0.0

This series looks good to me. Reviewed-by: Chris Leech On Fri, Mar 24, 2017 at 02:11:39PM +0530, Jitendra Bhivare wrote: > This patch is generated against for-next branch. > > v3 changes: > be2iscsi: Fix closing of connection > - Fixed per Tomas's review comments. >

Re: [PATCH v3 04/10] scsi_transport_iscsi: Use flush_work in iscsi_remove_session

On 24.3.2017 09:41, Jitendra Bhivare wrote: > scsi_flush_work flushes workqueue for the Scsi_Host. > In iSCSI offload enabled host, this would wait for all other > sessions under the host. > > Use flush_work for the session being removed instead. > > Signed-off-by: Jitendra Bhivare

Re: [PATCH v3 05/10] be2iscsi: Increase HDQ default queue size

On 24.3.2017 09:41, Jitendra Bhivare wrote: > Currently, ASYNC PDU default queue size is set to max connections. > This leaves only one buffer per connection for any ASYNC PDUs from > targets. > > Double the size of the default queue. > > Signed-off-by: Jitendra Bhivare

Re: iscsi (?): Unknown VPD Code: 0xc7

On 03/24/2017 09:16 PM, Xose Vazquez Perez wrote: > Try to add "scsi_dev_flags=AIX:VDASD:0x1000" to the kernel > command line in grub. # echo "AIX:VDASD:0x1000" > /proc/scsi/device_info should also work.

Re: iscsi (?): Unknown VPD Code: 0xc7

Harald Dunkel wrote: > I am trying to use LIO on amd64 to provide block devices to some > AIX 6.1 and 7.1 hosts. It works pretty well, except that I cannot > create rootvg wpars on AIX 7.1. (rootvg wpars are containers > running on their own volume group.) > > The error message on AIX is > >

Re: [PATCH v6 06/15] mlx5: Replace PCI pool old API

On Mon, 2017-03-20 at 08:31 +0200, Leon Romanovsky wrote: > On Sun, Mar 19, 2017 at 06:03:55PM +0100, Romain Perier wrote: > > > > The PCI pool API is deprecated. This commit replaces the PCI pool > > old > > API by the appropriate function with the DMA pool API. > > > > Signed-off-by: Romain

Re: [PATCH v6 03/15] IB/mthca: Replace PCI pool old API

On Sun, 2017-03-19 at 18:03 +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Acked-by: Peter Senna Tschudin

Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

On 2017-03-21 05:19, Jaehoon Chung wrote: There are same conditions for checking whether supporting clkscaling or not. When ufshcd is supporting clkscaling, active_reqs should be decreased by two. Signed-off-by: Jaehoon Chung --- drivers/scsi/ufs/ufshcd.c | 2 -- 1

Re: [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments

On 2017-03-23 03:49, kusumi.tomoh...@gmail.com wrote: From: Tomohiro Kusumi These aren't really falling through to anywhere meaningful. Signed-off-by: Tomohiro Kusumi --- drivers/scsi/ufs/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2