[PATCH v3] sd: Ignore sync cache failures when not supported

2017-05-09 Thread Thierry Escande
From: Derek Basehore Some external hard drives don't support the sync command even though the hard drive has write cache enabled. In this case, upon suspend request, sync cache failures are ignored if the error code in the sense header is ILLEGAL_REQUEST. There's not much

[PATCH v1] ibmvscsis: Fix cleaning up pointers

2017-05-09 Thread Bryant G. Ly
This patch is dependent on: 'commit 25e78531268e ("ibmvscsis: Do not send aborted task response")' This patch cleans up some pointers after usage. Signed-off-by: Bryant G. Ly Reviewed-by: Michael Cyr Cc: # v4.8+

Re: [PATCH 25/27] block: remove the discard_zeroes_data flag

2017-05-09 Thread Nicholas A. Bellinger
On Sun, 2017-05-07 at 11:22 +0200, h...@lst.de wrote: > On Tue, May 02, 2017 at 08:33:15PM -0700, Nicholas A. Bellinger wrote: > > The larger target/iblock conversion patch looks like post v4.12 material > > at this point, so to avoid breakage wrt to existing LBPRZ behavior, I'll > > plan to push

Re: [PATCH v3] sd: Ignore sync cache failures when not supported

2017-05-09 Thread Ewan D. Milne
On Tue, 2017-05-09 at 17:43 +0200, Thierry Escande wrote: > From: Derek Basehore > > Some external hard drives don't support the sync command even though the > hard drive has write cache enabled. In this case, upon suspend request, > sync cache failures are ignored if the

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-09 Thread Martin K. Petersen
Chad, > To be honest, I'm reluctant to merge these patches on bnx2fc as the > I/O path on this driver has been stable for quite some time and given > that it's an older driver I'm not looking to make changes there. I understand that the driver is in maintenance mode. However, the Linux kernel

[PATCH] target: remove dead code

2017-05-09 Thread Gustavo A. R. Silva
Local variable _ret_ is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 140761 Signed-off-by: Gustavo A. R. Silva --- drivers/target/target_core_rd.c | 4 ++-- 1 file changed, 2

A bug in scsi_alloc_target of drivers/scsi/scsi_scan.c

2017-05-09 Thread Dashi DS1 Cao
When debugging a race condition in scsi_remove_target of 3.12, I ran into this possible bug within scsi_alloc_target. When an existing "struct scsi_target" is found and used, the starget just got through kzmalloc should be freed, rather than dong a "put_device(dev)". diff --git

Re: [PATCH v1] ibmvscsis: Fix cleaning up pointers

2017-05-09 Thread Nicholas A. Bellinger
On Tue, 2017-05-09 at 11:50 -0500, Bryant G. Ly wrote: > This patch is dependent on: > 'commit 25e78531268e ("ibmvscsis: Do not send aborted task response")' > This patch cleans up some pointers after usage. > > Signed-off-by: Bryant G. Ly > Reviewed-by: Michael Cyr

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-05-09 Thread Rangankar, Manish
On 10/04/17 10:42 PM, "Sebastian Andrzej Siewior" wrote: >The driver creates its own per-CPU threads which are updated based on CPU >hotplug events. It is also possible to use kworkers and remove some of the >infrastructure get the same job done while saving a few lines

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-09 Thread Chad Dupuis
On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > Sebastian, > > > Martin, do you see any chance to get this merged? Chad replied to the > > list that he is going to test it on 2017-04-10, didn't respond to the > > ping 10 days later. The series stalled last time in the same way. > >

[PATCH] csiostor: Avoid content leaks and casts

2017-05-09 Thread Kees Cook
When copying attributes, the len argument was padded out and the resulting memcpy() would copy beyond the end of the source buffer. Avoid this, and use size_t for val_len to avoid all the casts. Similarly, avoid source buffer casts and use void *. Additionally enforces val_len can be represented

[PATCH] scsi: qla2xxx: remove dead code

2017-05-09 Thread Gustavo A. R. Silva
Local variable page_mode is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 200420 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/qla2xxx/qla_nx.c | 48

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-09 Thread James Bottomley
On Tue, 2017-05-09 at 10:17 -0400, Chad Dupuis wrote: > On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > > > > Sebastian, > > > > > Martin, do you see any chance to get this merged? Chad replied to > the > > > list that he is going to test it on 2017-04-10, didn't respond to > the > >