[PATCH 1/1] scsi: bnx: use setup_timer

Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c

Re: [PATCH V6 1/3] dma-mapping: Introduce device_is_coherent() as a helper

On 19/09/17 09:52, Huacai Chen wrote: > We will use device_is_coherent() as a helper function, which will be > used in the next patch. > > There is a MIPS-specific plat_device_is_coherent(), but we need a more > generic solution, so add and use a new function pointer in dma_map_ops. I think

Re: [PATCH V6 2/3] dma-mapping: Rework dma_get_cache_alignment()function

On Thu, Sep 21, 2017 at 12:28:25PM +0800, 陈华才 wrote: > Hi, Christoph, > > I have changed dma_get_cache_alignment's return value, and I don't know > whether those drivers want to return ARCH_DMA_MINALIGN unconditionally. So I > pass a NULL for those drivers, in order to keep their old behavior.

Re: usb/storage/uas: slab-out-of-bounds in uas_probe

On Thu, Sep 21, 2017 at 05:39:05PM +0200, Andrey Konovalov wrote: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). > > The issue occurs when we iterate over interface altsettings, but I > don't see

RE: [PATCH] scsi: aacraid: Add a small delay after IOP reset

> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Tuesday, September 19, 2017 9:12 AM > To: dl-esc-Aacraid Linux Driver ; linux- > s...@vger.kernel.org > Cc: gpicc...@linux.vnet.ibm.com; Raghava Aditya Renukunta >

usb/storage/uas: slab-out-of-bounds in uas_probe

Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). The issue occurs when we iterate over interface altsettings, but I don't see the driver doing anything wrong. I might be missing something, or this might be an

Re: ibmvfc oddities

On 09/21/2017 05:02 AM, Hannes Reinecke wrote: > Hi Brian, > > I was looking at the ibmvfc code (trying to hook up libfc), and have > found this definition: > > struct ibmvfc_fcp_rsp_info { > __be16 reserved; > u8 rsp_code; > u8 reserved2[4]; > }__attribute__((packed, aligned

[PATCH 1/1] drivers:scsi: use setup_timer

Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/scsi/sym53c8xx_2/sym_glue.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c

[PATCH 6/6] scsi: Cocci spatch "pool_zalloc-simple"

Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c ---

[PATCH 4/6] mvsas: Cocci spatch "pool_zalloc-simple"

Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c --- a/drivers/scsi/mvsas/mv_sas.c +++

[PATCH 3/6] scsi: lpfc: Cocci spatch "pool_zalloc-simple"

Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c --- a/drivers/scsi/lpfc/lpfc_nvme.c

[PATCH 5/6] scsi: qla2xxx: Cocci spatch "pool_zalloc-simple"

Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c ---

Re: [PATCH v2 18/31] scsi/aic7xxx: Clean up timer usage

On 09/21/2017 01:27 AM, Kees Cook wrote: > stat_timer only ever assigns the same function and data, so consolidate to > a setup_timer() call and drop everything else used to pass things around. > > reset_timer is unused; remove it. > > Cc: Hannes Reinecke > Cc: "James E.J.

Re: usb/storage/uas: slab-out-of-bounds in uas_probe

On Thu, 21 Sep 2017, Andrey Konovalov wrote: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). > > The issue occurs when we iterate over interface altsettings, but I > don't see the driver doing

Re: Is the possible cross-talking between unrelated file-descriptors on bsg-device by design?

On Tue, Sep 19, 2017 at 02:16:26PM -0400, Douglas Gilbert wrote: > On 2017-09-19 10:56 AM, Benjamin Block wrote: > > Hello linux-block, > > > > I wrote some tests recently to test patches against bsg.c and bsg-lib.c, > > and while writing those I noticed something strange: > > > > When you use

Re: usb/storage/uas: slab-out-of-bounds in uas_probe

On Thu, 21 Sep 2017, Andrey Konovalov wrote: > On Thu, Sep 21, 2017 at 6:10 PM, Greg Kroah-Hartman > wrote: > > On Thu, Sep 21, 2017 at 05:39:05PM +0200, Andrey Konovalov wrote: > >> Hi! > >> > >> I've got the following report while fuzzing the kernel with syzkaller.

Re: [PATCH V6 1/3] dma-mapping: Introduce device_is_coherent() as ahelper

Hi, Robin, Before 2.6.36 dma_get_cache_alignment is arch-dependent, and it is unified in commit 4565f0170dfc849b3629c27d7 ("dma-mapping: unify dma_get_cache_alignment implementations"). Should we revert to the old implementation? Huacai -- Original -- From:

Re: ibmvfc oddities

On 09/21/2017 08:29 PM, Tyrel Datwyler wrote: > On 09/21/2017 08:13 AM, Brian King wrote: >> On 09/21/2017 05:02 AM, Hannes Reinecke wrote: >>> Hi Brian, >>> >>> I was looking at the ibmvfc code (trying to hook up libfc), and have >>> found this definition: >>> >>> struct ibmvfc_fcp_rsp_info { >>>

Re: [PATCH 1/1] scsi: bnx: use setup_timer

On Thu, 21 Sep 2017, 7:47am, Allen Pais wrote: > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Allen Pais > --- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

[PATCH 1/1] bsg-lib: fix use-after-free under memory-pressure

When under memory-pressure it is possible that the mempool which backs the 'struct request_queue' will make use of up to BLKDEV_MIN_RQ count emergency buffers - in case it can't get a regular allocation. These buffers are preallocated and once they are also used, they are re-supplied with old

Re: ibmvfc oddities

On 09/21/2017 08:13 AM, Brian King wrote: > On 09/21/2017 05:02 AM, Hannes Reinecke wrote: >> Hi Brian, >> >> I was looking at the ibmvfc code (trying to hook up libfc), and have >> found this definition: >> >> struct ibmvfc_fcp_rsp_info { >> __be16 reserved; >> u8 rsp_code; >> u8

Re: usb/storage/uas: slab-out-of-bounds in uas_probe

On Thu, Sep 21, 2017 at 6:50 PM, Alan Stern wrote: > On Thu, 21 Sep 2017, Andrey Konovalov wrote: > >> Hi! >> >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). >> >> The issue

Re: [PATCH V3 4/9] pm80xx : tag allocation for phy control request.

On Wed, Sep 20, 2017 at 5:18 PM, kbuild test robot wrote: > Hi Viswas, > > [auto build test WARNING on mkp-scsi/for-next] > [also build test WARNING on v4.14-rc1 next-20170920] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system]

ibmvfc oddities

Hi Brian, I was looking at the ibmvfc code (trying to hook up libfc), and have found this definition: struct ibmvfc_fcp_rsp_info { __be16 reserved; u8 rsp_code; u8 reserved2[4]; }__attribute__((packed, aligned (2))); in comparison, libfc has this: struct