Re: [PATCH 1/5] qla2xxx: Add module param ql2xenablemsix

On Fri, Oct 13, 2017 at 06:52:31PM +, Madhani, Himanshu wrote: > Sorry this one slipped out of my sight. The reason I used "ql2xenablemsix" > was because driver already > had this parameter in code until few versions back where we removed it. Since > existing user are familiar > with this

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/13/2017 07:29 PM, Ming Lei wrote: > On Fri, Oct 13, 2017 at 05:08:52PM +, Bart Van Assche wrote: >> On Sat, 2017-10-14 at 00:45 +0800, Ming Lei wrote: >>> On Fri, Oct 13, 2017 at 04:31:04PM +, Bart Van Assche wrote: On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote: >

Re: [PATCH 8/9] block: pass full fmode_t to blk_verify_command

On Tue, Oct 03, 2017 at 12:48:44PM +0200, Christoph Hellwig wrote: > Use the obvious calling convention. > > Signed-off-by: Christoph Hellwig > --- > block/bsg.c| 18 -- > block/scsi_ioctl.c | 8 > drivers/scsi/sg.c | 2 +- >

Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, Oct 16, 2017 at 03:36:50PM +, Bart Van Assche wrote: > On Mon, 2017-10-16 at 18:27 +0300, Michael S. Tsirkin wrote: > > On Mon, Oct 16, 2017 at 01:57:35PM +, Bart Van Assche wrote: > > > On Mon, 2017-10-16 at 16:34 +0300, Michael S. Tsirkin wrote: > > > > I don't see how it'll help

[PATCH v2 11/15] stm class: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or used inside a if statement or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in

[PATCH v2 12/15] RDMA/cma: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the

[PATCH v2 03/15] target: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the

[PATCH v2 06/15] PCI: endpoint: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup

[PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup

[PATCH v2 05/15] ocfs2/cluster: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the

[PATCH v2 02/15] usb: gadget: make config_item_type structures const

Make these structures const as they are only passed to the const argument of the functions config_{group/item}_init_type_name. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the constification patches into a series.

[PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const

The ci_type field of the config_item structure do not modify the fields of the config_item_type structure it points to. And the other pointers initialized with ci_type do not modify the fields as well. So, make the ci_type field and the pointers initialized with ci_type as const. Make the struct

Re: [PATCH 6/9] bsg-lib: introduce a timeout field in struct bsg_job

On Tue, Oct 03, 2017 at 12:48:42PM +0200, Christoph Hellwig wrote: > The zfcp driver wants to know the timeout for a bsg job, so add a field > to struct bsg_job for it in preparation of not exposing the request > to the bsg-lib users. > > Signed-off-by: Christoph Hellwig > --- >

[PATCH v2 13/15] netconsole: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the

[PATCH 4.13 41/53] genirq/cpuhotplug: Enforce affinity setting on startup of managed irqs

4.13-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Gleixner commit e43b3b58548051f8809391eb7bec7a27ed3003ea upstream. Managed interrupts can end up in a stale state on CPU hotplug. If the interrupt is not targeting

[PATCH v2 15/15] configfs: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup

[PATCH v2 14/15] dlm: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup

Re: [PATCH 7/9] bsg-lib: remove bsg_job.req

On Tue, Oct 03, 2017 at 12:48:43PM +0200, Christoph Hellwig wrote: > Users of the bsg-lib interface should only use the bsg_job data structure > and not know about implementation details of it. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c | 14 ++

[PATCH v2 10/15] nullb: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the

[PATCH v2 00/15] make structure field, function arguments and structures const

Make the ci_type field and some function arguments as const. After this change, make config_item_type structures as const. * Changes in v2- Combine all the followup patches and the constification patches into a series. Bhumika Goyal (15): configfs: make ci_type field, some pointers and

[PATCH v2 04/15] iio: make function argument and some structures const

Make the argument of the functions iio_sw{d/t}_group_init_type_name const as they are only passed to the function config_group_init_type_name having the argument as const. Make the config_item_type structures const as they are either passed to the functions having the argument as const or they

[PATCH v2 08/15] nvmet: make config_item_type const

Make config_item_type structures const as they are either passed to a function having the argument as const or used inside an if statement or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle Signed-off-by: Bhumika Goyal --- * Changes in

[PATCH v2 09/15] ACPI: configfs: make config_item_type const

Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the

Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, Oct 16, 2017 at 01:57:35PM +, Bart Van Assche wrote: > On Mon, 2017-10-16 at 16:34 +0300, Michael S. Tsirkin wrote: > > I don't see how it'll help make things better. OTOH if the specific > > drivers are tagged in the makefile, they can be gradually moved out to > > staging or

Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, 2017-10-16 at 18:27 +0300, Michael S. Tsirkin wrote: > On Mon, Oct 16, 2017 at 01:57:35PM +, Bart Van Assche wrote: > > On Mon, 2017-10-16 at 16:34 +0300, Michael S. Tsirkin wrote: > > > I don't see how it'll help make things better. OTOH if the specific > > > drivers are tagged in the

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Mon, 2017-10-16 at 13:30 +0200, Hannes Reinecke wrote: > On Fri, Oct 13, 2017 at 05:08:52PM +, Bart Van Assche wrote: > > (+Himanshu Madhani) > > > > Himanshu, do you perhaps know whether it is safe to increase cmd_per_lun for > > the qla2xxx initiator driver to the scsi_host->can_queue

Re: [PATCH v2 06/15] PCI: endpoint: make config_item_type const

On Mon, Oct 16, 2017 at 05:18:45PM +0200, Bhumika Goyal wrote: > Make config_item_type structures const as they are either passed to a > function having the argument as const or stored in the const "ci_type" > field of a config_item structure. > > Done using Coccinelle. > > Signed-off-by:

[PATCH 1/1] qla2xxx: Initialize Work element before requesting IRQs

From: Himanshu Madhani commit a9e170e28636 ("scsi: qla2xxx: Fix uninitialized work element") moved initialziation of work element earlier in the probe to fix call stack. However, it still leaves a window where interrupt can be generated before work element is

Re: [PATCH 1/2] qla2xxx: Use ql2xnvmeenable to enable Q-Pair for FC-NVMe

On Fri, 2017-10-13 at 15:43 -0700, Madhani, Madhani wrote: > From: Himanshu Madhani > > In some env, user can choose to not enable SCSI-MQ but wants > to use FC-NVMe feature of the driver. Since driver relies on > Q-Pairs to allocate FC-NVMe resources, use existing

[PATCH v2] linux/types.h: Restore the ability to disable sparse endianness checks

The purpose of patch "linux/types.h: enable endian checks for all sparse builds" was to encourage driver authors to annotate endianness correctly in their drivers. However, since that patch went upstream no endianness annotations in drivers have been fixed. I think that this shows that the

Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, 2017-10-16 at 19:50 +0300, Michael S. Tsirkin wrote: > Right but qla_nvme also triggers these warnings. That's the problem with > disabling them tree-wide. To me it looks like the time we are spending > arguing about work-arounds would be better spent just fixing the > majority of the

[SUSPECTED SPAM] RE: Incident [INC0903501]

From: Hice, Tina Sent: Monday, October 16, 2017 9:00 AM Subject: Incident [INC0903501] Please take a moment to complete a survey on incident INC0903501 regarding "help desk survey on your email" Your feedback is extremely valuable. Click on

Re: [PATCH v2 04/15] iio: make function argument and some structures const

On 16 October 2017 16:18:43 BST, Bhumika Goyal wrote: >Make the argument of the functions iio_sw{d/t}_group_init_type_name >const >as they are only passed to the function config_group_init_type_name >having >the argument as const. > >Make the config_item_type structures

Re: [PATCH] scsi: hpsa: simplify hpsa_set_local_logical_count()

On 16/10/17 18:55:11 +, Don Brace wrote: > > -Original Message- > > From: Christos Gkekas [mailto:chris.ge...@gmail.com] > > Sent: Sunday, October 15, 2017 2:35 PM > > To: Don Brace ; James E.J. Bottomley > > ; Martin K. Petersen > >

Re: system hung up when offlining CPUs

Yasuaki, On Mon, 16 Oct 2017, YASUAKI ISHIMATSU wrote: > Hi Thomas, > > > Can you please apply the patch below on top of Linus tree and retest? > > > > Please send me the outputs I asked you to provide last time in any case > > (success or fail). > > The issue still occurs even if I applied

Re: [PATCH v2] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, 2017-10-16 at 22:57 +0300, Michael S. Tsirkin wrote: > On Mon, Oct 16, 2017 at 10:26:33AM -0700, Bart Van Assche wrote: > > I think that this shows that the followed approach does not work, > > probably because several driver authors do not use sparse. For > > developers who are not the

[PATCH v9 01/10] md: Rename md_notifier into md_reboot_notifier

This avoids confusion with the pm notifier that will be added through a later patch. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Shaohua Li Tested-by: Martin Steigerwald Cc:

[PATCH v9 06/10] block: Introduce BLK_MQ_REQ_PREEMPT

Set RQF_PREEMPT if BLK_MQ_REQ_PREEMPT is passed to blk_get_request_flags(). Signed-off-by: Bart Van Assche Tested-by: Martin Steigerwald Cc: Christoph Hellwig Cc: Ming Lei Cc: Hannes Reinecke Cc:

[PATCH v9 03/10] md: Neither resync nor reshape while the system is frozen

Some people use the md driver on laptops and use the suspend and resume functionality. Since it is essential that submitting of new I/O requests stops before a hibernation image is created, interrupt the md resync and reshape actions if the system is being frozen. Note: the resync and reshape will

[PATCH v9 08/10] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag

This flag will be used in the next patch to let the block layer core know whether or not a SCSI request queue has been quiesced. A quiesced SCSI queue namely only processes RQF_PREEMPT requests. Signed-off-by: Bart Van Assche Tested-by: Martin Steigerwald

[PATCH] scsi: smartpqi: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "Martin K. Petersen" Cc: Don Brace Cc: "James

[PATCH] scsi: aic94xx: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "Martin K. Petersen" Cc: "James E.J. Bottomley"

[PATCH] scsi: libiscsi: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Lee Duncan Cc: Chris Leech Cc: "James E.J. Bottomley"

[PATCH] scsi: dc395x: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Oliver Neukum Cc: Ali Akcaagac Cc: Jamie Lenehan

[PATCH] scsi: gdth: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Achim Leubner Cc: "James E.J. Bottomley" Cc:

[PATCH] scsi: libfc: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This removes several redundant setup calls in favor of just changing the timer function directly. Cc:

[PATCH] scsi/bnx2i: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. There was a seemingly missing call to initialize the timer in one handler, so this was added to remove the

[PATCH] scsi: be2iscsi: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Subbu Seetharaman Cc: Ketan Mukadam Cc:

Re: [PATCH v2 09/15] ACPI: configfs: make config_item_type const

On Monday, October 16, 2017 5:18:48 PM CEST Bhumika Goyal wrote: > Make these structures const as they are either passed to the functions > having the argument as const or stored as a reference in the "ci_type" > const field of a config_item structure. > > Done using Coccienlle. > >

[PATCH v2 0/8] Introduce sgl_alloc() and sgl_free()

Hello Jens, As you know there are multiple drivers that both allocate a scatter/gather list and populate that list with pages. This patch series moves the code for allocating and freeing such scatterlists from these drivers into lib/scatterlist.c. Please consider this patch series for kernel

[PATCH v2 5/8] target: Use sgl_alloc_order() and sgl_free()

Use the sgl_alloc_order() and sgl_free() functions instead of open coding these functions. Signed-off-by: Bart Van Assche Cc: Nicholas A. Bellinger Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Sagi Grimberg

[PATCH v2 2/8] crypto: scompress - use sgl_alloc() and sgl_free()

Use the sgl_alloc() and sgl_free() functions instead of open coding these functions. Signed-off-by: Bart Van Assche Cc: Ard Biesheuvel Cc: Herbert Xu --- crypto/Kconfig | 1 + crypto/scompress.c | 51

[PATCH v2 4/8] nvmet/rdma: Use sgl_alloc() and sgl_free()

Use the sgl_alloc() and sgl_free() functions instead of open coding these functions. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Cc: Keith Busch Cc: Christoph Hellwig Cc: Sagi Grimberg

[PATCH v2 8/8] scsi/pmcraid: Use sgl_alloc_order() and sgl_free_order()

Use the sgl_alloc_order() and sgl_free_order() functions instead of open coding these functions. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Cc: linux-scsi@vger.kernel.org Cc: Martin K. Petersen Cc: Anil

[PATCH v2 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

Use the sgl_alloc_order() and sgl_free_order() functions instead of open coding these functions. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Cc: linux-scsi@vger.kernel.org Cc: Martin K. Petersen Cc:

[PATCH v2 1/8] lib/scatterlist: Introduce sgl_alloc() and sgl_free()

Many kernel drivers contain code that allocates and frees both a scatterlist and the pages that populate that scatterlist. Introduce functions in lib/scatterlist.c that perform these tasks instead of duplicating this functionality in multiple drivers. Only include these functions in the build if

[PATCH v2 3/8] nvmet/fc: Use sgl_alloc() and sgl_free()

Use the sgl_alloc() and sgl_free() functions instead of open coding these functions. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Cc: Keith Busch Cc: Christoph Hellwig Cc: James Smart

[PATCH v2 7/8] scsi/pmcraid: Remove an unused structure member

Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Cc: linux-scsi@vger.kernel.org Cc: Martin K. Petersen Cc: Anil Ravindranath --- drivers/scsi/pmcraid.h | 1 - 1 file

[PATCH v9 04/10] block: Make q_usage_counter also track legacy requests

From: Ming Lei This patch makes it possible to pause request allocation for the legacy block layer by calling blk_mq_freeze_queue() and blk_mq_unfreeze_queue(). Signed-off-by: Ming Lei [ bvanassche: Combined two patches into one, edited a comment and

[PATCH v9 02/10] md: Introduce md_stop_all_writes()

Introduce md_stop_all_writes() because the next patch will add a second caller for this function. This patch does not change any functionality. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Shaohua Li

[PATCH v9 10/10] block, nvme: Introduce blk_mq_req_flags_t

Several block layer and NVMe core functions accept a combination of BLK_MQ_REQ_* flags through the 'flags' argument but there is no verification at compile time whether the right type of block layer flags is passed. Make it possible for sparse to verify this. This patch does not change any

[PATCH v9 09/10] block, scsi: Make SCSI quiesce and resume work reliably

The contexts from which a SCSI device can be quiesced or resumed are: * Writing into /sys/class/scsi_device/*/device/state. * SCSI parallel (SPI) domain validation. * The SCSI device power management methods. See also scsi_bus_pm_ops. It is essential during suspend and resume that neither the

[PATCH v9 00/10] block, scsi, md: Improve suspend and resume

Hello Jens, It is known that during the resume following a hibernate, especially when using an md RAID1 array created on top of SCSI devices, sometimes the system hangs instead of coming up properly. This patch series fixes that problem. These patches have been tested on top of the block layer

[PATCH v9 07/10] ide, scsi: Tell the block layer at request allocation time about preempt requests

Convert blk_get_request(q, op, __GFP_RECLAIM) into blk_get_request_flags(q, op, BLK_MQ_PREEMPT). This patch does not change any functionality. Signed-off-by: Bart Van Assche Tested-by: Martin Steigerwald Acked-by: David S. Miller

[PATCH v9 05/10] block: Introduce blk_get_request_flags()

A side effect of this patch is that the GFP mask that is passed to several allocation functions in the legacy block layer is changed from GFP_KERNEL into __GFP_DIRECT_RECLAIM. Signed-off-by: Bart Van Assche Tested-by: Martin Steigerwald Cc: Christoph

[PATCH] aacraid: Fix controller initialization failure

This is a fix to an issue where the driver sends its periodic WELLNESS command to the controller after the driver shut it down.This causes the controller to crash. The window where this can happen is small, but it can be hit at around 4 hours of constant resets. Cc:

Re: [PATCH v2] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, Oct 16, 2017 at 10:26:33AM -0700, Bart Van Assche wrote: > The purpose of patch "linux/types.h: enable endian checks for all > sparse builds" was to encourage driver authors to annotate > endianness correctly in their drivers. However, since that patch > went upstream no endianness

Re: system hung up when offlining CPUs

Hi Thomas, > Can you please apply the patch below on top of Linus tree and retest? > > Please send me the outputs I asked you to provide last time in any case > (success or fail). The issue still occurs even if I applied your patch to linux 4.14.0-rc4. --- [ ...] INFO: task setroubleshootd:4972

[PATCH] csi: hpsa: Fix configured_logical_drive_count·check

Check whether configured_logical_drive_count is less than 255. Previous check was always evaluating to true as this variable is defined as u8. Signed-off-by: Christos Gkekas --- drivers/scsi/hpsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] scsi: qedi: Delete redundant variables

Christos, > Remove redundant variables in quedi_fw.c that are set but not used. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [RFC] bsg-lib interface cleanup

Christoph, > this series cleans up various abuses of the bsg interfaces, and then > splits bsg for SCSI passthrough from bsg for arbitrary transport > passthrough. This removes the scsi_request abuse in bsg-lib that is > very confusing, and also makes sure we can sanity check the requests > we

Re: [PATCH 0/5] ZBC support clenaup and fixes

Damien, > First part of the "scsi-mq support for ZBC disks" series that is only > scsi specific. These patches are just cleanups with only one bug fix > (last pacth) and do not functionally change anything. > > The remaining rework of the zone locking including scsi-mq support is > still ongoing

Re: [PATCH] scsi: libfc: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. This removes > several redundant setup calls in favor of just changing the timer > function

Re: [PATCH] scsi: libiscsi: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: be2iscsi: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi/bnx2i: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: aic94xx: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: gdth: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: dc395x: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: smartpqi: Convert timers to use timer_setup()

Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH v9 07/10] ide, scsi: Tell the block layer at request allocation time about preempt requests

Bart, > Convert blk_get_request(q, op, __GFP_RECLAIM) into > blk_get_request_flags(q, op, BLK_MQ_PREEMPT). This patch does not > change any functionality. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v9 09/10] block, scsi: Make SCSI quiesce and resume work reliably

Bart, > The contexts from which a SCSI device can be quiesced or resumed are: > * Writing into /sys/class/scsi_device/*/device/state. > * SCSI parallel (SPI) domain validation. > * The SCSI device power management methods. See also scsi_bus_pm_ops. The SCSI bits look fine to me. Acked-by:

Re: [PATCH] [SCSI] bfa: integer overflow in debugfs

Dan, > We could allocate less memory than intended because we do: > > bfad->regdata = kzalloc(len << 2, GFP_KERNEL); > > The shift can overflow leading to a crash. This is debugfs code so the > impact is very small. I fixed the network version of this in March with > commit 13e2d5187f6b

Re: [PATCH] scsi: nsp32: fix logic bug in error handling

Masanori, >> gcc-8 points out a logic error that has existed since the start >> of the git history: >> >> drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': >> drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to >> false [-Werror=tautological-compare] >>

Re: [PATCH] scsi: aic7xxx: make a couple of functions static

Colin, > Functions ahc_devlimited_syncrate and ahc_linux_initialize_scsi_bus > are declared static in their prototypes but are missing in their > definitions, so add the missing static. Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl()

Dan, > The ! has higher precedence than the & operation. I've added > parenthesis so this works as intended. Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] zfcp: fix erp_action use-before-initialize in REC action trace

Steffen, > v4.10 commit 6f2ce1c6af37 ("scsi: zfcp: fix rport unblock race with LUN > recovery") extended accessing parent pointer fields of > struct zfcp_erp_action for tracing. Applied to 4.14/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/5] qla2xxx: Patches for scsi-misc

Madhani, > This series adds support for INTx mode for qla2xxx driver. Also, adds > support for N2N login for FC-NVMe. > > Please apply to 4.15/scsi-queue at your earliest convenience. Several of the patches had bad whitespace. Please run checkpatch before submitting. Also, you did not apply the

Re: [PATCH 0/2] qla2xxx: Couple bug fixes for FC-NVMe

Himanshu, > This series has couple bug fixes for FC-NVMe code path. Please apply > them to 4.15/scsi-queue at your earliest convenience. Applied to 4.15/scsi-queue. PS. You send email as "Madhani, Madhani". -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] csi: hpsa: Fix configured_logical_drive_count·check

Christos, > Check whether configured_logical_drive_count is less than > 255. Previous check was always evaluating to true as this variable is > defined as u8. Applied to 4.14/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] qla2xxx: Initialize Work element before requesting IRQs

Himanshu, > commit a9e170e28636 ("scsi: qla2xxx: Fix uninitialized work element") > moved initialziation of work element earlier in the probe to fix call > stack. However, it still leaves a window where interrupt can be > generated before work element is initialized. Fix that window by >

Re: [PATCH] aacraid: Fix controller initialization failure

Raghava, > This is a fix to an issue where the driver sends its periodic WELLNESS > command to the controller after the driver shut it down.This causes > the controller to crash. The window where this can happen is small, > but it can be hit at around 4 hours of constant resets. Applied to

Re: [PATCH v9 09/10] block, scsi: Make SCSI quiesce and resume work reliably

On Mon, Oct 16, 2017 at 04:29:04PM -0700, Bart Van Assche wrote: > The contexts from which a SCSI device can be quiesced or resumed are: > * Writing into /sys/class/scsi_device/*/device/state. > * SCSI parallel (SPI) domain validation. > * The SCSI device power management methods. See also

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Mon, Oct 16, 2017 at 01:30:09PM +0200, Hannes Reinecke wrote: > On 10/13/2017 07:29 PM, Ming Lei wrote: > > On Fri, Oct 13, 2017 at 05:08:52PM +, Bart Van Assche wrote: > >> On Sat, 2017-10-14 at 00:45 +0800, Ming Lei wrote: > >>> On Fri, Oct 13, 2017 at 04:31:04PM +, Bart Van Assche

[PATCH 1/2] SCSI: run idle hctx after delay in scsi_mq_get_budget()

If there isn't any outstanding request in this queue, both blk-mq's RESTART and SCSI's builtin RESTART can't work, so we have to deal with this case by running this queue after delay. Fixes: d04b6d97d0a1(scsi: implement .get_budget and .put_budget for blk-mq) Signed-off-by: Ming Lei

[PATCH 2/2] blk-mq: don't handle TAG_SHARED in restart

Now restart is used in the following cases, and TAG_SHARED is for SCSI only. 1) .get_budget() returns BLK_STS_RESOURCE - if resource in target/host level isn't satistifed, this SCSI device will be added in shost->starved_list, and the whole queue will be rerun (via SCSI's built-in RESTART) in

[PATCH 0/2] block/SCSI MQ: two RESTART related patches

Hi Jens, The 1st patch runs idle hctx after dealy in scsi_mq_get_budget(), so that we can keep same behaviour with before, and it can be thought as a fix. The 2nd patch cleans up RESTART, and removes handling for TAG_SHARED from current blk-mq's RESTART mechanism because SCSI_MQ can covers its

Re: [PATCHv6 0/5] scsi: Fixup blacklist handling

Hannes, > The SCSI blacklist handling seems to be rather tricky issue; everytime > a fix is included it tends to break other devices. This patchset > attempt to simplify the devlist handling yet again, but this time > implementing the framework for regression testing, too. A patch > adding a

Re: [PATCH 0/2] block/SCSI MQ: two RESTART related patches

On Tue, Oct 17, 2017 at 01:04:16PM +0800, Ming Lei wrote: > Hi Jens, > > The 1st patch runs idle hctx after dealy in scsi_mq_get_budget(), > so that we can keep same behaviour with before, and it can be > thought as a fix. > > The 2nd patch cleans up RESTART, and removes handling for TAG_SHARED

Re: [PATCH v2 0/2] change allow_restart, manage_start_stop to bool in sysfs

weiping, > weiping zhang (2): > scsi: sd: change allow_restart to bool in sysfs interface > scsi: sd: change manage_start_stop to bool in sysfs interface Applied to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

  1   2   >