Re: [trivial PATCH] treewide: Align function definition open/close braces

Em Sun, 17 Dec 2017 16:28:44 -0800 Joe Perches escreveu: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work >

[PATCH v1] scsi: hpsa: Use vsnprintf extension %phN

Using this extension reduces the object size. Signed-off-by: Andy Shevchenko --- drivers/scsi/hpsa.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index b0aa5dc1d54c..4c018b653f18

[PATCH v1] libsas: remove private hex2bin() implementation

The function sas_parse_addr() could be easily substituted by hex2bin() which is in kernel library code. Cc: Christoph Hellwig Signed-off-by: Andy Shevchenko --- drivers/scsi/libsas/sas_scsi_host.c | 20 1 file changed, 4

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

On Tue, 19 Dec 2017, Joe Perches wrote: > drivers/gpu/drm/i915/i915_sysfs.c | 12 ++-- For i915, Acked-by: Jani Nikula -- Jani Nikula, Intel Open Source Technology Center

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

On 12/19/2017 12:15 PM, Joe Perches wrote: drivers/char/ipmi/ipmi_msghandler.c| 17 +++--- For ipmi: Acked-by: Corey Minyard

[PATCH 2/2] scsi: ufs: use sysfs entry for health info

From: Jaegeuk Kim This patch introduces sysfs entries to show the information. # cat /sys/devices/soc/1da4000.ufshc/health/eol # cat /sys/devices/soc/1da4000.ufshc/health/length # cat /sys/devices/soc/1da4000.ufshc/health/lifetimeA # cat

[PATCH 1/2] scsi: ufs: introduce static sysfs entries

From: Jaegeuk Kim This patch introduces attribute group to show existing sysfs entries. Cc: Greg KH Signed-off-by: Jaegeuk Kim --- drivers/scsi/ufs/ufshcd.c | 48 +++

Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote: > Sorry for the very long patch. > The firmware changes are spread all over w/o a good modularity. Rings false. Significant portion of this patch is just whitespace and comment changes.

Re: [PATCH 2/2 v2] scsi: ufs: use sysfs entry for health info

On Tue, 2017-12-19 at 14:46 -0800, Jaegeuk Kim wrote: > Subject: [PATCH 2/2] scsi: ufs: introduce sysfs entries exposing UFS health > info > > This patch adds a new sysfs group, namely health, via: > >/sys/devices/soc/X.ufshc/health/ Thanks for the quick respin. This looks a lot better to

[PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN which has zero good_bytes it must be assigned an error. Otherwise the I/O will be continuously requeued and will cause a deadlock in the case where disks are being hot added and removed. sd_probe_async will wait forever for its

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

On Tue, Dec 19, 2017 at 10:15:09AM -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { >

Re: [PATCH 2/2 v2] scsi: ufs: use sysfs entry for health info

On 12/19, Bart Van Assche wrote: > On Tue, 2017-12-19 at 12:02 -0800, Jaegeuk Kim wrote: > > This patch introduces sysfs entries to show the information. > > What information does "the information" refer to? > > Regarding the patch title: I think this patch introduces new sysfs attributes >

Re: Driver version for PMC Adaptec HBA in Linux and from vendor

Dear Raghava Aditya, Thank you for your answer. Am 18.12.2017 um 19:09 schrieb Raghava Aditya Renukunta: -Original Message- From: Paul Menzel [mailto:pmen...@molgen.mpg.de] Sent: Saturday, December 16, 2017 1:39 AM To: Raghava Aditya Renukunta ;

Re: [PATCH 2/2] scsi: ufs: use sysfs entry for health info

On Tue, 2017-12-19 at 12:02 -0800, Jaegeuk Kim wrote: > This patch introduces sysfs entries to show the information. What information does "the information" refer to? Regarding the patch title: I think this patch introduces new sysfs attributes instead of using existing sysfs entries. If so,

Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

On Tue, 19 Dec 2017 13:32:48 -0500 Cathy Avery wrote: > When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN > which has zero good_bytes it must be assigned an error. Otherwise > the I/O will be continuously requeued and will cause a deadlock in the > case

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

On Tue, Dec 19, 2017 at 8:15 PM, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { >

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

On Tue, 2017-12-19 at 19:44 +0100, Borislav Petkov wrote: > On Tue, Dec 19, 2017 at 10:15:09AM -0800, Joe Perches wrote: > > Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible. > > > > Done with perl script: > > > > $ git grep -w --name-only DEVICE_ATTR | \ > > xargs perl -i -e 'local

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

On Tue, Dec 19, 2017 at 10:51:14AM -0800, Joe Perches wrote: > > The reason for the code churn being? > > Consistency for easier grep by use-type. Please explain that in the commit message so that we know why it was changed. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid

[PATCH] lpfc: correct sg_seg_cnt attribute min vs default

Prior patch mixed up what argument in the macro was what, so min value was placed as the "default" argument, and the default value was placed as the "min" argument. Thus, when the default was applied, it looked like the default was smaller than the allowed min. swap argument postions to correct.

[-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) {

[-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444\s*)\)?\s*,\s*\1_show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(\1)/g;

RE: crash in iscsi/scsi initiator with linux-4.15.0-rc1

> > Hey, > > > > I'm seeing this null pointer dereference with linux-4.15.0-rc1. To > > reproduce > > it, I connect two ram disks via iscsi/TCP, and start an fio: > > > > iscsiadm -m discovery --op update --type sendtargets -p 172.16.1.10:3260 > > iscsiadm -m node -p 172.16.1.10:3260 -l > >

RE: crash in iscsi/scsi initiator with linux-4.15.0-rc1

On Tue, 2017-12-19 at 13:31 -0600, Steve Wise wrote: > > > Hey, > > > > > > I'm seeing this null pointer dereference with linux-4.15.0-rc1. To > > > reproduce > > > it, I connect two ram disks via iscsi/TCP, and start an fio: > > > > > > iscsiadm -m discovery --op update --type sendtargets -p

[-next PATCH 0/4] sysfs and DEVICE_ATTR_

Joe Perches (4): sysfs.h: Use octal permissions treewide: Use DEVICE_ATTR_RW treewide: Use DEVICE_ATTR_RO treewide: Use DEVICE_ATTR_WO arch/arm/mach-pxa/sharpsl_pm.c | 4 +- arch/s390/kernel/smp.c | 2 +- arch/s390/kernel/topology.c

[-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IWUSR\s*|\s*0200\s*)\)?\s*,\s*NULL\s*,\s*\s_store\s*\)/DEVICE_ATTR_WO(\1)/g;

Re: [PATCH 2/2 v2] scsi: ufs: use sysfs entry for health info

>From 3368207da5988b8fed4e41e6c0f49a60ac014222 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 26 Sep 2017 20:53:48 -0700 Subject: [PATCH 2/2] scsi: ufs: introduce sysfs entries exposing UFS health info This patch adds a new sysfs group, namely health, via:

RE: Driver version for PMC Adaptec HBA in Linux and from vendor

Hi Paul, > -Original Message- > From: Paul Menzel [mailto:pmen...@molgen.mpg.de] > Sent: Tuesday, December 19, 2017 3:12 PM > To: Raghava Aditya Renukunta > ; dl-esc-Aacraid Linux Driver > > Cc: linux-scsi@vger.kernel.org;

[PATCH 11/43] qla2xxx: Move work element processing out of DPC thread

From: Quinn Tran DPC thread can stall during switch scan due to slow switch response. This will stall other work element that needs attention. Moving work element processing and relogin logic out of DPC thread and into its own work queue. Signed-off-by: Quinn Tran

[PATCH 09/43] qla2xxx: Fix Firmware dump size for Extended login and Exchange Offload

From: Quinn Tran This patch adjusts and reallocates fw_dump memory for target mode to save for extended login and exchange offload buffers into dump captured. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH 32/43] qla2xxx: Allow relogin and session creation after reset

When any kind of reset is issued, current code was setting state of LOGIN pending too early. This resulted into driver not retrying relogin until pervious reloin completes. Signed-off-by: Himanshu Madhani Signed-off-by: Quinn Tran ---

[PATCH 22/43] qla2xxx: Add switch command to simplify fabric discovery

From: Quinn Tran - add "async" gpn_ft, gnn_ft, gfpn_id, gnn_id switch commands. - For 8G and newer adapters, use async commands when it comes to fabric scan to reduce bottle neck. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH 31/43] qla2xxx: Add ability to use GPNFT/GNNFT for RSCN handling

From: Quinn Tran add ability to use gpnft/gnnft to handle RSCN. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 7 +++ drivers/scsi/qla2xxx/qla_gbl.h | 1 +

[PATCH 20/43] qla2xxx: Use known NPort ID for Management Server login

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 4 ++-- drivers/scsi/qla2xxx/qla_mid.c | 2 +- drivers/scsi/qla2xxx/qla_os.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h

[PATCH 19/43] qla2xxx: Fix session cleanup for N2N

From: Quinn Tran When connection type is N_Port to N_Port (point-to-point), there is a possibilty where initiator will not send PLOGI request and will directly send PRLI. In N2N connection the port has higher port name sends the PLOGI but not allow to send PRLI if is a

[PATCH 24/43] qla2xxx: Reduce the use of terminate exchange

From: Quinn Tran reduce usage of terminate exchange when command encounter resource bottle neck. Remote initiator view it as command drop. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 34/43] qla2xxx: Delay loop id allocation at login

From: Quinn Tran Delay loop id allocation to login time Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 64 ++--- 1 file changed, 35

[PATCH 30/43] qla2xxx: Properly extract ADISC error codes

From: Quinn Tran This patch fixes issue with extraction of ADISC error codes for decoding the error returned Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 24

[PATCH 28/43] qla2xxx: Remove session creation redundant code

From: Quinn Tran Current code creates a session when a new port is discovered, and a PLOGI/PRLI is received. There is no need to create session when command has arrived. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH 23/43] qla2xxx: Add lock protection around host lookup

From: Quinn Tran Host lookup via btree is currently protected by the hardware_lock. Add hardware_lock when modifying btree to store host pointer. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 25/43] qla2xxx: Reduce trace noise for Async Events

From: Quinn Tran Add NPIV id check to reduce multiple debug messages of the same RSCN event. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mid.c | 11 +-- 1 file

[PATCH 29/43] qla2xxx: Fix GPNFT/GNNFT error handling

From: Quinn Tran retry gpnft/gnnft if error is encountered. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 15 +++ drivers/scsi/qla2xxx/qla_init.c | 8

[PATCH 12/43] qla2xxx: Enable ATIO interrupt handshake for ISP27XX

From: Quinn Tran Enable ATIO Q interrupt handshake for ISP27XX. This patch coalesce ATIO's interrupts for Quad port ISP27XX adapter. Interrupt coalesce allows performance to scale for this specific case. Signed-off-by: Quinn Tran Signed-off-by:

[PATCH 15/43] qla2xxx: Add ability to send PRLO

From: Quinn Tran Add ability to send Implicit PRLO to flush IOs from FW back to driver. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 5

[PATCH 07/43] qla2xxx: Add ability to track IOCB resource for FW

From: Quinn Tran FW has a finite number of IOCB resource. Driver will track it via the ql2xtrackfwres module parameter. User will be able to reserve X number of IOCBs for either the target path or initiator path. The left over IOCBs are shared between the 2 modes. The

[PATCH 16/43] qla2xxx: Don't call dma_free_coherent with IRQ disabled.

From: Giridhar Malavali The logo ELS command allocates dma coherent memory for the data payload and serialize the completions. When this command times out, the timeout routine completes the thread waiting for completion which in turn cleanup resources allocated for

[PATCH 10/43] qla2xxx: Replace GPDB with async ADISC command

From: Quinn Tran Replace call to Get Port DataBase MB with PDO_FORCE_ADISC flag with async ADISC command so driver can see ADISC command has error or not. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 21/43] qla2xxx: Remove calling cancel_work_sync()

From: Sawan Chandak This is blocking call and issue is seen, when called in interrupt context. __cancel_work_timer+0x140/0x210 ? ql_dbg+0xcb/0x110 [qla2xxx] cancel_work_sync+0x10/0x20 qlt_schedule_sess_for_deletion+0x89/0x170 [qla2xxx]

[PATCH 04/43] qla2xxx: Use chip reset to bring down laser on unload.

From: Quinn Tran Current code uses Stop Firmware MB cmd to stop the chip before driver unload. This will leave the laser in its current state. This give the illusion of this adapter is still alive. For 8G & newer adapters, use chip reset to stop the chip and bring down

[PATCH 18/43] qla2xxx: Tweak resource count dump

From: Quinn Tran Fetch actual data from firmware instead of static data at chip reset time. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dfs.c | 30

[PATCH 27/43] qla2xxx: Migrate switch registration commands away from mailbox interface

From: Quinn Tran Migrate switch registration commands: RFTID, RFFID, RNNID and RSNN_NN out of mailbox interface to reduce fabric scan bottle neck. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 26/43] qla2xxx: Fix login state machine freeze

From: Quinn Tran Relogin stop moving forward due to improper check of scan_state flag. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 6 -- 1 file changed, 6

[PATCH 40/43] qla2xxx: Remove unused argument from qlt_schedule_sess_for_deletion()

From: Quinn Tran Immeadiate flag is not used for scheduling session deletion. Remove it to simplfy session deletion code path. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 33/43] qla2xxx: Increase verbosity of debug messages logged

From: Quinn Tran Add verbose bit for debug messages to reduce excessive log messages Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 8 1 file changed, 4

[PATCH 39/43] qla2xxx: Check FCF_ASYNC_SENT flag

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 85bdb6928ea2..49a8f2666f55 100644 ---

[PATCH 02/43] qla2xxx: Fix NULL pointer access for fcport structure

From: Quinn Tran when preocessing iocb in a timeout case, driver was trying to log messages without verifying if the fcport structure could have valid data. This results in a NULL pointer access. Fixes: 726b85487067("qla2xxx: Add framework for async fabric discovery")

[PATCH 01/43] qla2xxx: Fix stale memory access for name pointer

From: Quinn Tran Name pointer for sp describing each command is assigned with stack frame's memory. The stack frame could eventually be re-use, where name pointer access can get get garbage. This patch designates static memory for name pointer to fix this problem.

[PATCH 00/43] qla2xxx: Driver update

Hi Martin, This series contains number of improvments in handling of switch registration commands in the driver. Switch commands are now submitted via IOCB patch asynchronously instead of mailbox interface. Please apply this series to 4.16/scsi-queue branch at your earliest convenience.

[PATCH 06/43] qla2xxx: Fix stale mem access for IRQ name

From: Quinn Tran IRQ name pointer for INTx/MSI was pointing at stale stack frame. cat /proc/interrupts will trigger stale mem access. Fix it by creating dedicated space for IRQ name. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH 03/43] qla2xxx: Use IOCB path to submit Control VP MBX command

From: Quinn Tran Use IOCB patch to submit Control VP MBX command to reduce bottle-neck for mbx interface. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 9 -

[PATCH 13/43] qla2xxx: Use shadow register for ISP27XX

From: Quinn Tran For ISP27XX, use shadow register to read FW provided REQQ's consumer index. The shadow register is dma'ed by firmware. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 17/43] qla2xxx: Allow target mode to accept PRLI in dual mode

From: Quinn Tran For Dual Mode, Initiator side of the driver finish login, target side receive PRLI, but driver terminates PRLI. This patch allows target side to go ahead and accept PRLI. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH 08/43] qla2xxx: Chip reset uses wrong lock during IO flush.

From: Quinn Tran As part of chip reset, all commands from all QPairs are flushed. This patch fixes code to use Q Pair lock for flush instead of using old hardware_lock. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH 14/43] qla2xxx: Add option for use reserve exch for ELS

From: Quinn Tran Add option to tell FW to reserve 1/2 of emergency exchanges for ELS. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 1 +

[PATCH 05/43] qla2xxx: Add boundary checks for exchanges to be offloaded

From: Quinn Tran Max boundary for exchange off load is 32k exchanges. If system is unable to allocate large memory buffer to support this feature, then driver will reduce the number exchanges down to a value system can support. Signed-off-by: Quinn Tran

[PATCH 36/43] qla2xxx: Add counters for Exchange Buffer to debugfs

From: Anil Gurumurthy Signed-off-by: Anil Gurumurthy Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dfs.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 38/43] qla2xxx: Prevent relogin trigger from sending too many commands

From: Quinn Tran This patch adds check for pending work event before queueing relogin work to prevent redundant work to be active at the same time. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 43/43] qla2xxx: Update driver version to 10.00.00.04-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 911b82226d13..0843def08356 100644 ---

[PATCH 37/43] qla2xxx: Prevent multiple active discovery commands per session

From: Quinn Tran Add check to allow single discovery command per session to be sent Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 16

[PATCH 41/43] qla2xxx: Serialize session deletion by using work_lock

From: Quinn Tran for session deletion, replace sess_lock with work_lock. Under certain case sess_lock is not feasiable to acquire. The lock is needed temporarily to make sure a single call to schedule of the work element. Signed-off-by: Quinn Tran

[PATCH 35/43] qla2xxx: Add retry limit for fabric scan logic

From: Quinn Tran Switch scan is assumed to succeed most of the time. If the scan failed, then scan is limit 5 retries. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2

[PATCH 42/43] qla2xxx: Serialize session free in qlt_free_session_done

From: Quinn Tran Add free_pending flag to serialize queueing of free_work element onto the work queue Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 +