Re: [PATCH] scsi: cxlflash: Select SCSI_SCAN_ASYNC

On Tue, Feb 20, 2018 at 07:56:35PM +1100, Michael Ellerman wrote: > Vaibhav Jain writes: > > > The cxlflash driver uses "Asynchronous SCSI scanning" enabled by > > CONFIG_SCSI_SCAN_ASYNC. Without this enabled the modprobe of cxlflash > > module gets hung with

[Bug 198857] New: Patch for Backport of the Linux MegaRAID driver for SAS based RAID controllers

https://bugzilla.kernel.org/show_bug.cgi?id=198857 Bug ID: 198857 Summary: Patch for Backport of the Linux MegaRAID driver for SAS based RAID controllers Product: SCSI Drivers Version: 2.5 Kernel Version: 4.14.20 4.9.82

Re: [4.4-stable 08/22] ncr5380: shut up gcc indentation warning

On Tue, 20 Feb 2018, Arnd Bergmann wrote: > gcc-6 and higher warn about the way some loops are written in > the ncr5380 driver: > > drivers/scsi/g_NCR5380.c: In function 'generic_NCR5380_pread': > drivers/scsi/g_NCR5380.c:541:3: error: this 'while' clause does not guard... >

[PATCH 6/9] scsi: ufs-qcom: remove broken hci version quirk

From: Subhash Jadavani UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for version 3.x.y onwards. Signed-off-by: Subhash Jadavani

[PATCH 0/9] ufshcd optimizations and fixes

This patch set has a bunch of optimizations for UFS HCI. Maya Erez (1): scsi: ufs: fix exception event handling Subhash Jadavani (4): scsi: ufs: Add LCC quirk for host and device scsi: ufshcd: fix possible unclocked register access scsi: ufs: add reference counting for scsi block

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

On Tue, Feb 20, 2018 at 10:25:56AM -0800, James Smart wrote: > > Wouldn't it be better to improve the 32Bit writeq() code? > > Well, now that I'm asking for specific details internally, I'm finding that > no one can find the failing machine any more. > > I'm going to keep looking (and testing)

[PATCH 2/9] scsi: ufs: Add LCC quirk for host and device

From: Subhash Jadavani LCC (Line Control Command) is being used for communication between UFS host and UFS device. But some hosts might have the issue with issuing the LCC commands to UFS device and in this case LCC could be explicitly disabled. But there could be a

[PATCH 4/9] scsi: ufshcd: fix possible unclocked register access

From: Subhash Jadavani vendor specific setup_clocks ops may depend on clocks managed by ufshcd driver so if the vendor specific setup_clocks callback is called when the required clocks are turned off, it results into unclocked register access. This change make sure that

[PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue

From: Vijay Viswanath UFS driver can receive a request during memory reclaim by kswapd. So when ufs driver puts the ungate work in queue, and if there are no idle workers, kthreadd is invoked to create a new kworker. Since kswapd task holds a mutex which kthreadd also

[PATCH 5/9] scsi: ufs: add reference counting for scsi block requests

From: Subhash Jadavani Currently we call the scsi_block_requests()/scsi_unblock_requests() whenever we want to block/unblock scsi requests but as there is no reference counting, nesting of these calls could leave us in undesired state sometime. Consider following call

[PATCH 7/9] scsi: ufs: make sure all interrupts are processed

From: Venkat Gopalakrishnan As multiple requests are submitted to the ufs host controller in parallel there could be instances where the command completion interrupt arrives later for a request that is already processed earlier as the corresponding doorbell was cleared

[PATCH 8/9] scsi: ufs: fix irq return code

From: Venkat Gopalakrishnan Return IRQ_HANDLED only if the irq is really handled, this will help in catching spurious interrupts that go unhandled. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Can Guo Signed-off-by:

[PATCH 1/9] scsi: ufs: Allowing power mode change

From: Yaniv Gardi Due to M-PHY issues, moving from HS to any other mode or gear or even Hibern8 causes some un-predicted behavior of the device. This patch fixes this issues. Signed-off-by: Yaniv Gardi Signed-off-by: Subhash Jadavani

[PATCH 3/9] scsi: ufs: fix exception event handling

From: Maya Erez The device can set the exception event bit in one of the response UPIU, for example to notify the need for urgent BKOPs operation. In such a case the host driver calls ufshcd_exception_event_handler to handle this notification. When trying to check the

[Bug 198839] Backport of the Linux MegaRAID driver for SAS based RAID controllers

https://bugzilla.kernel.org/show_bug.cgi?id=198839 --- Comment #3 from Sumit Saxena (sumit.sax...@broadcom.com) --- (In reply to doru iorgulescu from comment #2) > Created attachment 274275 [details] > attachment-17443-0.html > > Hi, > The problem is in kernel 4.9.82 > #define MEGASAS_VERSION

[4.4-stable 08/22] ncr5380: shut up gcc indentation warning

gcc-6 and higher warn about the way some loops are written in the ncr5380 driver: drivers/scsi/g_NCR5380.c: In function 'generic_NCR5380_pread': drivers/scsi/g_NCR5380.c:541:3: error: this 'while' clause does not guard... [-Werror=misleading-indentation] while

[PATCH 2/2] scsi: myrs: bitwise vs logical OR typo

We accidentally used a logical || instead of a | so these bit masks are off. Fixes: 8a8606895947 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c index

Re: [PATCH] scsi: cxlflash: Select SCSI_SCAN_ASYNC

Vaibhav Jain writes: > The cxlflash driver uses "Asynchronous SCSI scanning" enabled by > CONFIG_SCSI_SCAN_ASYNC. Without this enabled the modprobe of cxlflash > module gets hung with following backtrace: > > Call Trace: > __switch_to+0x2cc/0x470 >

[PATCH 1/2] scsi: myrs: cleanup myrs_store_suppress_enclosure_messages()

This code causes a static checker because we have an upper bound on "value" but not a lower bound. In other words "value" can be s32min-2. It's harmless but really it should just be bool. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/myrs.c

[Bug 198839] Backport of the Linux MegaRAID driver for SAS based RAID controllers

https://bugzilla.kernel.org/show_bug.cgi?id=198839 --- Comment #6 from doru iorgulescu (doru.iorgules...@gmail.com) --- Hi, It must be in oficial kernel 4.9.82 Regards, Doru Iorgulescu On Tue, Feb 20, 2018 at 11:54 AM, wrote: >

[Bug 198839] Backport of the Linux MegaRAID driver for SAS based RAID controllers

https://bugzilla.kernel.org/show_bug.cgi?id=198839 --- Comment #4 from doru iorgulescu (doru.iorgules...@gmail.com) --- Not oficial, I have tested : I copy /usr/src/linux-4.14.20/drivers/scsi/megaraid to /usr/src/linux-4.9.82/drivers/scsi/megaraid . I compile the kernel 4.9.82 and is OK ! You

[Bug 198839] Backport of the Linux MegaRAID driver for SAS based RAID controllers

https://bugzilla.kernel.org/show_bug.cgi?id=198839 --- Comment #5 from Sumit Saxena (sumit.sax...@broadcom.com) --- (In reply to doru iorgulescu from comment #4) > Created attachment 274279 [details] > attachment-9893-0.html > > Not oficial, > I have tested : > I copy

[PATCH] scsi: ufs: add trace event for ufs upiu

Add UFS Protocol Information Units(upiu) trace events for ufs driver, used to trace various ufs transaction types- command, task-management and device management. The trace-point format is generic and can be easily adapted to trace other upius if needed. Currently tracing ufs transaction of type

[PATCH] megaraid_sas: Re-enable WRITE SAME

Below commit disable WRITE SAME behavior via host template no_write_same settings for megaraid_sas driver. commit 54b2b50c20a6 ("[SCSI] Disable WRITE SAME for RAID and virtual host adapter drivers") For MegaRAID controller we want to support WRITE SAME for non-raid volumes. Because of host wide

Re: [PATCH] libiscsi: ensure session spin lock usage consistent

On 02/07/2018 08:36 PM, Chris Leech wrote: > On Mon, Feb 05, 2018 at 11:13:23AM -0800, Lee Duncan wrote: >> The libiscsi code was using both spin_lock()/spin_unlock() >> and spin_lock_bh()/spin_unlock_bh() on its session lock. >> In addition, lock validation found that libiscsi.c was >> taking a

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

On 2/19/2018 12:14 AM, Johannes Thumshirn wrote: On Fri, Feb 16, 2018 at 08:53:44AM -0800, James Smart wrote: Any reason you can't use writeq() on 32 Bit as well? There's a compat version in linux/io-64-nonatomic-hi-lo.h. We actually ran into issues on the existence of writeq() on a 32bit

Re: [PATCH] mvsas: fix wrong endianess of sgpio api

On Mon, 2018-02-19 at 21:11 +0100, wilfried.weissm...@gmx.at wrote: > From: Wilfried Weissmann Every patch should have a description that not only explains what has been changed but also why these changes have been made. Please add such a description. Additionally,