Re: [PATCH] bsg referencing bus driver module

Any comments on the new patch (which, I think, addresses the concern about module being stuck in unloadable state forever; if not, there would be a leak in the bsg layer)? Or on dropping a reference to bsg_class_device's parent early before the bsg_class_device itself is gone, to implement James's

Re: [PATCH] aacraid: Correct hba_send to include iu_type

Dave, > commit b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()") > > allows aac_hba_send() to send scsi commands, and TMF requests, but the > existing > code only updates the iu_type for scsi commands. For TMF requests we are > sending > an unknown iu_type to firmware,

Re: [PATCH] scsi: esas2r: fix spelling mistake: "asynchromous" -> "asynchronous"

Colin, > Trivial fix to spelling mistake in module description text Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[RESEND V2 2/6] tcmu: refactor add_device cmd with new nl helpers

use new netlink events helpers tcmu_netlink_init() and tcmu_netlink_send() to refactor netlink event TCMU_CMD_ADDED_DEVICE Signed-off-by: Zhu Lingshan --- Changes in V2: - return tcmu_netlink_event_send() directly, instead of a ret value. drivers/target/target_core_user.c |

[RESEND V2 1/6] tcmu: add new netlink events helpers

Add new netlink events helpers tcmu_netlink_event_init() and tcmu_netlink_event_send(). These new functions intend to replace exsiting netlink events helper function tcmu_netlink_event(). The exsiting function tcmu_netlink_event() works well for events like TCMU_ADDED_DEVICE and

[RESEND V2 5/6] tcmu: refactor nl dev_size attr with new helpers

use new netlink events helpers tcmu_netlink_init() and tcmu_netlink_send() to refactor netlink event attribute TCMU_ATTR_DEV_SIZE(belongs to TCMU_CMD_RECONFIG_DEVICE) which is also dev_size in configFS. Signed-off-by: Zhu Lingshan --- Changes in V2: - return

[RESEND V2 6/6] tcmu: refactor nl wr_cache attr with new helpers

use new netlink events helpers tcmu_netlink_init() and tcmu_netlink_send() to refactor netlink event attribute TCMU_ATTR_WRITECACHE(belongs to TCMU_CMD_RECONFIG_DEVICE) which is also emulate_write_cache in configFS. Removed tcmu_netlink_event() since we have new netlink events helpers now.

[RESEND V2 4/6] tcmu: refactor nl dev_cfg attr with new nl helpers

use new netlink events helpers tcmu_netlink_init() and tcmu_netlink_send() to refactor netlink event attribute TCMU_ATTR_DEV_CFG(belongs to TCMU_CMD_RECONFIG_DEVICE) which is also dev_config in configFS. Signed-off-by: Zhu Lingshan --- Changes in V2: - return

[RESEND V2 3/6] tcmu: refactor rm_device cmd with new nl helpers

use new netlink events helpers tcmu_netlink_init() and tcmu_netlink_send() to refactor netlink event TCMU_CMD_REMOVED_DEVICE Signed-off-by: Zhu Lingshan --- Changes in V2: - return tcmu_netlink_event_send() directly, instead of a ret value. drivers/target/target_core_user.c |

Re: [PATCH] scsi: vmw-pvscsi: return DID_BUS_BUSY for adapter-initated aborts

Jim, > The vmw_pvscsi driver returns DID_ABORT for commands aborted internally > by the adapter, leading to the filesystem going read-only. Change the > result to DID_BUS_BUSY, causing the kernel to retry the command. Applied to 4.17/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux

Re: [PATCH] scsi: mpt3sas: fix spelling mistake: "disbale" -> "disable"

Colin, > Trivial fix to spelling mistake in module parameter description text Ditto. Also hand-applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid_sas: fix spelling mistake: "disbale" -> "disable"

Colin, > Trivial fix to spelling mistake in module parameter description text Mangled patch. Applied by hand. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 01/14] mpt3sas: Bug fix for big endian systems.

Hi Chaitra, >> for (i = 0; i < ioc->combined_reply_index_count; i++) { >> -ioc->replyPostRegisterIndex[i] = (resource_size_t > *) >> - ((u8 *)>chip->Doorbell + >> +ioc->replyPostRegisterIndex[i] = >> +

Re: [PATCH] scsi_transport_sas: don't bounce highmem pages for the smp handler

Christoph, > All three instance of ->smp_handler deal with highmem backed requests > just fine. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: isci: remove redundant check on in_connection_align_insertion_frequency

Colin, > The sanity check on u->in_connection_align_insertion_frequency is > being performed twice and hence the first check can be removed since > it is redundant. Cleans up cppcheck warning: > > drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if' > condition is always true.

[PATCH 03/12] qla2xxx: Fix Rport and session state getting out of sync

From: Quinn Tran This patch fixes rport state and session state getting out of sync. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 30 --

[PATCH 06/12] qla2xxx: Move GPSC and GFPNID out of session management

From: Quinn Tran Move GPSC & GFPNID commands out of session management to reduce time lag in reporting the session state to remote port. These commands are not essential when it comes to maintaining the rport state. Delay sending these commands after rport state is set to

[PATCH 08/12] qla2xxx: Use predefined get_datalen_for_atio() inline function

From: Quinn Tran o Uses predefine inline function to access add_cdb_len field in ATIO. o Return SS_RESIDUAL_UNDER status when sending BUSY Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 04/12] qla2xxx: Delete session for nport id change

From: Quinn Tran This patch fixes regression introduced by commit a4239945b8ad ("scsi: qla2xxx: Add switch command to simplify fabric discovery"). to schedule session deletion, when Nport ID changes. Fixes: a4239945b8ad ("scsi: qla2xxx: Add switch command to simplify

[PATCH 00/12] qla2xxx: Updates for driver

Hi Martin, This series contains updates for driver. Please apply this to 4.18 scsi-misc branch at your earliest convenience. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Add Laser Control for ISP26XX/27XX qla2xxx: Prevent relogin loop by removing stale code qla2xxx: Update driver

[PATCH 01/12] qla2xxx: Add Laser Control for ISP26XX/27XX

From: Himanshu Madhani This patch disables laser while unloading driver for 16/32G adapters. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 7 drivers/scsi/qla2xxx/qla_fw.h | 2 ++

[PATCH 02/12] qla2xxx: Fix sending ADISC command for login

From: Quinn Tran This patch fixes login_retry login for ADISC command. when login_retry count reaches 0, futher attempt to send ADISC command is ignored by the code. Remove this redundant login_retry count check from qla24xx_fcport_handle_login() Signed-off-by: Quinn

[PATCH 12/12] qla2xxx: Update driver version to 10.00.00.07-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0c55d7057280..1ad7582220c3 100644 ---

[PATCH 07/12] qla2xxx: Fix Inquiry command being dropped in Target mode

From: Quinn Tran When a connection is established, the target core session may not be created immediately. Current code will drop/terminate the command based on the session state. This patch will return BUSY status for any commands arriving on wire before the session is

[PATCH 11/12] qla2xxx: Fix TMF and Multi-Queue config

From: Quinn Tran For target mode, task management command is queued to specific cpu base on where the scsi command is residing. This prevent race condition of task management command getting ahead of regular scsi command. Signed-off-by: Quinn Tran

[PATCH 10/12] qla2xxx: Prevent relogin loop by removing stale code

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 3405cb9031b6..1aa3720ea2ed 100644 ---

[PATCH 05/12] qla2xxx: Reduce redundant ADISC command for RSCNs

From: Quinn Tran For each RSCN that triggers a rescan of the fabric, ADISC is used to revalidate an existing session. if the RSCN is not affecting all existing sessions, then driver should not send redundant ADISC for all existing sessions. Signed-off-by: Quinn Tran

[PATCH 09/12] qla2xxx: Remove stale debug value for login_retry flag

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c